Koha/opac
Marc Véron f25f0aa254 Bug 15288: Error pages: Code duplication removal and better translatability
This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled
by only one template for staff and only one template for OPAC.

Additionally it removes a translatability issues due to sentence splitings by html tags.

To test:
- Apply patch
- Trigger 404 error for staff and for OPAC by calling a page that does not exist
- Try to trigger other error pages and/or carefully review code changes
  in the *.pl files
- Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and
  koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt

(Amended to fix a typo)
(Amended for comment #6)
(Amended to cover OPAC error pages as well)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-01-27 05:57:34 +00:00
..
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
rss
sco
svc Bug 9303 [QA Followup] - Restore missing svc script 2015-12-31 13:09:49 +00:00
ilsdi.pl Bug 6679 - Fixing code so it passes basic Perl:::Critic tests 2016-01-27 05:06:23 +00:00
maintenance.pl
oai.pl Bug 14939: Modularize OAI Server existing classes 2015-12-31 15:15:05 +00:00
opac-account-pay-paypal-return.pl Bug 11622 [QA Followup] - Fix currency issue, add error template 2015-12-31 13:28:02 +00:00
opac-account-pay.pl Bug 11622 [QA Followup] - Fix currency issue, add error template 2015-12-31 13:28:02 +00:00
opac-account.pl Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl 2015-12-31 13:28:02 +00:00
opac-addbybiblionumber.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-01-27 02:31:42 +00:00
opac-alert-subscribe.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-authorities-home.pl Bug 15381: Remove getauthtypes and getauthtype 2015-12-31 18:59:02 +00:00
opac-authoritiesdetail.pl Bug 15550: Fix authority search and detail at the OPAC 2016-01-23 18:34:06 +00:00
opac-basket.pl
opac-blocked.pl
opac-browser.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-changelanguage.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-details.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-reserves.pl
opac-detail.pl Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page 2015-11-05 09:58:02 -03:00
opac-discharge.pl
opac-downloadcart.pl Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page 2015-11-05 09:58:02 -03:00
opac-downloadshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-01-27 02:31:42 +00:00
opac-export.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-ics.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-30 11:53:18 +00:00
opac-idref.pl
opac-image.pl
opac-imageviewer.pl
opac-ISBDdetail.pl
opac-main.pl Bug 15613: Fix 2 other occurrences of paramter vs parameter 2016-01-27 05:16:23 +00:00
opac-MARCdetail.pl Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl 2015-12-30 15:36:02 +00:00
opac-memberentry.pl Bug 9303 [QA Followup] - Restore ability for patron to control setting 2015-12-31 13:09:45 +00:00
opac-messaging.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-30 11:53:18 +00:00
opac-modrequest-suspend.pl
opac-modrequest.pl
opac-mymessages.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-news-rss.pl Bug 7843: (QA followup) Make news selection persistant 2015-04-30 16:33:21 -03:00
opac-overdrive-search.pl
opac-passwd.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-30 11:53:18 +00:00
opac-patron-image.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
opac-privacy.pl Bug 9303 [QA Followup] - Restore ability for patron to control setting 2015-12-31 13:09:45 +00:00
opac-ratings-ajax.pl Bug 14553: Silencing warn triggered when clearing item rating on OPAC 2015-11-11 11:08:50 -03:00
opac-ratings.pl Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl) 2015-06-25 14:41:21 -03:00
opac-readingrecord.pl Bug 14100: Fix 3 occurrences more 2015-10-27 12:34:07 -03:00
opac-registration-verify.pl Bug 11693: Default emailing preferences not loaded for self registering patron 2015-07-24 13:44:39 -03:00
opac-renew.pl
opac-reserve.pl Bug 15375 [QA Followup] - Fix non-functional restriction message and date 2016-01-27 05:25:04 +00:00
opac-restrictedpage.pl Bug 13485: Use the Koha template plugin to access syspref values 2015-08-11 15:15:36 -03:00
opac-retrieve-file.pl Bug 14321: Integrate Upload.pm into Koha 2015-09-25 12:02:52 -03:00
opac-review.pl
opac-search-history.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-search.pl Bug 15613: Fix 2 other occurrences of paramter vs parameter 2016-01-27 05:16:23 +00:00
opac-sendbasket.pl
opac-sendshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-01-27 02:31:42 +00:00
opac-serial-issues.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-shareshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-01-27 02:31:42 +00:00
opac-shelves.pl Bug 4912: Redirect to the appropriate view after editing/deleting a list 2016-01-27 02:34:40 +00:00
opac-showmarc.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-showreviews.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-suggestions.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-tags.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
opac-tags_subject.pl
opac-topissues.pl Bug 14100: Fix some missing occurrences 2015-10-27 12:34:07 -03:00
opac-user.pl Bug 9303 [3] - relative's checkouts in the opac 2015-12-31 13:08:06 +00:00
tracklinks.pl
unapi Bug 15190: Bad utf8 decode to unapi and fixing status code 200 2016-01-27 05:28:28 +00:00