Koha/t/db_dependent
Kyle M Hall f2dd831542 Bug 14694 - Make decreaseloanHighHolds more flexible
This patch allows for more flexibility for determining when the number
of holds a record has should trigger the reduction of the loan length
for items on that record.

This patch adds a new system preference decreaseLoanHighHoldsControl,
which defaults to 'static', the original behavior of the feature.
It also has a new behavior 'dynamic' which makes the feature only
decrease the loan length if the number of holds on the record exceeds
the number of holdable items + decreaseLoanHighHoldsValue.

It also allows items to be filtered from the list of items based
on the damaged, lost, not for loan, and withdrawn values even if
those values would have allowed holds ( i.e. values < 0 )

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set decreaseLoanHighHolds to Enable
4) Set decreaseLoanHighHoldsControl to "over the number of items on the record"
5) Set decreaseLoanHighHoldsDuration to 1
6) Set decreaseLoanHighHoldsValue to 3
7) Create a record with 5 items
8) Please 8 or more holds on the record
9) Check out one of the items to a patron
10) Note the loan length is reduced to 1 day
11) Set decreaseLoanHighHoldsValue to 3 to 2
12) Check out one of the items to a patron
13) Note the loan length is *not* reduced
14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses
15) Set one item to be damaged
16) Note the loan length is reduced
17) Unset the damaged status
18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-07 17:48:51 +00:00
..
Acquisition Bug 5404: C4::Koha - remove subfield_is_koha_internal_p 2016-03-07 17:30:09 +00:00
api/v1 Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Auth Bug 15756: Some tests for haspermission in C4::Auth 2016-02-23 20:54:42 +00:00
Biblio Bug 15572: Add tests for TransformHtmlToMarc 2016-01-25 07:09:50 -07:00
Circulation Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Creators Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
data Bug 12419: (QA followup) regression tests 2014-06-30 15:57:23 -03:00
Exporter Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Holds Bug 14878: (QA followup) Remove useless diag 2015-11-06 15:51:52 -03:00
Items Bug 11023: Automatic item modification by age (Was Toggle "new" status") 2016-03-02 22:56:31 +00:00
Koha Bug 15635 [QA Followup] - Fix number of unit tests 2016-03-04 12:54:24 +00:00
Labels Bug 14468: (QA followup) remove useless diags 2015-10-27 10:38:15 -03:00
LDAP
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
OAI Bug 14939: Remove the Capture::Tiny dependency 2015-12-31 15:15:35 +00:00
Patron Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Record Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
Reports Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Reserves Bug 13592: Add an option to charge for any hold placed 2015-12-31 15:59:05 +00:00
Search Bug 10933: (followup of the followup) fix the previous patch to work with master 2015-10-27 13:06:01 -03:00
Serials Bug 15168: (followup) remove useless diags 2015-11-17 15:47:46 -03:00
Template/Plugin Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Utils Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
www Bug 10363: (QA followups) Fix tests 2015-10-21 17:23:38 -03:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
00-strict.t Bug 7844: (follow-up) don't test koha.psgi for ability to compile (yet) 2014-04-29 19:34:23 +00:00
Accounts.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Acquisition.t Bug 13967: (QA followup) Make DBIx control transactions on tests 2015-06-04 15:12:45 -03:00
AdditionalField.t Bug 10855: Remove additional field values when subscription is removed 2015-10-02 15:10:31 -03:00
Amazon.t
AudioAlerts.t Bug 11431: (QA followup) remove diags 2015-11-06 15:08:37 -03:00
Auth.t Bug 15288: (QA followup) Tests still point to old 500.tt file 2016-03-02 23:13:35 +00:00
Auth_with_cas.t Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t 2015-07-20 10:32:21 -03:00
Auth_with_ldap.t Bug 12831: (RM followup) regression test 2014-11-27 14:45:11 -03:00
AuthorisedValues.t Bug 10363: Use Koha::AuthorisedValue[s] in the admin page 2015-10-19 12:46:27 -03:00
AuthoritiesMarc.t Bug 10985: [UNIMARC] Fix authority summary 2015-04-22 11:54:36 -03:00
BackgroundJob.t Bug 13606: Add tests and fix existing ones 2015-04-23 13:18:49 -03:00
Barcodes.t Bug 13673: (QA followup) Add license 2015-05-15 16:00:28 -03:00
Barcodes_ValueBuilder.t Bug 15081: (QA followup) Fix issue with Barcodes_ValueBuilder.t 2015-11-04 12:32:57 -03:00
Biblio.t Bug 5404: [QA Follow-up] Add test descriptions 2016-03-07 17:30:09 +00:00
BiblioObject.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Bookseller.t Bug 14334: t/db_dependent/Bookseller.t AutoCommit fix 2015-06-07 18:51:21 -03:00
Branch.t Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories 2016-02-24 03:55:07 +00:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 15004: Ensure that the reset_all_budgets behavior is kept 2016-01-27 06:05:02 +00:00
Category.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
check_sysprefs.t Bug 14383: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
Circulation.t Bug 15675 - Add issue_id column to accountlines and use it for updating fines 2016-03-02 03:24:45 +00:00
Circulation_Branch.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_dateexpiry.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Circulation_issue.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_Issuingrule.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_issuingrules.t Bug 14778: Use mock_dbh where it should be used 2015-10-23 12:01:18 -03:00
Circulation_OfflineOperation.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_transfers.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
ClassSource.t
ColumnsSettings.t Bug 10212: Columns configuration for tables - Unit tests 2014-08-26 09:28:18 -03:00
Context.t Bug 15446: Add tests 2016-02-12 12:35:56 -07:00
Contract.t Bug 14693: Contract.t should generate dates based on current date 2015-08-21 10:43:38 -03:00
CourseReserves.t Bug 15530 - Add Unit Test 2016-01-27 00:58:14 +00:00
Csv.t Bug 10853: (follow-up) expand unit tests for C4::Csv 2013-10-11 03:25:42 +00:00
db_structure.t Bug 15517: Change wording for tests 2016-02-23 23:08:20 +00:00
DecreaseLoanHighHolds.t Bug 14694 - Make decreaseloanHighHolds more flexible 2016-03-07 17:48:51 +00:00
default_search_class.pl Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
External_BakerTaylor.t
Fines.t Bug 13590: Add ability to charge fines at start of charge period 2015-10-22 14:51:24 -03:00
FrameworkPlugin.t Bug 14199: Unify marc orgcode plugins, not overwriting existing values 2016-02-26 14:04:28 +00:00
Heading_MARC21.t
Hold.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Holds.t Bug 14310 [QA Followup] - Adapt existing code to use new methods 2016-01-27 06:20:19 +00:00
HoldsQueue.t Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes 2016-03-03 20:19:00 +00:00
Holidays.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
ILSDI_Services.t Bug 15629: Koha::Libraries - Remove GetBranchDetail 2016-02-24 03:55:06 +00:00
ImportBatch.t Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio 2015-04-16 13:40:59 -03:00
Installer.t Bug 11541: (follow-up) move Installer.t to t/db_dependent 2014-01-14 21:43:56 +00:00
Items.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Items_DelItem.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 4941: Make tests non DB dependent 2016-02-26 12:13:04 +00:00
Koha_Authority.t Bug 15578: Insert authority records before processing tests 2016-01-23 18:28:49 +00:00
Koha_borrower_modifications.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
Koha_Misc_Files.t Bug 3050: QA follow-up 2014-05-25 21:15:03 +00:00
Koha_template_plugin_Branches.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Koha_template_plugin_KohaDates.t Bug 14977: Remove C4::Dates from files t/db_dependent/*.t 2015-10-29 11:58:44 -03:00
Languages.t Bug 14030 - Added tests for duplicates. 2015-04-24 09:55:54 -03:00
Letters.t Bug 12426: Simplify the code adding a new subroutine GetMessage 2016-03-03 20:16:07 +00:00
Linker_FirstMatch.t
Log.t Bug 15939: Action logs - Do not default dates to today 2016-03-02 00:53:14 +00:00
MarcModificationTemplates.t Bug 15669: Add a test for GetModificationTemplates 2016-03-03 22:11:44 +00:00
Members.t Bug 15632: Koha::Patron::Messages - Remove tests 2016-03-03 21:22:14 +00:00
Members_Attributes.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Members_columns.t
MungeMarcPrice.t Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
NewsChannels.t Bug 14977: Followup to fix issue with NewsChannels.t 2015-10-29 11:58:52 -03:00
Overdues.t Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 2015-12-31 12:47:16 +00:00
Passwordrecovery.t Bug 15548 [QA Followup] - More new uses of Koha::Borrower 2016-03-03 14:39:00 -07:00
Patron.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
PatronLists.t Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test 2013-10-14 21:30:34 +00:00
Patrons.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
Plugins.t Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool 2015-05-04 15:33:51 -03:00
QueryParser.t Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
Ratings.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Record.t Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Reports.t
Reports_Guided.t Bug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data 2015-11-16 15:55:22 -03:00
ReportsGuided.t Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory 2016-03-02 03:54:16 +00:00
Reserves.t Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration 2015-12-11 16:08:50 +00:00
Review.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
rollingloans.t Bug 13315 - Add feedback for last item checked out to circulation.pl 2015-04-13 14:52:26 -03:00
RotatingCollections.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Search.t Bug 9819: Make the tests pass 2015-12-30 15:50:15 +00:00
Serials.t Bug 15168: Remove C4:Serials::ItemizeSerials 2015-11-17 15:34:00 -03:00
Serials_2.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Service.t
ShelfBrowser.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
SIP_ILS.t Bug 7904: (QA followup) fix tests 2015-02-05 15:50:32 -03:00
SIPILS.t Bug 15947: move SIPILS.t to DB-dependent test directory 2016-03-02 22:02:10 +00:00
Sitemapper.t Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t 2015-10-23 12:01:18 -03:00
Stats.t Bug 11230 - Refactor C4::Stats::UpdateStats and add UT 2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t Bug 12653: remaining prog reference in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2014-10-29 23:37:54 -03:00
Suggestions.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
sysprefs.t Bug 13967: Add a couple of tests for SysPref and Object 2015-06-04 10:39:16 -03:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
TestBuilder.t Bug 15601: Fix TestBuilder tests 2016-01-23 19:01:41 +00:00
Upload.t Bug 14893: Separate temporary storage per instance in Upload.pm 2016-01-29 01:17:55 +00:00
UsageStats.t Bug 14097: Fixed missing test cases 2016-02-24 03:04:36 +00:00
Virtualshelves.t Bug 14544: [QA Follow-up] Added some test descriptions 2015-11-05 10:00:31 -03:00
XISBN.t Bug 12782: (followup) skip tests that fail because of provider's error 2014-08-20 12:29:27 -03:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
zebra_config.pl Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection 2015-10-29 14:10:23 -03:00