Koha/serials
Jonathan Druart f45fe692b1 Bug 22849: Do not share data (Mana) without agreement
A couple of things wrong in serials/subscription-add.pl

1.
447     if ( defined( $query->param('mana_id') ) ) {

It's always defined, you wanted to test with ""

2.
375     if ( (C4::Context->preference('Mana')) and ( grep { $_ eq "subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){

Mana == 2 == let me think about it
=> I am not expecting to reach Koha::SharedContent in that case

So we are sharing data whereas the library did not decide yet!

Test plan:
You need to be familiar you Mana to test this patch.

JD: I did not test this patch

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-05-14 18:06:17 +00:00
..
acqui-search-result.pl Bug 20015: use Modern::Perl in Serials perl script 2018-02-05 09:46:45 -03:00
acqui-search.pl Bug 20015: use Modern::Perl in Serials perl script 2018-02-05 09:46:45 -03:00
add_user_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
checkexpiration.pl Bug 20015: use Modern::Perl in Serials perl script 2018-02-05 09:46:45 -03:00
claims.pl Bug 15774: Use Koha::Object(s) for additional fields 2019-03-07 20:37:05 +00:00
create-numberpattern.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
lateissues-export.pl Bug 18536: [QA Follow-up] Tiny regex simplification 2017-05-19 10:41:39 -04:00
reorder_members.pl Bug 20015: use Modern::Perl in Serials perl script 2018-02-05 09:46:45 -03:00
routing-preview.pl Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
routing.pl Bug 20351: Shortcut serials scripts if a blocking error appeared 2018-10-17 14:25:30 +00:00
serials-collection.pl Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
serials-edit.pl Bug 20351: Shortcut serials scripts if a blocking error appeared 2018-10-17 14:25:30 +00:00
serials-home.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
serials-search.pl Bug 15774: (follow-up) fix rebase issues 2019-03-07 20:37:06 +00:00
showpredictionpattern.pl Bug 15149: Serial test prediction pattern does not consider end date 2019-02-26 13:10:34 +00:00
subscription-add.pl Bug 22849: Do not share data (Mana) without agreement 2019-05-14 18:06:17 +00:00
subscription-batchedit.pl Bug 15774: Use Koha::Object(s) for additional fields 2019-03-07 20:37:05 +00:00
subscription-bib-search.pl Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-09-28 19:35:15 +00:00
subscription-detail.pl Bug 15774: Use the include file to display the subscription's additional fields 2019-03-07 20:37:06 +00:00
subscription-frequencies.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
subscription-frequency.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
subscription-history.pl Bug 18260: Koha::Biblio - Remove GetBiblio 2017-07-10 13:03:38 -03:00
subscription-numberpattern.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
subscription-numberpatterns.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
subscription-renew.pl Bug 20351: Shortcut serials scripts if a blocking error appeared 2018-10-17 14:25:30 +00:00
viewalerts.pl Bug 19855: Move getalert, addalert and delalert to Koha::Subscription 2018-04-23 14:22:15 -03:00