David Cook
f6daff353d
This patch fixes the "Publication date" and "Acquisition date" searches when using non-QueryParser and QueryParser searches. It adds structure attributes to the template, which is consistent with how phrase searching is currently handled. It removes unnecessary code from Search.pm, adds some necessary code which is consistent with existing code, and adds a lot of explanatory comments. _TEST PLAN_ Before applying: 0) Turn off QueryParser 1) Try a "Publication date" or "Acquisition date" search from the staff client advanced search. 2) Note that even though the description on the result page makes it seem like you're doing an index-specific search, you're actually doing a keyword search. You can verify this by checking the 008 from positions 7 to 10 for "Publication date" or "Date accessioned" on items for "Acquisition date". 3) Turn on QueryParser 4) Try doing the searches from Step 1. 5) A "Publication date" search should probably produce zero results After applying patch: 6) Keep QueryParser on 7) Try doing the searches from Step 1. 8) Notice that you're actually getting results consistent with your search (ie the 008/7-10 shows the date you searched for, and there is a "Date accessioned" in items which matches your search) 9) Turn off QueryParser 10) Note that your results are exactly the same as step 8 (N.B. this is because QueryParser is falling back to non-QP mode instead of producing a bad query.) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> |
||
|---|---|---|
| .. | ||
| en | ||
| img | ||
| sound | ||