Jonathan Druart
f7214859df
On the edit items page, there is some weird JS code: if the user clicks
on the delete link and then cancel, the item is deleted anyway.
It's caused by the following JS code in browser.js
$('a[href*="biblionumber="]').click(function (ev) {
ev.preventDefault();
window.location = $(this).attr('href') + '&searchid=' + me.searchid;
});
Test plan:
- Do a search with multiple results
- Go to the detail page (make sure results browser shows up!)
- Use the "Edit items" link from the toolbar
- Delete an item (try both way)
- Choose "cancel"
- Delete an item (try both way) and confirm the deletion
You should see the browser after the deletion and the item should have
been deleted correctly.
- Edit an item (try both way)
You should see the browser (did not work before this patch)
Note: Before this patch, the 2 first columns didn't contain the
edit/delete item links, now it's only the 1st one.
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Much better!
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
301 lines
16 KiB
Text
301 lines
16 KiB
Text
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Cataloging › [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %]) › Items</title>
|
|
<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
[% INCLUDE 'datatables.inc' %]
|
|
<script type="text/javascript" src="[% themelang %]/js/cataloging.js"></script>
|
|
[% INCLUDE 'browser-strings.inc' %]
|
|
<!--[if lt IE 9]>
|
|
<script type="text/javascript" src="[% interface %]/lib/shims/json2.min.js"></script>
|
|
<![endif]-->
|
|
<script type="text/javascript" src="[% interface %]/js/browser.js"></script>
|
|
<script type="text/javascript">
|
|
//<![CDATA[
|
|
var browser = KOHA.browser('[% searchid %]', parseInt('[% biblionumber %]', 10));
|
|
browser.show();
|
|
|
|
$(document).ready(function(){
|
|
|
|
// Remove the onclick event defined in browser.js,
|
|
// otherwise the deletion confirmation will not work correctly
|
|
$('a[href*="biblionumber="]').off('click');
|
|
|
|
[% IF (popup) %]
|
|
[% IF (opisadd) %]
|
|
window.close();
|
|
[% END %]
|
|
[% END %]
|
|
$("fieldset.rows input, fieldset.rows select").addClass("noEnterSubmit");
|
|
/* Inline edit/delete links */
|
|
var biblionumber = $("input[name='biblionumber']").attr("value");
|
|
$("tr.editable").each(function(){
|
|
$(this).find("td:not(:first)").on('click', function(){
|
|
var rowid = $(this).parent().attr("id");
|
|
num_rowid = rowid.replace("row","");
|
|
$(".linktools").remove();
|
|
var edit_link = $('<a href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&frameworkcode=[% frameworkcode %]&biblionumber=[% biblionumber %]&itemnumber='+num_rowid+'&searchid=[% searchid %]#edititem">' + _("Edit item") + '</a>');
|
|
var delete_link = $('<a href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&frameworkcode=[% frameworkcode %]&biblionumber=[% biblionumber %]&itemnumber='+num_rowid+'&searchid=[% searchid %]">' + _("Delete item") + '</a></span>');
|
|
$(delete_link).on('click', function(e) {
|
|
return confirm_deletion();
|
|
});
|
|
var tools_node = $('<span class="linktools"></span>');
|
|
$(tools_node).append(edit_link);
|
|
$(tools_node).append(delete_link);
|
|
$(this).append(tools_node);
|
|
});
|
|
});
|
|
|
|
var itemst = $("#itemst").dataTable($.extend(true, {}, dataTablesDefaults, {
|
|
"aoColumnDefs": [
|
|
{ "aTargets": [ 0 ], "bSortable": false, "bSearchable": false },
|
|
],
|
|
'bPaginate': false,
|
|
'bInfo': false,
|
|
"bAutoWidth": false
|
|
} ) );
|
|
|
|
});
|
|
function Check(f) {
|
|
var total_errors = CheckMandatorySubfields(f);
|
|
if (total_errors==0) {
|
|
// Explanation about this line:
|
|
// In case of limited edition permission, we have to prevent user from modifying some fields.
|
|
// But there is no such thing as readonly attribute for select elements.
|
|
// So we use disabled instead. But disabled prevent values from being passed through the form at submit.
|
|
// So we "un-disable" the elements just before submitting.
|
|
// That's a bit clumsy, and if someone comes up with a better solution, feel free to improve that.
|
|
$("select[name=field_value]").removeAttr("disabled");
|
|
return true;
|
|
} else {
|
|
var alertString2 = _("Form not submitted because of the following problem(s)");
|
|
alertString2 += "\n------------------------------------------------------------------------------------\n";
|
|
alertString2 += "\n- " + _("%s mandatory fields empty (highlighted)").format(total_errors);
|
|
alert(alertString2);
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
function CheckMultipleAdd(f) {
|
|
|
|
if (!f || isNaN(f) || !parseInt(f) == f || f <= 0) {
|
|
alert(_("Please enter a number of items to create."));
|
|
return false;
|
|
}
|
|
<!-- Add a soft-limit of 99 with a reminder about potential data entry error -->
|
|
if (f>99) {
|
|
return confirm(_("You are about to add %s items. Continue?").format(f));
|
|
}
|
|
}
|
|
function Dopop(link,i) {
|
|
defaultvalue=document.forms[0].field_value[i].value;
|
|
newin=window.open(link+"&result="+defaultvalue,"valuebuilder",'width=500,height=400,toolbar=false,scrollbars=yes');
|
|
}
|
|
|
|
function confirm_deletion() {
|
|
return confirm(_("Are you sure you want to delete this item?"));
|
|
}
|
|
|
|
//]]>
|
|
</script>
|
|
<link type="text/css" rel="stylesheet" href="[% themelang %]/css/addbiblio.css" />
|
|
[% IF ( bidi ) %]
|
|
<link rel="stylesheet" type="text/css" href="[% themelang %]/css/right-to-left.css" />
|
|
[% END %]
|
|
</head>
|
|
<body id="cat_additem" class="cat">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cataloging-search.inc' %]
|
|
|
|
<div id="breadcrumbs">
|
|
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
|
|
› <a href="/cgi-bin/koha/cataloguing/addbooks.pl">Cataloging</a>
|
|
› Edit <a href="/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=[% biblionumber %]">[% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</a>
|
|
› <a href="/cgi-bin/koha/cataloguing/additem.pl?biblionumber=[% biblionumber %]">Items</a>
|
|
</div>
|
|
|
|
<div id="doc3" class="yui-t7">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
|
|
<h1>Items for [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1>
|
|
|
|
[% IF ( barcode_not_unique ) %]<div class="dialog alert"><strong>Error saving item</strong>: Barcode must be unique.</div>[% END %]
|
|
[% IF ( no_next_barcode ) %]<div class="dialog alert"><strong>Error saving items</strong>: Unable to automatically determine values for barcodes. No item has been inserted.</div>[% END %]
|
|
[% IF ( book_on_loan ) %]<div class="dialog alert"><strong>Cannot delete</strong>: item is checked out.</div>[% END %]
|
|
[% IF ( book_reserved ) %]<div class="dialogalert"><strong>Cannot delete</strong>: item has a waiting hold.</div>[% END %]
|
|
[% IF ( not_same_branch ) %]<div class="dialog alert"><strong>Cannot delete</strong>: The items do not belong to your library.</div>[% END %]
|
|
[% IF ( linked_analytics ) %]<div class="dialog alert"><strong>Cannot delete</strong>: item has linked <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]&analyze=1">analytics.</a>.</div>[% END %]
|
|
|
|
<div id="cataloguing_additem_itemlist">
|
|
[% IF ( item_loop ) %]
|
|
<div>
|
|
<table id="itemst">
|
|
<thead>
|
|
<tr>
|
|
<th> </th>
|
|
[% FOREACH item_header_loo IN item_header_loop %]
|
|
<th>
|
|
[% item_header_loo.header_value %]
|
|
</th>
|
|
[% END %]
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
[% FOREACH item_loo IN item_loop %]
|
|
[% IF ( item_loo.itemnumber == itemnumber) %]
|
|
[% IF item_loo.nomod %]
|
|
<tr id="row[% item_loo.itemnumber %]" class="active highlight">
|
|
[% ELSE %]
|
|
<tr id="row[% item_loo.itemnumber %]" class="active editable highlight">
|
|
[% END %]
|
|
[% ELSE %]
|
|
[% IF item_loo.nomod %]
|
|
<tr id="row[% item_loo.itemnumber %]">
|
|
[% ELSE %]
|
|
<tr id="row[% item_loo.itemnumber %]" class="editable">
|
|
[% END %]
|
|
[% END %]
|
|
[% IF ( item_loo.nomod ) %]
|
|
<td> </td>
|
|
[% ELSE %]
|
|
<td>
|
|
[% IF ( item_loo.hostitemflag ) %]
|
|
<a href="additem.pl?op=edititem&biblionumber=[% item_loo.hostbiblionumber %]&itemnumber=[% item_loo.itemnumber %]#edititem">Edit in host</a> <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=[% biblionumber %]&hostitemnumber=[% item_loo.itemnumber %]&searchid=[% searchid %]">Delink</a>
|
|
[% ELSE %]
|
|
<a href="additem.pl?op=edititem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]&searchid=[% searchid %]#edititem">Edit</a>
|
|
[% IF ( item_loo.countanalytics ) %]
|
|
<a href="/cgi-bin/koha/catalogue/search.pl?idx=hi&q=% item_loo.itemnumber %]">View analytics</a>
|
|
[% ELSE %]
|
|
<a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]&searchid=[% searchid %]" onclick="return confirm_deletion();">Delete</a>
|
|
[% END %]
|
|
[% END %]
|
|
</td>
|
|
[% END %]
|
|
[% FOREACH item_valu IN item_loo.item_value %]
|
|
<td>[% item_valu.field |html %]</td>
|
|
[% END %]
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
[% END %]
|
|
</div>
|
|
<div class="yui-gf">
|
|
<div class="yui-u first">
|
|
[% INCLUDE 'biblio-view-menu.inc' %]
|
|
</div>
|
|
<div class="yui-u">
|
|
<div id="cataloguing_additem_newitem">
|
|
<form id="f" method="post" action="/cgi-bin/koha/cataloguing/additem.pl" name="f">
|
|
<input type="hidden" name="op" value="[% op %]" />
|
|
[% IF (popup) %]
|
|
<input type="hidden" name="popup" value="1" />
|
|
[% END %]
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
|
|
[% IF ( opisadd ) %]
|
|
<h2 id="additema">Add item [% IF (circborrowernumber) %]<em>(fast cataloging)</em>[% END %]</h2>
|
|
[% ELSE %]
|
|
<h2 id="edititem">Edit Item #[% itemnumber %][% IF ( barcode ) %] / Barcode [% barcode %][% END %]</h2>
|
|
[% END %]
|
|
<fieldset class="rows">
|
|
<ol>
|
|
[% FOREACH ite IN item %]
|
|
<li><div class="subfield_line" style="[% ite.visibility %]" id="subfield[% ite.tag %][% ite.subfield %][% ite.random %]">
|
|
[% IF ( ite.mandatory ) %]
|
|
<label class="required">[% ite.subfield %] - [% ite.marc_lib %]</label>
|
|
[% ELSE %]
|
|
<label>[% ite.subfield %] - [% ite.marc_lib %]</label>
|
|
[% END %]
|
|
|
|
[% SET mv = ite.marc_value %]
|
|
[% IF ( mv.type == 'hidden' ) %]
|
|
<input type="hidden" id="[%- mv.id -%]" name="field_value" class="input_marceditor" size="50" maxlength="[%- mv.maxlength -%]" value="[%- mv.value -%]">
|
|
[% ELSIF ( mv.type == 'select' ) %]
|
|
[% IF ( mv.readonlyselect ) %]
|
|
<select name="field_value" id="[%- mv.id -%]" size="1" class="input_marceditor" readonly="readonly" disabled="disabled">
|
|
[% ELSE %]
|
|
<select name="field_value" id="[%- mv.id -%]" size="1" class="input_marceditor">
|
|
[% END %]
|
|
[% FOREACH aval IN mv.values %]
|
|
[% IF aval == mv.default %]
|
|
<option value="[%- aval -%]" selected="selected">[%- mv.labels.$aval -%]</option>
|
|
[% ELSE %]
|
|
<option value="[%- aval -%]">[%- mv.labels.$aval -%]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
[% ELSIF ( mv.type == 'text_auth' ) %]
|
|
<input type="text" id="[%- mv.id -%]" name="field_value" class="input_marceditor" size="50" maxlength="[%- mv.maxlength -%]" value="[%- mv.value -%]" />
|
|
[% SET dopop = "Dopop('/cgi-bin/koha/authorities/auth_finder.pl?authtypecode=\"${mv.authtypecode}\"&index=${mv.id}','${mv.id}')" %]
|
|
<a href="#" class="buttonDot" onclick="[%- dopop -%]; return false;" title="Tag editor">...</a>
|
|
[% ELSIF ( mv.type == 'text_plugin' ) %]
|
|
<input type="text" id="[%- mv.id -%]" name="field_value" class="input_marceditor" size="50" maxlength="[%- mv.maxlength -%]" value="[%- mv.value -%]" />
|
|
[% IF ( mv.nopopup ) %]
|
|
<a href="#" id="buttonDot_[%- mv.id -%]" class="[%- mv.class -%]" title="No popup">...</a>
|
|
[% ELSE %]
|
|
<a href="#" id="buttonDot_[%- mv.id -%]" class="[%- mv.class -%]" title="Tag editor">...</a>
|
|
[% END %]
|
|
[%- mv.javascript -%]
|
|
[% ELSIF ( mv.type == 'text' ) %]
|
|
<input type="text" id="[%- mv.id -%]" name="field_value" class="input_marceditor" size="50" maxlength="[%- mv.maxlength -%]" value="[%- mv.value -%]" />
|
|
[% ELSIF ( mv.type == 'textarea' ) %]
|
|
<textarea id="[%- mv.id -%]" name="field_value" class="input_marceditor" rows="5" cols="64" >[% mv.value %]</textarea>
|
|
[% END %]
|
|
|
|
<input type="hidden" name="tag" value="[% ite.tag %]" />
|
|
<input type="hidden" name="subfield" value="[% ite.subfield %]" />
|
|
<input type="hidden" name="mandatory" value="[% ite.mandatory %]" />
|
|
[% IF ( ite.repeatable ) %]
|
|
<a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode); return false;">
|
|
<img src="[% interface %]/[% theme %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />
|
|
</a>
|
|
[% END %]
|
|
[% IF ( ite.mandatory ) %] <span class="required">Required</span>[% END %]
|
|
</div></li>
|
|
[% END %]
|
|
</ol>
|
|
</fieldset>
|
|
<input type="hidden" name="indicator" value=" " />
|
|
<input type="hidden" name="indicator" value=" " />
|
|
<input type="hidden" name="itemnumber" value="[% itemnumber %]" />
|
|
|
|
<fieldset class="action"> [% IF ( opisadd ) %]
|
|
<input type="submit" name="phony_submit" value="phony_submit" id="phony_submit" style="display:none;" onclick="return false;" />
|
|
<!-- Note : We use here a false submit button because we have several submit buttons and we don't want the user to believe he validated the adding of multiple items
|
|
when pressing the enter key, while in fact it is the first submit button that is validated, in our case the "add (single) item" button.
|
|
It is a bit tricky, but necessary in the sake of UI correctness.
|
|
-->
|
|
|
|
<input type="submit" name="add_submit" value="Add item" onclick="return Check(this.form)" />
|
|
<input type="submit" name="add_duplicate_submit" value="Add & duplicate" onclick="return Check(this.form)" />
|
|
<input type="submit" name="add_multiple_copies" value="Add multiple items" onclick="javascript:this.nextSibling.style.visibility='visible';document.f.number_of_copies.focus(); return false;" /><span id="add_multiple_copies_span" style="visibility:hidden">
|
|
<label for="number_of_copies">Number of items to add : </label>
|
|
<input type="text" id="number_of_copies" name="number_of_copies" value="" />
|
|
<input type="submit" id="add_multiple_copies_submit" name="add_multiple_copies_submit" value="Add" onclick="javascript:return Check(this.form) && CheckMultipleAdd(this.form.number_of_copies.value);" />
|
|
</span>
|
|
|
|
[% ELSE %]
|
|
<input type="hidden" name="tag" value="[% itemtagfield %]" />
|
|
<input type="hidden" name="subfield" value="[% itemtagsubfield %]" />
|
|
<input type="hidden" name="field_value" value="[% itemnumber %]" />
|
|
<input type="submit" value="Save changes" onclick="return Check(this.form)" />
|
|
[% END %]</fieldset>
|
|
|
|
[%# Fields for fast cataloging %]
|
|
<input type="hidden" name="circborrowernumber" value="[% circborrowernumber %]" />
|
|
<input type="hidden" name="stickyduedate" value="[% stickyduedate %]" />
|
|
<input type="hidden" name="barcode" value="[% barcode %]" />
|
|
<input type="hidden" name="duedatespec" value="[% duedatespec %]" />
|
|
[%# End fields for fast cataloging %]
|
|
|
|
|
|
</form>
|
|
</div>
|
|
</div><!-- /yui-u -->
|
|
</div><!-- /yui-gf -->
|
|
|
|
</div>
|
|
</div>
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|