Marcel de Rooy
6d85e5c80b
git grep -l "ResultsMaxItems" | xargs sed -i -e "/ResultsMaxItems/ s/ResultsMaxItems/OPACResultsMaxItems/g" And line: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:variable name="OPACResultsMaxItems" select="number(marc:sysprefs/marc:syspref[@name='resultsMaxItems']+0)"/> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
215 lines
10 KiB
Perl
Executable file
215 lines
10 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use MARC::Record;
|
|
use Test::More tests => 4;
|
|
use Test::Warn;
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
|
|
use Koha::Database;
|
|
use Koha::Libraries;
|
|
use Koha::ItemTypes;
|
|
|
|
BEGIN {
|
|
use_ok('C4::XSLT', qw( transformMARCXML4XSLT getAuthorisedValues4MARCSubfields buildKohaItemsNamespace ));
|
|
}
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
subtest 'transformMARCXML4XSLT tests' => sub {
|
|
plan tests => 1;
|
|
my $mock_xslt = Test::MockModule->new("C4::XSLT");
|
|
$mock_xslt->mock( getAuthorisedValues4MARCSubfields => sub { return { 942 => { 'n' => 1 } } } );
|
|
$mock_xslt->mock( GetAuthorisedValueDesc => sub { warn "called"; });
|
|
my $record = MARC::Record->new();
|
|
my $suppress_field = MARC::Field->new( 942, ' ', ' ', n => '1' );
|
|
$record->append_fields($suppress_field);
|
|
warning_is { C4::XSLT::transformMARCXML4XSLT( 3,$record ) } undef, "942n auth value not translated";
|
|
};
|
|
|
|
subtest 'buildKohaItemsNamespace status tests' => sub {
|
|
plan tests => 16;
|
|
|
|
t::lib::Mocks::mock_preference('Reference_NFL_Statuses', '1|2');
|
|
t::lib::Mocks::mock_preference( 'OPACResultsLibrary', 'holdingbranch' );
|
|
t::lib::Mocks::mock_preference( 'OPACResultsMaxItems', '2' );
|
|
|
|
my $itype = $builder->build_object({ class => 'Koha::ItemTypes' });
|
|
my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes' });
|
|
my $holdinglibrary = $builder->build_object({ class => 'Koha::Libraries' });
|
|
my $item = $builder->build_sample_item({ itype => $itype->itemtype });
|
|
$item->holdingbranch( $holdinglibrary->branchcode )->store;
|
|
$item->biblioitem->itemtype($itemtype->itemtype)->store;
|
|
|
|
my $xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<status>available</status>},"Item is available when no other status applied");
|
|
|
|
# notforloan
|
|
{
|
|
t::lib::Mocks::mock_preference('item-level_itypes', 0);
|
|
$item->notforloan(0)->store;
|
|
Koha::ItemTypes->find($item->itype)->notforloan(0)->store;
|
|
Koha::ItemTypes->find($item->biblioitem->itemtype)->notforloan(1)->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<status>reference</status>},"reference if positive itype notforloan value");
|
|
|
|
t::lib::Mocks::mock_preference('item-level_itypes', 1);
|
|
Koha::ItemTypes->find($item->itype)->notforloan(1)->store;
|
|
Koha::ItemTypes->find($item->biblioitem->itemtype)->notforloan(0)->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<status>reference</status>},"reference if positive itemtype notforloan value");
|
|
Koha::ItemTypes->find($item->itype)->notforloan(0)->store;
|
|
|
|
my $substatus = Koha::AuthorisedValues->search({ category => 'NOT_LOAN', authorised_value => -1 })->next->lib;
|
|
$item->notforloan(-1)->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<status>reallynotforloan</status>},"reallynotforloan if negative notforloan value");
|
|
like($xml,qr{<substatus>$substatus</substatus>},"substatus set if negative notforloan value");
|
|
|
|
$item->notforloan(1)->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<status>reference</status>},"reference if positive notforloan value");
|
|
|
|
# But now make status notforloan==1 count under Not available
|
|
t::lib::Mocks::mock_preference('Reference_NFL_Statuses', '2');
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<status>reallynotforloan</status>},"reallynotforloan when we change Reference_NFL_Statuses");
|
|
t::lib::Mocks::mock_preference('Reference_NFL_Statuses', '1|2');
|
|
}
|
|
|
|
$item->onloan('2001-01-01')->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like( $xml, qr/<status>other<\/status>/, "Checked out is part of other statuses" );
|
|
like($xml,qr{<substatus>Checked out</substatus>},"Checked out status takes precedence over Not for loan");
|
|
|
|
$item->withdrawn(1)->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<substatus>Withdrawn</substatus>},"Withdrawn status takes precedence over Checked out");
|
|
|
|
$item->itemlost(1)->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<substatus>Lost</substatus>},"Lost status takes precedence over Withdrawn");
|
|
|
|
$item->damaged(1)->store;
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<substatus>Damaged</substatus>},"Damaged status takes precedence over Lost");
|
|
|
|
$builder->build({ source => "Branchtransfer", value => {
|
|
itemnumber => $item->itemnumber,
|
|
datearrived => undef,
|
|
datecancelled => undef,
|
|
}
|
|
});
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<substatus>In transit</substatus>},"In-transit status takes precedence over Damaged");
|
|
|
|
my $hold = $builder->build_object({ class => 'Koha::Holds', value => {
|
|
biblionumber => $item->biblionumber,
|
|
itemnumber => $item->itemnumber,
|
|
found => 'W',
|
|
priority => 0,
|
|
}
|
|
});
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<substatus>Waiting</substatus>},"Waiting status takes precedence over In transit");
|
|
|
|
$builder->build({ source => "TmpHoldsqueue", value => {
|
|
itemnumber => $item->itemnumber
|
|
}
|
|
});
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $item->biblionumber,[]);
|
|
like($xml,qr{<substatus>Pending hold</substatus>},"Pending status takes precedence over all");
|
|
my $library_name = $holdinglibrary->branchname;
|
|
like($xml,qr{<resultbranch>${library_name}</resultbranch>}, "Found resultbranch / holding branch" );
|
|
};
|
|
|
|
$schema->storage->txn_rollback;
|
|
|
|
subtest 'buildKohaItemsNamespace() including/omitting items tests' => sub {
|
|
|
|
plan tests => 20;
|
|
|
|
$schema->storage->txn_begin;
|
|
|
|
my $biblio = $builder->build_sample_biblio;
|
|
|
|
# Have two known libraries for testing purposes
|
|
my $library_1 = $builder->build_object({ class => 'Koha::Libraries' });
|
|
my $library_2 = $builder->build_object({ class => 'Koha::Libraries' });
|
|
my $library_3 = $builder->build_object({ class => 'Koha::Libraries' });
|
|
|
|
my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, library => $library_1->id });
|
|
my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, library => $library_2->id });
|
|
my $item_3 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, library => $library_3->id });
|
|
|
|
my $items_rs = $biblio->items->search({ "me.itemnumber" => { '!=' => $item_3->itemnumber } });
|
|
|
|
## Test passing items_rs only
|
|
my $xml = C4::XSLT::buildKohaItemsNamespace( $biblio->biblionumber, undef, $items_rs );
|
|
|
|
my $library_1_name = $library_1->branchname;
|
|
my $library_2_name = $library_2->branchname;
|
|
my $library_3_name = $library_3->branchname;
|
|
|
|
like( $xml, qr{<homebranch>$library_1_name</homebranch>}, '$item_1 present in the XML' );
|
|
like( $xml, qr{<homebranch>$library_2_name</homebranch>}, '$item_2 present in the XML' );
|
|
unlike( $xml, qr{<homebranch>$library_3_name</homebranch>}, '$item_3 not present in the XML' );
|
|
## Test passing one item in hidden_items and items_rs
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $biblio->biblionumber, [ $item_1->itemnumber ], $items_rs->reset );
|
|
|
|
unlike( $xml, qr{<homebranch>$library_1_name</homebranch>}, '$item_1 not present in the XML' );
|
|
like( $xml, qr{<homebranch>$library_2_name</homebranch>}, '$item_2 present in the XML' );
|
|
unlike( $xml, qr{<homebranch>$library_3_name</homebranch>}, '$item_3 not present in the XML' );
|
|
|
|
## Test passing both items in hidden_items and items_rs
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $biblio->biblionumber, [ $item_1->itemnumber, $item_2->itemnumber ], $items_rs->reset );
|
|
|
|
unlike( $xml, qr{<homebranch>$library_1_name</homebranch>}, '$item_1 not present in the XML' );
|
|
unlike( $xml, qr{<homebranch>$library_2_name</homebranch>}, '$item_2 not present in the XML' );
|
|
unlike( $xml, qr{<homebranch>$library_3_name</homebranch>}, '$item_3 not present in the XML' );
|
|
is( $xml, '<items xmlns="http://www.koha-community.org/items"></items>', 'Empty XML' );
|
|
|
|
## Test passing both items in hidden_items and no items_rs
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $biblio->biblionumber, [ $item_1->itemnumber, $item_2->itemnumber, $item_3->itemnumber ] );
|
|
|
|
unlike( $xml, qr{<homebranch>$library_1_name</homebranch>}, '$item_1 not present in the XML' );
|
|
unlike( $xml, qr{<homebranch>$library_2_name</homebranch>}, '$item_2 not present in the XML' );
|
|
unlike( $xml, qr{<homebranch>$library_3_name</homebranch>}, '$item_3 not present in the XML' );
|
|
is( $xml, '<items xmlns="http://www.koha-community.org/items"></items>', 'Empty XML' );
|
|
|
|
## Test passing one item in hidden_items and items_rs
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $biblio->biblionumber, [ $item_1->itemnumber ] );
|
|
|
|
unlike( $xml, qr{<homebranch>$library_1_name</homebranch>}, '$item_1 not present in the XML' );
|
|
like( $xml, qr{<homebranch>$library_2_name</homebranch>}, '$item_2 present in the XML' );
|
|
like( $xml, qr{<homebranch>$library_3_name</homebranch>}, '$item_3 present in the XML' );
|
|
|
|
## Test not passing any param
|
|
$xml = C4::XSLT::buildKohaItemsNamespace( $biblio->biblionumber );
|
|
|
|
like( $xml, qr{<homebranch>$library_1_name</homebranch>}, '$item_1 present in the XML' );
|
|
like( $xml, qr{<homebranch>$library_2_name</homebranch>}, '$item_2 present in the XML' );
|
|
like( $xml, qr{<homebranch>$library_3_name</homebranch>}, '$item_3 present in the XML' );
|
|
|
|
$schema->storage->txn_rollback;
|
|
};
|