Koha/svc
Marcel de Rooy 0079ca7c72 Bug 15758: [QA Follow-up] Some corrections related to GetBranchName
[1] Acquisition.pm
The lines filling $row in GetBasketGroupAsCSV may have side-effects when
the library name is not found. This change restores former behavior. Just
theoretically more safe.
Note that it also contained a typo: $row->{deliveryplace} should have been
$row->{$place}.

[2] Auth.pm
checkauth: $branchname = Koha::Libraries->find($branchcode)->branchname;
Should normally be fine, but I rather have an empty string here than
crashing on "Can't call method branchname on undefined value".
Same for sub check_api_auth.
Note that this holds for a larger number of calls, but I am adding a check
here because it is checkauth.
Also removed a duplicate use Koha::Libraries-statement.

[3] Search.pm
Also removed a duplicate use statement for Libraries.

[4] svc/holds
Added an (explicit) use statement for Koha::Libraries.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-09-08 14:36:05 +00:00
..
cataloguing Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
config Bug 16508: Updating a syspref requires parameters_remaining_permissions 2016-06-06 17:33:18 +00:00
hold Bug 14310 [QA Followup] - Use output_with_http_headers, return 403s 2016-01-27 06:20:19 +00:00
members Bug 16476: Do not call CGI->param in list context, some more 2016-05-16 17:11:46 +00:00
records Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
virtualshelves Bug 16476: Do not call CGI->param in list context, some more 2016-05-16 17:11:46 +00:00
authentication Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
barcode Bug 13545 [QA Followup] - Complete POD documentation 2015-02-13 13:48:45 -03:00
bib Bug 11559: Supporting changes for Rancor 2015-10-27 12:16:05 -03:00
bib_profile Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
checkin Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven! 2014-11-25 15:25:14 -03:00
checkouts Bug 16154: Fix some other occurrences 2016-04-26 23:16:44 +00:00
cover_images Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
holds Bug 15758: [QA Follow-up] Some corrections related to GetBranchName 2016-09-08 14:36:05 +00:00
import_bib Bug 16154: CGI->multi_param - Manual changes 2016-04-26 23:16:43 +00:00
letters Bug 13215: The same letter code can be used for several libraries 2014-11-27 11:42:14 -03:00
localization Bug 15477: (follow-up) Bug 14100: Better errors handling 2016-01-12 16:13:41 +00:00
new_bib Bug 11559: (QA followup) fix several small issues 2015-10-27 12:25:01 -03:00
renew Bug 16154: Fix some other occurrences 2016-04-26 23:16:44 +00:00
report Bug 17189: Replace occurrences of 'use Koha::Cache' 2016-09-08 10:24:47 +00:00