Koha/t/db_dependent/api/v1/acquisitions_baskets.t
Martin Renvoize 743fac1fe0
Bug 29523: Remove the FIXME
This patch works through the unit tests and existing code to allow
removal of the FIXME I introduced earlier in the patchset.

We now require the `user` parameter be passed to `is_accessible` which
in turn makes `user` a required parameter for `to_api` in the
`Koha::Patron` case.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-27 16:40:45 -03:00

72 lines
2.2 KiB
Perl
Executable file

#!/usr/bin/env perl
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 1;
use Test::Mojo;
use t::lib::TestBuilder;
use t::lib::Mocks;
use JSON qw(encode_json);
use Koha::Database;
my $schema = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new();
my $t = Test::Mojo->new('Koha::REST::V1');
t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
subtest 'list_managers() tests' => sub {
plan tests => 3;
$schema->storage->txn_begin;
my $patron_with_permission =
$builder->build_object( { class => 'Koha::Patrons', value => { flags => 2**11 } } )
; ## 11 == acquisition
my $patron_without_permission =
$builder->build_object( { class => 'Koha::Patrons', value => { flags => 0 } } );
my $superlibrarian =
$builder->build_object( { class => 'Koha::Patrons', value => { flags => 1 } } );
my $password = 'thePassword123';
$superlibrarian->set_password( { password => $password, skip_validation => 1 } );
my $userid = $superlibrarian->userid;
$superlibrarian->discard_changes;
my $api_filter = encode_json(
{ 'me.patron_id' =>
[ $patron_with_permission->id, $patron_without_permission->id, $superlibrarian->id ]
}
);
$t->get_ok(
"//$userid:$password@/api/v1/acquisitions/baskets/managers?q=$api_filter"
)->status_is(200)->json_is(
[
$patron_with_permission->to_api(
{ user => $patron_with_permission }
),
$superlibrarian->to_api( { user => $superlibrarian } )
]
);
$schema->storage->txn_rollback;
};