Owen Leonard
a4e804fceb
The routing list tab displays on patron pages even if the RoutingSerials preference is OFF. Display of the tab should be conditional on that pref being turned on. This patch adds a check for the RoutingSerials preference to the menu include files and amends the affected scripts to make the variable available on the pages where those includes are used. To test, view the following pages with RoutingSerials both on and off. The routing list tab should be shown and hidden accordingly: - Circulation - Patron details - Patron fines - Pay fines - Pay amount/selected (click from the Pay fines page) - Create manual invoice - Create manual credit - Patron circulation history - Patron modification log - Patron notices - Patron routing lists - Patron statistics - Patron files - Patron permissions - Set patron password - "Can't delete patron" page (try to delete a patron with checkouts). Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Touches a lot of files, but only a tiny change in each, works well. Could perhaps be set in C4/Auth instead, but that's no reason not to sign off Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
127 lines
4.3 KiB
Perl
Executable file
127 lines
4.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
#script to delete items
|
|
#written 2/5/00
|
|
#by chris@katipo.co.nz
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
|
|
use CGI;
|
|
use C4::Context;
|
|
use C4::Output;
|
|
use C4::Auth;
|
|
use C4::Members;
|
|
use C4::Branch; # GetBranches
|
|
use C4::VirtualShelves (); #no import
|
|
|
|
my $input = new CGI;
|
|
|
|
my ($template, $borrowernumber, $cookie)
|
|
= get_template_and_user({template_name => "members/deletemem.tmpl",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => {borrowers => 1},
|
|
debug => 1,
|
|
});
|
|
|
|
#print $input->header;
|
|
my $member=$input->param('member');
|
|
my $issues = GetPendingIssues($member); # FIXME: wasteful call when really, we only want the count
|
|
my $countissues = scalar(@$issues);
|
|
|
|
my ($bor)=GetMemberDetails($member,'');
|
|
my $flags=$bor->{flags};
|
|
my $userenv = C4::Context->userenv;
|
|
|
|
|
|
|
|
if ($bor->{category_type} eq "S") {
|
|
unless(C4::Auth::haspermission($userenv->{'id'},{'staffaccess'=>1})) {
|
|
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_STAFF");
|
|
exit 1;
|
|
}
|
|
} else {
|
|
unless(C4::Auth::haspermission($userenv->{'id'},{'borrowers'=>1})) {
|
|
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE");
|
|
exit 1;
|
|
}
|
|
}
|
|
|
|
if (C4::Context->preference("IndependantBranches")) {
|
|
my $userenv = C4::Context->userenv;
|
|
if (($userenv->{flags} % 2 != 1) && $bor->{'branchcode'}){
|
|
unless ($userenv->{branch} eq $bor->{'branchcode'}){
|
|
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_OTHERLIBRARY");
|
|
exit;
|
|
}
|
|
}
|
|
}
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $sth=$dbh->prepare("Select * from borrowers where guarantorid=?");
|
|
$sth->execute($member);
|
|
my $data=$sth->fetchrow_hashref;
|
|
if ($countissues > 0 or $flags->{'CHARGES'} or $data->{'borrowernumber'}){
|
|
# print $input->header;
|
|
|
|
my ($picture, $dberror) = GetPatronImage($bor->{'cardnumber'});
|
|
$template->param( picture => 1 ) if $picture;
|
|
|
|
$template->param(borrowernumber => $member,
|
|
surname => $bor->{'surname'},
|
|
title => $bor->{'title'},
|
|
cardnumber => $bor->{'cardnumber'},
|
|
firstname => $bor->{'firstname'},
|
|
categorycode => $bor->{'categorycode'},
|
|
category_type => $bor->{'category_type'},
|
|
categoryname => $bor->{'description'},
|
|
address => $bor->{'address'},
|
|
address2 => $bor->{'address2'},
|
|
city => $bor->{'city'},
|
|
zipcode => $bor->{'zipcode'},
|
|
country => $bor->{'country'},
|
|
phone => $bor->{'phone'},
|
|
email => $bor->{'email'},
|
|
branchcode => $bor->{'branchcode'},
|
|
branchname => GetBranchName($bor->{'branchcode'}),
|
|
activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''),
|
|
RoutingSerials => C4::Context->preference('RoutingSerials'),
|
|
);
|
|
if ($countissues >0) {
|
|
$template->param(ItemsOnIssues => $countissues);
|
|
}
|
|
if ($flags->{'CHARGES'} ne '') {
|
|
$template->param(charges => $flags->{'CHARGES'}->{'amount'});
|
|
}
|
|
if ($data) {
|
|
$template->param(guarantees => 1);
|
|
}
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
|
|
} else {
|
|
MoveMemberToDeleted($member);
|
|
C4::VirtualShelves::HandleDelBorrower($member);
|
|
DelMember($member);
|
|
print $input->redirect("/cgi-bin/koha/members/members-home.pl");
|
|
}
|
|
|
|
|