Fridolin Somers fb083813a8 Bug 23630: Do not remove field 999 in Elasticsearch indexing ... Elasticsearch indexing uses 999$c to store record id by deleting the all field first ! So you can not store anything in field 999, even in UNIMARC and even in authorities records. Looks like it is quick fix code added to start Elasticsearch use. This behavior is disturbing and very strange for UNIMARC flavour. This patch corrects by defining record ids mandatory in Koha::SearchEngine::Elasticsearch::Indexer::update_index(). This ids array is actually always given (except in UT). I think it is useless to allow adding a record without its id. Test plan : 1) Use Elasticsearch as SearchEngine 2) Create a subfield 999$z in default framework 3) Create a record with default framework 4) Enter a random string (never used in catalog) like "tototata" in 999$z 5) In Search engine configuration, define search field "subject" for 999$z 6) Rebuild record : misc/search_tools/rebuild_elasticsearch.pl -b -bn <biblionumber> -v 7) Search for the random string => You get a result 8) Optionnaly look at records in ES : <es server>:9200/<es index name>/data/<biblionumber> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>		2019-10-29 12:13:58 +00:00
..
Acquisition	Bug 21364: (follow-up) Check for standing status and uncertain prices	2019-04-30 12:45:42 +00:00
api/v1	Bug 23858: (follow-up) Return code fix	2019-10-28 12:36:46 +00:00
Auth	Bug 20128: (QA follow-up) Corrections to haspermission	2019-04-17 12:25:26 +00:00
Authority
Biblio	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
Circulation	Bug 23049: Capitalise type passed to add_debit for lost_item	2019-10-24 17:24:33 +01:00
CourseReserves	Bug 22142: Do not revert data if 'unchanged' was set	2019-08-13 11:22:13 +01:00
Creators
cronjobs	Bug 20478: (QA follow-up) Make test more standard	2019-03-22 19:46:31 +00:00
data	Bug 11677: Use zebra not-onloan-count index for availability limit	2019-08-20 15:00:16 +01:00
Exporter	Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema	2019-01-30 11:35:34 +00:00
Holds	Bug 18928: Update new occurrences	2019-07-01 14:57:10 +01:00
Illrequest	Bug 20750: Add unit tests	2019-03-15 19:07:08 +00:00
Items	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
Koha	Bug 23630: Do not remove field 999 in Elasticsearch indexing	2019-10-29 12:13:58 +00:00
Labels	Bug 21798: replace gimme_a_biblio with build_sample_biblio	2019-01-28 18:53:28 +00:00
LDAP
Letters	Bug 23579: (RM follow-up) Fix failing tests	2019-10-25 13:13:26 +01:00
Members
OAI	Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema	2019-01-30 11:35:34 +00:00
Patron	Bug 14570: Make it possible to add multiple guarantors to a record	2019-08-20 16:04:48 +01:00
Record
Reports	Bug 23389: Add 'All' option to report dropdowns	2019-10-07 14:09:10 +01:00
Reserves	Bug 21181: Unit tests	2019-07-05 08:39:09 +01:00
Search
selenium	Bug 23039: (RM follow-up) Fix basic_workflow test	2019-10-07 14:09:10 +01:00
Serials
SIP	Bug 23049: Capitalise type passed to add_debit for account	2019-10-24 17:24:27 +01:00
Template/Plugin	Bug 22688: (follow-up) Unit tests	2019-04-16 13:17:32 +00:00
Utils
www
XSLT_Handler
00-strict.t
01-test_dbic.t
Accounts.t	Bug 23805: Update 'W' to 'WRITEOFF' for consistency	2019-10-24 17:35:20 +01:00
Acquisition.t	Bug 14669: Add search option for managing library to orders search	2019-10-08 14:04:48 +01:00
Amazon.t
ArticleRequests.t
AudioAlerts.t
Auth.t	Bug 22692: (RM follow-up) Adjust test count	2019-05-02 13:40:07 +00:00
Auth_with_cas.t
Auth_with_ldap.t
AuthorisedValues.t	Bug 23272: Adapt controller and tests	2019-09-13 08:04:15 +01:00
AuthoritiesMarc.t
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t	Bug 21937: Add test to show autoBarcode annual increment bug	2019-04-19 14:32:17 +00:00
Biblio.t	Bug 11529: Add templates for biblio title display. Unify display.	2019-08-05 15:03:19 +01:00
Bookseller.t
Breeding.t
Budgets.t	Bug 10577: Improve semantics of GetBudgetPeriod()	2019-03-28 12:46:14 +00:00
Cache.t	Bug 22808: Move Cache.t to db_dependent	2019-05-07 10:50:00 +00:00
Calendar.t
Charset.t	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
check_kohastructure.t
check_sysprefs.t
Circulation.t	Bug 23382: (follow-up) Further improve test coverage	2019-10-26 07:54:11 +01:00
Clubs.t
ColumnsSettings.t
Context.t	Bug 19788: Add a test	2017-12-22 13:15:37 -03:00
Contract.t	Bug 14334: Remove AutoCommit from tests	2018-12-14 13:42:37 +00:00
CourseReserves.t
db_structure.t
DecreaseLoanHighHolds.t	Bug 22493: Clean up DecreaseLoanHighHolds.t	2019-03-15 12:17:59 +00:00
default_search_class.pl
Filter_MARC_ViewPolicy.t	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
Fines.t
FrameworkPlugin.t
Heading.t
Heading_MARC21.t
Hold.t	Bug 21478: (QA follow-up) Make sure tests don't fail randomly	2019-01-28 16:06:26 +00:00
Holds.t	Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules	2019-07-01 14:56:44 +01:00
HoldsQueue.t	Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules	2019-07-01 14:56:44 +01:00
Holidays.t
Illcomments.t
Illrequestattributes.t
Illrequests.t	Bug 22280: Add a unit test	2019-10-01 14:44:50 +01:00
ILSDI_Services.t	Bug 23805: Update accounttype references in tests	2019-10-24 17:35:19 +01:00
Images.t	Bug 21987: (RM follow-up) Add text for simple tests	2019-03-15 12:22:32 +00:00
ImportBatch.t	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
ImportExportFramework.t
Installer.t	Bug 22472: Add tests	2019-04-11 13:34:09 +00:00
Items.t	Bug 14570: (follow-up) Fix tests	2019-08-20 16:05:19 +01:00
Items_DelItemCheck.t	Bug 21206: Replace C4::Items::GetItem	2019-02-26 13:24:07 +00:00
Koha.t	Bug 20144: [sql_modes] Correct quotes.timestamp values in tests	2018-02-13 13:58:54 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t	Bug 18235: (follow-up) fix tests and remove trailing space	2019-03-28 15:57:32 +00:00
Koha_ExternalContent_OverDrive.t
Koha_ExternalContent_RecordedBooks.t
Koha_Misc_Files.t
Languages.t	Bug 18213: Add language facets to Elasticsearch	2019-03-28 15:57:32 +00:00
Letters.t	Bug 8000: (QA follow-up) Two lastminute fixes	2019-04-29 15:08:47 +00:00
LibraryGroups.t
Linker_Default.t	Bug 21450: (QA follow-up) remove a couple of unused variables to make QA script happy	2019-05-30 10:13:38 +00:00
Linker_FirstMatch.t
Log.t	Bug 22917: Fix typo in another test file	2019-05-23 14:47:41 +00:00
MarcModificationTemplates.t
Members.t	Bug 23579: (RM follow-up) Fix failing tests	2019-10-25 13:13:26 +01:00
MungeMarcPrice.t
NewsChannels.t
Overdues.t	Bug 22521: Update fines handling to use accountline.status	2019-04-17 16:49:36 +00:00
Passwordrecovery.t
Patroncards.t	Bug 22878: Add tests	2019-05-15 12:10:52 +00:00
PatronLists.t
Patrons.t	Bug 17168: (QA follow-up) Only remove guarantor relationship if not Child AND not Professional	2019-10-26 07:37:42 +01:00
QueryParser.t
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t	Bug 18930: (RM follow-up) Restore primary key find	2019-07-16 13:53:54 +01:00
Reports.t
Reserves.t	Bug 23049: Update debit_type_code 'Res' to 'RESERVE'	2019-10-24 17:24:18 +01:00
rollingloans.t
RotatingCollections.t
Search.t	Bug 11677: Use zebra not-onloan-count index for availability limit	2019-08-20 15:00:16 +01:00
Serials.t	Bug 23416: Add PreserveSerialNotes system preference	2019-08-12 14:35:18 +01:00
Serials_2.t
Service.t
ShelfBrowser.t
Sitemapper.t
Stats.t	Bug 21683: (follow-up) Remove last occurences of statistics.proccode	2019-03-21 18:19:23 +00:00
StockRotationItems.t
StockRotationRotas.t
StockRotationStages.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t	Bug 23038: Remove unused stderr vars	2019-10-15 14:14:13 +01:00
sysprefs.t
Tags.t	Bug 21846: Simplify ugly double for loops	2019-03-15 12:27:44 +00:00
Templates.t
TestBuilder.t	Bug 23152: Fix more pluralisation (and add tests)	2019-10-24 17:01:45 +01:00
Upload.t
UsageStats.t	Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete	2019-10-08 14:51:12 +01:00
Virtualshelves.t
XISBN.t	Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls	2019-07-15 11:28:08 +01:00
XSLT_Handler.t
zebra_config.pl