Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
275 lines
8 KiB
Perl
Executable file
275 lines
8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2013 Michael Hafen <mdhafen@tech.washk12.org>
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
# Script to switch the MARC21 440$anv and 490$av information
|
|
|
|
BEGIN {
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin ();
|
|
eval { require "$FindBin::Bin/../kohalib.pl" };
|
|
}
|
|
|
|
use Koha::Script;
|
|
use C4::Biblio qw( GetFrameworkCode GetMarcBiblio ModBiblioMarc );
|
|
use C4::Context;
|
|
use Getopt::Long qw( GetOptions );
|
|
|
|
my $commit;
|
|
my $add_links;
|
|
my $update_frameworks;
|
|
my $show_help;
|
|
my $verbose;
|
|
my $result = GetOptions(
|
|
'c' => \$commit,
|
|
'l' => \$add_links,
|
|
'f' => \$update_frameworks,
|
|
'h|help' => \$show_help,
|
|
'v' => \$verbose,
|
|
);
|
|
|
|
# warn and exit if we're running UNIMARC
|
|
if (C4::Context->preference('MARCFLAVOUR') eq 'UNIMARC') {
|
|
print "This script is useless when you're running UNIMARC\n";
|
|
exit 0;
|
|
}
|
|
if ( ! $result || $show_help ) {
|
|
print_usage();
|
|
exit 0;
|
|
}
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my $count_sth = $dbh->prepare(
|
|
q|
|
|
SELECT COUNT(biblionumber)
|
|
FROM biblio_metadata
|
|
WHERE format='marcxml'
|
|
AND `schema`=?
|
|
AND (
|
|
ExtractValue(metadata,'//datafield[@tag="440"]/subfield[@code="a"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="440"]/subfield[@code="v"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="440"]/subfield[@code="n"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="490"]/subfield[@code="a"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="490"]/subfield[@code="v"]')
|
|
)
|
|
|
|
|
);
|
|
|
|
my $bibs_sth = $dbh->prepare(
|
|
q|
|
|
SELECT biblionumber
|
|
FROM biblio_metadata
|
|
WHERE format='marcxml'
|
|
AND `schema`=?
|
|
AND (
|
|
ExtractValue(metadata,'//datafield[@tag="440"]/subfield[@code="a"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="440"]/subfield[@code="v"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="440"]/subfield[@code="n"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="490"]/subfield[@code="a"]')
|
|
OR ExtractValue(metadata,'//datafield[@tag="490"]/subfield[@code="v"]')
|
|
)
|
|
|
|
|
);
|
|
|
|
unless ( $commit ) {
|
|
print_usage();
|
|
}
|
|
|
|
print "Examining MARC records...\n";
|
|
$count_sth->execute( C4::Context->preference('marcflavour') );
|
|
my ( $num_records ) = $count_sth->fetchrow;
|
|
|
|
unless ( $commit ) {
|
|
if ( $num_records ) {
|
|
print "This action would change $num_records MARC records\n";
|
|
}
|
|
else {
|
|
print "There appears to be no series information to change\n";
|
|
}
|
|
print "Please run this again with the '-c' option to change the records\n";
|
|
exit 0;
|
|
}
|
|
|
|
print "Changing $num_records MARC records...\n";
|
|
|
|
# MARC21 specific
|
|
my %fields = (
|
|
'440' => {
|
|
'a' => 'title',
|
|
'n' => 'number',
|
|
'p' => 'part',
|
|
'v' => 'volume',
|
|
'x' => 'issn',
|
|
'6' => 'link',
|
|
'8' => 'ln',
|
|
'w' => 'control',
|
|
'0' => 'auth',
|
|
},
|
|
'490' => {
|
|
'a' => 'title',
|
|
'v' => 'volume',
|
|
'x' => 'issn',
|
|
'6' => 'link',
|
|
'8' => 'ln',
|
|
},
|
|
);
|
|
|
|
$bibs_sth->execute( C4::Context->preference('marcflavour') );
|
|
while ( my ( $biblionumber ) = $bibs_sth->fetchrow ) {
|
|
my $framework = GetFrameworkCode( $biblionumber ) || '';
|
|
my ( @newfields );
|
|
|
|
# Get biblio marc
|
|
my $biblio = GetMarcBiblio({ biblionumber => $biblionumber });
|
|
|
|
foreach my $field ( $biblio->field( '440' ) ) {
|
|
my @newsubfields;
|
|
my @linksubfields;
|
|
my $has_links = '0';
|
|
foreach my $subfield ( sort keys %{ $fields{'440'} } ) {
|
|
my @values = $field->subfield( $subfield );
|
|
|
|
if ( $add_links && @values ) {
|
|
if ( $subfield eq 'w' || $subfield eq '0' ) {
|
|
$has_links = '1';
|
|
}
|
|
foreach my $v ( @values ) {
|
|
push @linksubfields, ( $subfield, $v );
|
|
}
|
|
}
|
|
|
|
if ( $subfield eq 'a' ) {
|
|
my @numbers = $field->subfield( 'n' );
|
|
my @parts = $field->subfield( 'p' );
|
|
my $i = 0;
|
|
while ( $i < @numbers || $i < @parts ) {
|
|
my @strings = grep {$_} ( $values[$i], $numbers[$i], $parts[$i] );
|
|
$values[$i] = join ' ', @strings;
|
|
$i++;
|
|
}
|
|
}
|
|
|
|
if ( $fields{'490'}{$subfield} ) {
|
|
foreach my $v ( @values ) {
|
|
push @newsubfields, ( $subfield, $v );
|
|
}
|
|
}
|
|
}
|
|
|
|
if ( $has_links && @linksubfields ) {
|
|
my $link_field = MARC::Field->new(
|
|
'830',
|
|
$field->indicator(1), $field->indicator(2),
|
|
@linksubfields
|
|
);
|
|
push @newfields, $link_field;
|
|
}
|
|
|
|
if ( @newsubfields ) {
|
|
my $new_field = MARC::Field->new( '490', $has_links, '',
|
|
@newsubfields );
|
|
push @newfields, $new_field;
|
|
}
|
|
|
|
$biblio->delete_fields( $field );
|
|
}
|
|
|
|
foreach my $field ( $biblio->field( '490' ) ) {
|
|
my @newsubfields;
|
|
foreach my $subfield ( sort keys %{ $fields{'490'} } ) {
|
|
my @values = $field->subfield( $subfield );
|
|
|
|
if ( $fields{'440'}{$subfield} ) {
|
|
foreach my $v ( @values ) {
|
|
push @newsubfields, ( $subfield, $v );
|
|
}
|
|
}
|
|
}
|
|
|
|
if ( @newsubfields ) {
|
|
my $new_field = MARC::Field->new( '440', '', '',
|
|
@newsubfields );
|
|
push @newfields, $new_field;
|
|
}
|
|
|
|
$biblio->delete_fields( $field );
|
|
}
|
|
$biblio->insert_fields_ordered( @newfields );
|
|
|
|
if ( $verbose ) {
|
|
print "Changing MARC for biblio number $biblionumber.\n";
|
|
}
|
|
else {
|
|
print ".";
|
|
}
|
|
ModBiblioMarc( $biblio, $biblionumber );
|
|
}
|
|
print "\n";
|
|
|
|
if ( $update_frameworks ) {
|
|
print "Updating Koha to MARC mappings for seriestitle and volume\n";
|
|
|
|
# set new mappings for koha fields
|
|
$dbh->do(
|
|
"UPDATE marc_subfield_structure SET kohafield='biblio.seriestitle'
|
|
WHERE tagfield='490' AND tagsubfield='a'"
|
|
);
|
|
$dbh->do(
|
|
"UPDATE marc_subfield_structure SET kohafield='biblioitems.volume'
|
|
WHERE tagfield='490' AND tagsubfield='v'"
|
|
);
|
|
|
|
# empty old koha fields
|
|
$dbh->do(
|
|
"UPDATE marc_subfield_structure SET kohafield=''
|
|
WHERE kohafield='biblio.seriestitle' AND tagfield='440' AND tagsubfield='a'"
|
|
);
|
|
$dbh->do(
|
|
"UPDATE marc_subfield_structure SET kohafield=''
|
|
WHERE kohafield='biblioitems.volume' AND tagfield='440' AND tagsubfield='v'"
|
|
);
|
|
$dbh->do(
|
|
"UPDATE marc_subfield_structure SET kohafield=''
|
|
WHERE kohafield='biblioitems.number' AND tagfield='440' AND tagsubfield='n'"
|
|
);
|
|
}
|
|
|
|
sub print_usage {
|
|
print <<_USAGE_;
|
|
$0: switch MARC21 440 tag and 490 tag contents
|
|
|
|
Parameters:
|
|
-c Commit the changes to the marc records.
|
|
|
|
-l Add 830 tags with authority information from 440. Otherwise
|
|
this information will be ignored.
|
|
|
|
-f Also update the Koha field to MARC framework mappings for the
|
|
seriestitle and volume Koha fields.
|
|
|
|
-v Show more information as the records are being changed.
|
|
|
|
--help or -h show this message.
|
|
|
|
_USAGE_
|
|
}
|