Jonathan Druart
6eade474ed
The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
93 lines
4.3 KiB
Text
93 lines
4.3 KiB
Text
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Attach an item to [% bibliotitle |html %]</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
<body id="catalog_moveitem" class="catalog">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/cataloguing/addbooks.pl">Cataloging</a> › Attach an item to <i>[% bibliotitle |html %][% IF ( itemsloo.subtitle ) %][% itemsloo.subtitle %][% END %]</i></div>
|
|
<div id="doc" class="yui-t7">
|
|
|
|
[% BLOCK actions %]
|
|
[% IF ( BiblioDefaultViewmarc ) %]
|
|
<form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
|
|
[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]
|
|
<form action="/cgi-bin/koha/catalogue/labeledMARCdetail.pl" method="post">
|
|
[% ELSIF ( BiblioDefaultViewisbd ) %]
|
|
<form action="/cgi-bin/koha/catalogue/ISBDdetail.pl" method="post">
|
|
[% ELSE %]
|
|
<form action="/cgi-bin/koha/catalogue/detail.pl" method="post">
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% BLOCK fail %]
|
|
<button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
|
|
</form>
|
|
<form method="get" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber %]">
|
|
<button type="submit" class="new"><i class="fa fa-fw fa-plus"></i> Try again with a different barcode</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
|
|
</form>
|
|
[% END %]
|
|
|
|
[% IF ( error ) %]
|
|
<div class="dialog alert">
|
|
|
|
[% IF ( errornonewitem ) %]ERROR: Unable to create the new item.<p>
|
|
[% INCLUDE actions %]
|
|
[% INCLUDE fail %]
|
|
</p>
|
|
[% END %]
|
|
|
|
[% IF ( errornoitem ) %]ERROR: Unable to get the item.<p>
|
|
[% INCLUDE actions %]
|
|
[% INCLUDE fail %]
|
|
</p>
|
|
[% END %]
|
|
</div>
|
|
|
|
[% ELSE %]
|
|
[% IF ( success ) %]
|
|
<div class="dialog message">The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %]<i>[% bibliotitle |html %]</i></a>.
|
|
<p>
|
|
[% INCLUDE actions %]
|
|
<button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
|
|
</form>
|
|
<form method="get" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber %]"/>
|
|
<button type="submit" class="new"><i class="fa fa-fw fa-plus"></i> Attach another item</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
|
|
</form>
|
|
</p>
|
|
</div>
|
|
[% ELSE %]
|
|
[% IF ( missingparameter ) %]
|
|
<form method="post" action="/cgi-bin/koha/cataloguing/moveitem.pl">
|
|
[% IF ( missingbiblionumber ) %]
|
|
<fieldset id="biblionumber_fieldset">
|
|
<label for="biblionumber">Select the biblionumber to attach the item to</label>
|
|
<div class="hint">Enter biblionumber:</div>
|
|
<input type="text" name="biblionumber" id="biblionumber" class="focus" size="14" />
|
|
<fieldset class="action"><input type="submit" value="Submit" /></fieldset>
|
|
</fieldset>
|
|
[% ELSE %]
|
|
<input type="hidden" name="biblionumber" id="biblionumber" value="[% biblionumber %]" />
|
|
[% END %]
|
|
|
|
[% IF ( missingbarcode ) %]
|
|
<h3>Attach an item[% IF ( bibliotitle ) %] to <i>[% bibliotitle |html %]</i>[% END %]</h3>
|
|
<fieldset id="barcode_fieldset">
|
|
<label for="barcode">Enter the barcode of the item to attach:</label>
|
|
<p class="hint">The item you select will be moved to the target record.</p>
|
|
<input type="text" name="barcode" id="barcode" class="barcode focus" size="14" />
|
|
<fieldset class="action"><input type="submit" value="Submit" /></fieldset>
|
|
</fieldset>
|
|
[% ELSE %]
|
|
<input type="hidden" name="barcode" id="barcode" value="[% barcode %]" />
|
|
[% END %]
|
|
|
|
</form>
|
|
[% END %]
|
|
[% END %]
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|