Koha-community/Koha: Main Koha release repository - Koha - Koha: The world's first free and open source library system

Main Koha release repository https://koha-community.org

History

Jonathan Druart 2237e0f871 Bug 5404: C4::Koha - remove subfield_is_koha_internal_p The commit `b5ecefd485` Date: Mon Feb 3 18:46:00 2003 +0000 had a funny description: Added function to check if a MARC subfield name is "koha-internal" (instead of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm "Temporarily", since 2003, everything is relative, isn't it? :) The thing is that GetMarcStructure returns hash like field_200 => { subfield_a => { %attributes_of_subfield_a }, %attributes_of_field_200 } The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'. We don't want to loop on these values when looping on subfields. Since there are just { k => v } with v is a scalar (string), it's easier to test if we are processing a subfield testing the reference. At some places, we don't need to test that, we are looping on values from MARC::Field->subfields which are always valid subfields. Test plan: 1/ Edit items using the batch item mod tool 2/ display and edit items via the cataloguing module. You should not see any changes between before and after the patch applied. Tech notes: We need to check what we are processing when we loop on 'subfields' from GetMarcStructure, not from MARC::Field->subfields. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>		8 years ago
..
acquisitions_stats.pl	Bug 15250: Fix Perl error on acqisition stats page	9 years ago
bor_issues_top.pl	Bug 14965: Remove C4::Dates from 'lists' in folder reports	9 years ago
borrowers_out.pl	Bug 14965: Remove C4::Dates from 'lists' in folder reports	9 years ago
borrowers_stats.pl	Bug 15373: More changes of Zip to ZIP on intranet	8 years ago
cat_issues_top.pl	Bug 10154 Add Call number in the filter of most circulated items	8 years ago
catalogue_out.pl	Bug 14100: (follow-up) Language overlay for item types	9 years ago
catalogue_stats.pl	Bug 7683: Relabel "acquired date" and "removed date"	8 years ago
dictionary.pl	Bug 2669: Change checkboxes to radio buttons on dictionary	8 years ago
guided_reports.pl	Bug 5404: C4::Koha - remove subfield_is_koha_internal_p	8 years ago
issues_avg_stats.pl	Bug 14100: (follow-up) Language overlay for item types	9 years ago
issues_by_borrower_category.plugin	Bug 9978: Replace license header with the correct license (GPLv3+)	9 years ago
issues_stats.pl	Bug 14100: (follow-up) Language overlay for item types	9 years ago
itemslost.pl	Bug 14965: Remove C4::Dates from 'lists' in folder reports	9 years ago
itemtypes.plugin	Bug 14100: (follow-up) Language overlay for item types	9 years ago
manager.pl	Bug 9006: Remove AUTOLOAD in C4::Context	9 years ago
reports-home.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	9 years ago
reserves_stats.pl	Bug 14100: (follow-up) Language overlay for item types	9 years ago
serials_stats.pl	Bug 14961: Remove C4::Dates from files reports/*_stats.pl	9 years ago
stats.print.pl	Bug 11944: use CGI( -utf8 ) everywhere	9 years ago
stats.screen.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	9 years ago