Koha/Koha/Script.pm
Jonathan Druart 9d6d641d1f Bug 17600: Standardize our EXPORT_OK
On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.

That way we will need to explicitely define the subroutine we want to
use from a module.

This patch is a squashed version of:
Bug 17600: After export.pl
Bug 17600: After perlimport
Bug 17600: Manual changes
Bug 17600: Other manual changes after second perlimports run
Bug 17600: Fix tests

And a lot of other manual changes.

export.pl is a dirty script that can be found on bug 17600.

"perlimport" is:
git clone https://github.com/oalders/App-perlimports.git
cd App-perlimports/
cpanm --installdeps .
export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib"
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \;

The ideas of this patch are to:
* use EXPORT_OK instead of EXPORT
* perltidy the EXPORT_OK list
* remove '&' before the subroutine names
* remove some uneeded use statements
* explicitely import the subroutines we need within the controllers or
modules

Note that the private subroutines (starting with _) should not be
exported (and not used from outside of the module except from tests).

EXPORT vs EXPORT_OK (from
https://www.thegeekstuff.com/2010/06/perl-exporter-examples/)
"""
Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members.

@EXPORT and @EXPORT_OK are the two main variables used during export operation.

@EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace.

@EXPORT_OK does export of symbols on demand basis.
"""

If this patch caused a conflict with a patch you wrote prior to its
push:
* Make sure you are not reintroducing a "use" statement that has been
removed
* "$subroutine" is not exported by the C4::$MODULE module
means that you need to add the subroutine to the @EXPORT_OK list
* Bareword "$subroutine" not allowed while "strict subs"
means that you didn't imported the subroutine from the module:
  - use $MODULE qw( $subroutine list );
You can also use the fully qualified namespace: C4::$MODULE::$subroutine

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-16 08:58:47 +02:00

173 lines
4.1 KiB
Perl

package Koha::Script;
# Copyright PTFS Europe 2019
# Copyright 2019 Koha Development Team
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
=head1 NAME
Koha::Script - Koha scripts base class
=head1 SYNOPSIS
use Koha::Script
use Koha::Script -cron;
=head1 DESCRIPTION
This class should be used in all scripts. It sets the interface and userenv appropriately.
=cut
use File::Basename qw( fileparse );
use Fcntl qw( LOCK_EX LOCK_NB );
use C4::Context;
use Koha::Exceptions;
use Koha::Exceptions::Exception;
sub import {
my $class = shift;
my @flags = @_;
C4::Context->_new_userenv(1);
if ( ( $flags[0] || '' ) eq '-cron' ) {
# Set userenv
C4::Context->_new_userenv(1);
C4::Context->set_userenv(
undef, undef, undef, 'CRON', 'CRON',
undef, undef, undef, undef, undef
);
# Set interface
C4::Context->interface('cron');
}
else {
# Set userenv
C4::Context->set_userenv(
undef, undef, undef, 'CLI', 'CLI',
undef, undef, undef, undef, undef
);
# Set interface
C4::Context->interface('commandline');
}
}
=head1 API
=head2 Class methods
=head3 new
my $script = Koha::Script->new(
{
script => $0, # mandatory
[ lock_name => 'my_script' ]
}
);
Create a new Koha::Script object. The I<script> parameter is mandatory,
and will usually be passed I<$0> in the caller script. The I<lock_name>
parameter is optional, and is used to generate the lock file if passed.
=cut
sub new {
my ($class, $params) = @_;
my $script = $params->{script};
Koha::Exceptions::MissingParameter->throw(
"The 'script' parameter is mandatory. You should usually pass \$0"
) unless $script;
my $self = { script => $script };
$self->{lock_name} = $params->{lock_name}
if exists $params->{lock_name} and $params->{lock_name};
bless $self, $class;
return $self;
}
=head3 lock_exec
# die if cannot get the lock
try {
$script->lock_exec;
}
catch {
die "$_";
};
# wait for the lock to be released
$script->lock_exec({ wait => 1 });
This method sets an execution lock to prevent concurrent execution of the caller
script. If passed the I<wait> parameter with a true value, it will make the caller
wait until it can be granted the lock (flock's LOCK_NB behaviour). It will
otherwise throw an exception immediately.
=cut
sub lock_exec {
my ($self, $params) = @_;
$self->_initialize_locking
unless $self->{lock_file};
my $lock_params = ($params->{wait}) ? LOCK_EX : LOCK_EX | LOCK_NB;
open my $lock_handle, '>', $self->{lock_file}
or Koha::Exceptions::Exception->throw("Unable to open the lock file ".$self->{lock_file}.": $!");
$self->{lock_handle} = $lock_handle;
flock( $lock_handle, $lock_params )
or Koha::Exceptions::Exception->throw("Unable to acquire the lock ".$self->{lock_file}.": $!");
}
=head2 Internal methods
=head3 _initialize_locking
$self->_initialize_locking
This method initializes the locking configuration.
=cut
sub _initialize_locking {
my ($self) = @_;
my $lock_dir = C4::Context->config('lockdir')
// C4::Context->temporary_directory();
my $lock_name = $self->{lock_name} // fileparse( $self->{script} );
$self->{lock_file} = "$lock_dir/$lock_name";
return $self;
}
=head1 AUTHOR
Martin Renvoize <martin.renvoize@ptfs-europe.com>
=cut
1;