Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
414 lines
16 KiB
Perl
Executable file
414 lines
16 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
# parts copyright 2010 BibLibre
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
|
|
use C4::Auth qw( get_template_and_user );
|
|
use C4::Koha qw(
|
|
getitemtypeimagelocation
|
|
GetNormalizedISBN
|
|
GetNormalizedUPC
|
|
);
|
|
use C4::Circulation qw( CanBookBeRenewed GetRenewCount GetIssuingCharges GetSoonestRenewDate );
|
|
use C4::External::BakerTaylor qw( image_url link_url );
|
|
use C4::Reserves qw( GetReserveStatus );
|
|
use C4::Members;
|
|
use C4::Output qw( output_html_with_http_headers );
|
|
use C4::Biblio qw( GetMarcBiblio );
|
|
use Koha::Account::Lines;
|
|
use Koha::Biblios;
|
|
use Koha::Libraries;
|
|
use Koha::DateUtils qw( output_pref );
|
|
use Koha::Holds;
|
|
use Koha::Database;
|
|
use Koha::ItemTypes;
|
|
use Koha::Patron::Attribute::Types;
|
|
use Koha::Patrons;
|
|
use Koha::Patron::Messages;
|
|
use Koha::Patron::Discharge;
|
|
use Koha::Patrons;
|
|
use Koha::Ratings;
|
|
use Koha::Token;
|
|
|
|
use constant ATTRIBUTE_SHOW_BARCODE => 'SHOW_BCODE';
|
|
|
|
use Scalar::Util qw( looks_like_number );
|
|
use Date::Calc qw( Date_to_Days Today );
|
|
|
|
my $query = CGI->new;
|
|
|
|
# CAS single logout handling
|
|
# Will print header and exit
|
|
C4::Context->preference('casAuthentication') and C4::Auth_with_cas::logout_if_required($query);
|
|
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-user.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
}
|
|
);
|
|
|
|
my %renewed = map { $_ => 1 } split( ':', $query->param('renewed') || '' );
|
|
|
|
my $show_priority;
|
|
for ( C4::Context->preference("OPACShowHoldQueueDetails") ) {
|
|
m/priority/ and $show_priority = 1;
|
|
}
|
|
|
|
my $patronupdate = $query->param('patronupdate');
|
|
my $canrenew = 1;
|
|
|
|
$template->param( shibbolethAuthentication => C4::Context->config('useshibboleth') );
|
|
|
|
# get borrower information ....
|
|
my $patron = Koha::Patrons->find( $borrowernumber );
|
|
|
|
if( $query->param('update_arc') && C4::Context->preference("AllowPatronToControlAutorenewal") ){
|
|
die "Wrong CSRF token"
|
|
unless Koha::Token->new->check_csrf({
|
|
session_id => scalar $query->cookie('CGISESSID'),
|
|
token => scalar $query->param('csrf_token'),
|
|
});
|
|
|
|
my $autorenew_checkouts = $query->param('borrower_autorenew_checkouts');
|
|
$patron->autorenew_checkouts( $autorenew_checkouts )->store() if defined $autorenew_checkouts;
|
|
}
|
|
|
|
my $borr = $patron->unblessed;
|
|
# unblessed is a hash vs. object/undef. Hence the use of curly braces here.
|
|
my $borcat = $borr ? $borr->{categorycode} : q{};
|
|
|
|
my ( $today_year, $today_month, $today_day) = Today();
|
|
my ($warning_year, $warning_month, $warning_day) = split /-/, $borr->{'dateexpiry'};
|
|
|
|
my $debar = Koha::Patrons->find( $borrowernumber )->is_debarred;
|
|
my $userdebarred;
|
|
|
|
if ($debar) {
|
|
$userdebarred = 1;
|
|
$template->param( 'userdebarred' => $userdebarred );
|
|
if ( $debar ne "9999-12-31" ) {
|
|
$borr->{'userdebarreddate'} = $debar;
|
|
}
|
|
# FIXME looks like $available is not needed
|
|
# If a user is discharged they have a validated discharge available
|
|
my $available = Koha::Patron::Discharge::count({
|
|
borrowernumber => $borrowernumber,
|
|
validated => 1,
|
|
});
|
|
$template->param( 'discharge_available' => $available && Koha::Patron::Discharge::is_discharged({borrowernumber => $borrowernumber}) );
|
|
}
|
|
|
|
if ( $userdebarred || $borr->{'gonenoaddress'} || $borr->{'lost'} ) {
|
|
$borr->{'flagged'} = 1;
|
|
$canrenew = 0;
|
|
}
|
|
|
|
my $amountoutstanding = $patron->account->balance;
|
|
my $no_renewal_amt = C4::Context->preference( 'OPACFineNoRenewals' );
|
|
$no_renewal_amt = undef unless looks_like_number( $no_renewal_amt );
|
|
my $amountoutstandingfornewal =
|
|
C4::Context->preference("OPACFineNoRenewalsIncludeCredit")
|
|
? $amountoutstanding
|
|
: $patron->account->outstanding_debits->total_outstanding;
|
|
|
|
if ( C4::Context->preference('OpacRenewalAllowed')
|
|
&& defined($no_renewal_amt)
|
|
&& $amountoutstandingfornewal > $no_renewal_amt )
|
|
{
|
|
$borr->{'flagged'} = 1;
|
|
$canrenew = 0;
|
|
$template->param(
|
|
renewal_blocked_fines => $no_renewal_amt,
|
|
renewal_blocked_fines_amountoutstanding => $amountoutstandingfornewal,
|
|
);
|
|
}
|
|
|
|
my $maxoutstanding = C4::Context->preference('maxoutstanding');
|
|
if ( $amountoutstanding && ( $amountoutstanding > $maxoutstanding ) ){
|
|
$borr->{blockedonfines} = 1;
|
|
}
|
|
|
|
# Warningdate is the date that the warning starts appearing
|
|
if ( $borr->{'dateexpiry'} && C4::Context->preference('NotifyBorrowerDeparture') ) {
|
|
my $days_to_expiry = Date_to_Days( $warning_year, $warning_month, $warning_day ) - Date_to_Days( $today_year, $today_month, $today_day );
|
|
if ( $days_to_expiry < 0 ) {
|
|
#borrower card has expired, warn the borrower
|
|
$borr->{'warnexpired'} = $borr->{'dateexpiry'};
|
|
} elsif ( $days_to_expiry < C4::Context->preference('NotifyBorrowerDeparture') ) {
|
|
# borrower card soon to expire, warn the borrower
|
|
$borr->{'warndeparture'} = $borr->{dateexpiry};
|
|
if (C4::Context->preference('ReturnBeforeExpiry')){
|
|
$borr->{'returnbeforeexpiry'} = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
# pass on any renew errors to the template for displaying
|
|
my $renew_error = $query->param('renew_error');
|
|
|
|
$template->param(
|
|
amountoutstanding => $amountoutstanding,
|
|
borrowernumber => $borrowernumber,
|
|
patron_flagged => $borr->{flagged},
|
|
OPACMySummaryHTML => (C4::Context->preference("OPACMySummaryHTML")) ? 1 : 0,
|
|
surname => $borr->{surname},
|
|
RENEW_ERROR => $renew_error,
|
|
borrower => $borr,
|
|
csrf_token => Koha::Token->new->generate_csrf({
|
|
session_id => scalar $query->cookie('CGISESSID'),
|
|
}),
|
|
);
|
|
|
|
#get issued items ....
|
|
|
|
my $count = 0;
|
|
my $overdues_count = 0;
|
|
my @overdues;
|
|
my @issuedat;
|
|
my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } };
|
|
my $pending_checkouts = $patron->pending_checkouts->search({}, { order_by => [ { -desc => 'date_due' }, { -asc => 'issue_id' } ] });
|
|
my $are_renewable_items = 0;
|
|
if ( $pending_checkouts->count ) { # Useless test
|
|
while ( my $c = $pending_checkouts->next ) {
|
|
my $issue = $c->unblessed_all_relateds;
|
|
# check for reserves
|
|
my $restype = GetReserveStatus( $issue->{'itemnumber'} );
|
|
if ( $restype ) {
|
|
$issue->{'reserved'} = 1;
|
|
}
|
|
|
|
# Must be moved in a module if reused
|
|
my $charges = Koha::Account::Lines->search(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
amountoutstanding => { '>' => 0 },
|
|
debit_type_code => [ 'OVERDUE', 'LOST' ],
|
|
itemnumber => $issue->{itemnumber}
|
|
},
|
|
);
|
|
$issue->{charges} = $charges->total_outstanding;
|
|
|
|
my $rental_fines = Koha::Account::Lines->search(
|
|
{
|
|
borrowernumber => $patron->borrowernumber,
|
|
amountoutstanding => { '>' => 0 },
|
|
debit_type_code => { 'LIKE' => 'RENT_%' },
|
|
itemnumber => $issue->{itemnumber}
|
|
}
|
|
);
|
|
$issue->{rentalfines} = $rental_fines->total_outstanding;
|
|
|
|
# check if item is renewable
|
|
my ($status,$renewerror) = CanBookBeRenewed( $borrowernumber, $issue->{'itemnumber'} );
|
|
(
|
|
$issue->{'renewcount'},
|
|
$issue->{'renewsallowed'},
|
|
$issue->{'renewsleft'},
|
|
$issue->{'unseencount'},
|
|
$issue->{'unseenallowed'},
|
|
$issue->{'unseenleft'}
|
|
) = GetRenewCount($borrowernumber, $issue->{'itemnumber'});
|
|
( $issue->{'renewalfee'}, $issue->{'renewalitemtype'} ) = GetIssuingCharges( $issue->{'itemnumber'}, $borrowernumber );
|
|
$issue->{itemtype_object} = Koha::ItemTypes->find( Koha::Items->find( $issue->{itemnumber} )->effective_itemtype );
|
|
if($status && C4::Context->preference("OpacRenewalAllowed")){
|
|
$are_renewable_items = 1;
|
|
$issue->{'status'} = $status;
|
|
}
|
|
|
|
$issue->{'renewed'} = $renewed{ $issue->{'itemnumber'} };
|
|
|
|
if ($renewerror) {
|
|
$issue->{'too_many'} = 1 if $renewerror eq 'too_many';
|
|
$issue->{'too_unseen'} = 1 if $renewerror eq 'too_unseen';
|
|
$issue->{'on_reserve'} = 1 if $renewerror eq 'on_reserve';
|
|
$issue->{'norenew_overdue'} = 1 if $renewerror eq 'overdue';
|
|
$issue->{'auto_renew'} = 1 if $renewerror eq 'auto_renew';
|
|
$issue->{'auto_too_soon'} = 1 if $renewerror eq 'auto_too_soon';
|
|
$issue->{'auto_too_late'} = 1 if $renewerror eq 'auto_too_late';
|
|
$issue->{'auto_too_much_oweing'} = 1 if $renewerror eq 'auto_too_much_oweing';
|
|
$issue->{'item_denied_renewal'} = 1 if $renewerror eq 'item_denied_renewal';
|
|
|
|
if ( $renewerror eq 'too_soon' ) {
|
|
$issue->{'too_soon'} = 1;
|
|
$issue->{'soonestrenewdate'} = output_pref(
|
|
C4::Circulation::GetSoonestRenewDate(
|
|
$issue->{borrowernumber},
|
|
$issue->{itemnumber}
|
|
)
|
|
);
|
|
}
|
|
}
|
|
|
|
if ( $c->is_overdue ) {
|
|
push @overdues, $issue;
|
|
$overdues_count++;
|
|
$issue->{'overdue'} = 1;
|
|
}
|
|
else {
|
|
$issue->{'issued'} = 1;
|
|
}
|
|
# imageurl:
|
|
my $itemtype = $issue->{'itemtype'};
|
|
if ( $itemtype ) {
|
|
$issue->{'imageurl'} = getitemtypeimagelocation( 'opac', $itemtypes->{$itemtype}->{'imageurl'} );
|
|
$issue->{'description'} = $itemtypes->{$itemtype}->{'description'};
|
|
}
|
|
|
|
if ( C4::Context->preference('OpacStarRatings') eq 'all' ) {
|
|
my $ratings = Koha::Ratings->search({ biblionumber => $issue->{biblionumber} });
|
|
$issue->{ratings} = $ratings;
|
|
$issue->{my_rating} = $borrowernumber ? $ratings->search({ borrowernumber => $borrowernumber })->next : undef;
|
|
}
|
|
|
|
$issue->{biblio_object} = Koha::Biblios->find($issue->{biblionumber});
|
|
push @issuedat, $issue;
|
|
$count++;
|
|
|
|
my $isbn = GetNormalizedISBN($issue->{'isbn'});
|
|
$issue->{normalized_isbn} = $isbn;
|
|
my $marcrecord = GetMarcBiblio({
|
|
biblionumber => $issue->{'biblionumber'},
|
|
embed_items => 1,
|
|
opac => 1,
|
|
borcat => $borcat });
|
|
$issue->{normalized_upc} = GetNormalizedUPC( $marcrecord, C4::Context->preference('marcflavour') );
|
|
|
|
# My Summary HTML
|
|
if (my $my_summary_html = C4::Context->preference('OPACMySummaryHTML')){
|
|
$issue->{author} ? $my_summary_html =~ s/{AUTHOR}/$issue->{author}/g : $my_summary_html =~ s/{AUTHOR}//g;
|
|
$issue->{title} =~ s/\/+$//; # remove trailing slash
|
|
$issue->{title} =~ s/\s+$//; # remove trailing space
|
|
$issue->{title} ? $my_summary_html =~ s/{TITLE}/$issue->{title}/g : $my_summary_html =~ s/{TITLE}//g;
|
|
$issue->{isbn} ? $my_summary_html =~ s/{ISBN}/$isbn/g : $my_summary_html =~ s/{ISBN}//g;
|
|
$issue->{biblionumber} ? $my_summary_html =~ s/{BIBLIONUMBER}/$issue->{biblionumber}/g : $my_summary_html =~ s/{BIBLIONUMBER}//g;
|
|
$issue->{MySummaryHTML} = $my_summary_html;
|
|
}
|
|
}
|
|
}
|
|
my $overduesblockrenewing = C4::Context->preference('OverduesBlockRenewing');
|
|
$canrenew = 0 if ($overduesblockrenewing ne 'allow' and $overdues_count == $count) || !$are_renewable_items;
|
|
|
|
$template->param( ISSUES => \@issuedat );
|
|
$template->param( issues_count => $count );
|
|
$template->param( canrenew => $canrenew );
|
|
$template->param( OVERDUES => \@overdues );
|
|
$template->param( overdues_count => $overdues_count );
|
|
|
|
my $show_barcode = Koha::Patron::Attribute::Types->search( # FIXME we should not need this search
|
|
{ code => ATTRIBUTE_SHOW_BARCODE } )->count;
|
|
if ($show_barcode) {
|
|
my $patron_show_barcode = $patron->get_extended_attribute(ATTRIBUTE_SHOW_BARCODE);
|
|
undef $show_barcode if $patron_show_barcode and not $patron_show_barcode->attribute;
|
|
}
|
|
$template->param( show_barcode => 1 ) if $show_barcode;
|
|
|
|
# now the reserved items....
|
|
my $reserves = Koha::Holds->search( { borrowernumber => $borrowernumber } );
|
|
|
|
$template->param(
|
|
RESERVES => $reserves,
|
|
showpriority => $show_priority,
|
|
);
|
|
|
|
if (C4::Context->preference('BakerTaylorEnabled')) {
|
|
$template->param(
|
|
BakerTaylorEnabled => 1,
|
|
BakerTaylorImageURL => &image_url(),
|
|
BakerTaylorLinkURL => &link_url(),
|
|
BakerTaylorBookstoreURL => C4::Context->preference('BakerTaylorBookstoreURL'),
|
|
);
|
|
}
|
|
|
|
if (C4::Context->preference("OPACAmazonCoverImages") or
|
|
C4::Context->preference("GoogleJackets") or
|
|
C4::Context->preference("BakerTaylorEnabled") or
|
|
C4::Context->preference("SyndeticsCoverImages") or
|
|
( C4::Context->preference('OPACCustomCoverImages') and C4::Context->preference('CustomCoverImagesURL') )
|
|
) {
|
|
$template->param(JacketImages=>1);
|
|
}
|
|
|
|
$template->param(
|
|
OverDriveCirculation => C4::Context->preference('OverDriveCirculation') || 0,
|
|
overdrive_error => scalar $query->param('overdrive_error') || undef,
|
|
overdrive_tab => scalar $query->param('overdrive_tab') || 0,
|
|
RecordedBooksCirculation => C4::Context->preference('RecordedBooksClientSecret') && C4::Context->preference('RecordedBooksLibraryID'),
|
|
);
|
|
|
|
my $patron_messages = Koha::Patron::Messages->search(
|
|
{
|
|
borrowernumber => $borrowernumber,
|
|
message_type => 'B',
|
|
}
|
|
);
|
|
|
|
if ( C4::Context->preference('AllowPatronToSetCheckoutsVisibilityForGuarantor')
|
|
|| C4::Context->preference('AllowStaffToSetCheckoutsVisibilityForGuarantor') )
|
|
{
|
|
my @relatives;
|
|
# Filter out guarantees that don't want guarantor to see checkouts
|
|
foreach my $gr ( $patron->guarantee_relationships() ) {
|
|
my $g = $gr->guarantee;
|
|
push( @relatives, $g ) if $g->privacy_guarantor_checkouts;
|
|
}
|
|
$template->param( relatives => \@relatives );
|
|
}
|
|
|
|
if ( C4::Context->preference('AllowPatronToSetFinesVisibilityForGuarantor')
|
|
|| C4::Context->preference('AllowStaffToSetFinesVisibilityForGuarantor') )
|
|
{
|
|
my @relatives_with_fines;
|
|
# Filter out guarantees that don't want guarantor to see checkouts
|
|
foreach my $gr ( $patron->guarantee_relationships() ) {
|
|
my $g = $gr->guarantee;
|
|
push( @relatives_with_fines, $g ) if $g->privacy_guarantor_fines;
|
|
}
|
|
$template->param( relatives_with_fines => \@relatives_with_fines );
|
|
}
|
|
|
|
|
|
$template->param(
|
|
patron_messages => $patron_messages,
|
|
opacnote => $borr->{opacnote},
|
|
patronupdate => $patronupdate,
|
|
OpacRenewalAllowed => C4::Context->preference("OpacRenewalAllowed"),
|
|
userview => 1,
|
|
SuspendHoldsOpac => C4::Context->preference('SuspendHoldsOpac'),
|
|
AutoResumeSuspendedHolds => C4::Context->preference('AutoResumeSuspendedHolds'),
|
|
OpacHoldNotes => C4::Context->preference('OpacHoldNotes'),
|
|
failed_holds => scalar $query->param('failed_holds'),
|
|
);
|
|
|
|
# if not an empty string this indicates to return
|
|
# back to the opac-results page
|
|
my $search_query = $query->param('has-search-query');
|
|
|
|
if ($search_query) {
|
|
|
|
print $query->redirect(
|
|
-uri => "/cgi-bin/koha/opac-search.pl?$search_query",
|
|
-cookie => $cookie,
|
|
);
|
|
}
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };
|