Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt
Jonathan Druart dcd1f5d48c Bug 13618: Add html filters to all the variables 
Here we go, next step then.
As we did not fix the performance issue when autofiltering
the variables (see bug 20975), the only solution we have is to add the
filters explicitely.

This patch has been autogenerated (using add_html_filters.pl, see next
pathces) and add the html filter to all the variables displayed in the
template.
Exceptions are made (using the new 'raw' TT filter) to the variable we
already listed in the previous versions of this patch.

To test:
- Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated
data which contain <script> tags

- Remove them from borrower_debarments.comments (there are allowed here)
update  borrower_debarments set comment="html tags possible here";

- From the interface hit page and try to catch alert box.
If you find one it means you find a possible XSS.
To know where it comes from:
* note the exact URL where you found it
* note the alert box content
* Dump your DB and search for the string in the dump to identify its
location (for instance table.field)

Next:
* Ideally we would like to use the raw filter when it is not necessary
to HTML escape the variables (in big loop for instance)
* Provide a QA script to catch missing filters (we want html, uri, url
or raw, certainly others that I am forgetting now)
* Replace the html filters with uri when needed (!)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-17 15:55:05 +00:00

195 lines
9.5 KiB
Text
Raw Blame History

[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Koha &rsaquo; Course reserves &rsaquo; [% IF course_name %] Edit [% course_name | html %] [% ELSE %] New course [% END %]</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
<body id="courses_course" class="course">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a> &rsaquo; [% IF course_name %] Edit <i>[% course_name | html %]</i> [% ELSE %] New course [% END %]</div>
[% IF ( departments ) %]
<div class="main container-fluid">
<div class="row">
<div class="col-md-8 col-md-offset-2">
<form method="post" action="/cgi-bin/koha/course_reserves/mod_course.pl" class="validated">
[% IF course_id %]<input type="hidden" name="course_id" value="[% course_id | html %]" />[% END %]
<fieldset class="rows">
<legend>[% IF course_id %]Edit course[% ELSE %]Create course[% END %]</legend>
<ol>
<li>
<label class="required" for="department">Department:</label>
<select id="department" name="department" required="required" class="required">
<option value="">Select a department</option>
[% FOREACH d IN departments %]
[% IF d.authorised_value == department %]
<option value="[% d.authorised_value | html %]" selected="selected">[% d.lib | html %]</option>
[% ELSE %]
<option value="[% d.authorised_value | html %]">[% d.lib | html %]</option>
[% END %]
[% END %]
</select>
<span class="required">Required</span>
</li>
<li>
<label class="required" for="course_number">Course number:</label>
<input id="course_number" name="course_number" type="text" value="[% course_number | html %]" required="required" class="required" />
<span class="required">Required</span>
</li>
<li>
<label for="section">Section:</label>
<input id="section" name="section" type="text" value="[% section | html %]"/>
</li>
<li>
<label class="required" for="course_name">Course name:</label>
<input id="course_name" name="course_name" type="text" value="[% course_name | html %]" required="required" class="required" />
<span class="required">Required</span>
</li>
<li>
[% IF terms %]
<label for="term">Term:</label>
<select id="term" name="term">
<option value=""></option>
[% FOREACH t IN terms %]
[% IF t.authorised_value == term %]
<option value="[% t.authorised_value | html %]" selected="selected">[% t.lib | html %]</option>
[% ELSE %]
<option value="[% t.authorised_value | html %]">[% t.lib | html %]</option>
[% END %]
[% END %]
</select>
[% ELSE %]
<span class="label">Term: </span>
<span id="term">No TERM authorised values found! Please create one or more authorised values with the category TERM.</span>
[% END %]
</li>
<li>
<span class="label">Instructors:</span>
<fieldset id="course_instructors">
<div id="instructors">[% FOREACH i IN instructors %]<div id="borrower_[% i.cardnumber | html %]">[% i.surname | html %], [% i.firstname | html %] ( <a href="#" class="removeInstructor"> Remove </a> )
<input type='hidden' name='instructors' value='[% i.cardnumber | html %]' /></div>[% END %]</div>
</fieldset>
<fieldset>
<label for="find_instructor">Instructor search:</label>
<input autocomplete="off" id="find_instructor" type="text" style="width:150px" class="noEnterSubmit"/>
<div id="find_instructor_container"></div>
</fieldset>
<li>
<label for="staff_note">Staff note:</label>
<textarea name="staff_note" id="staff_note">[% staff_note | html %]</textarea>
</li>
<li>
<label for="public_note">Public note:</label>
<textarea name="public_note" id="public_note">[% public_note | html %]</textarea>
</li>
<li>
<label for="students_count">Number of students:</label>
<input id="students_count" name="students_count" type="text" value="[% students_count | html %]" />
</li>
<li>
<label for="enabled">Enabled?</label>
[% IF enabled == 'no' %]
<input type="checkbox" name="enabled" id="enabled" />
[% ELSE %]
<input type="checkbox" name="enabled" id="enabled" checked="checked" />
[% END %]
</li>
</ol>
</fieldset>
<fieldset class="action">
<input type="submit" value="Save" class="submit" />
[% IF course_id %]
<a href="/cgi-bin/koha/course_reserves/course-details.pl?course_id=[% course_id | html %]" class="cancel">Cancel</a>
[% ELSE %]
<a href="/cgi-bin/koha/course_reserves/course-reserves.pl" class="cancel">Cancel</a>
[% END %]
</fieldset>
</form>
</div>
</div>
[% ELSE %]
<div class="dialog alert">
<p>
No DEPARTMENT authorized values found!
[% IF ( CAN_user_parameters ) %]
Please <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=DEPARTMENT">create one or more authorized values</a> with the category DEPARTMENT.
[% ELSE %]
An administrator must create one or more authorized values with the category DEPARTMENT.
[% END %]
</p>
</div>
[% END %]
[% IF ( departments ) %]
[% MACRO jsinclude BLOCK %]
<script type="text/javascript">
$(document).ready(function(){
$( "#find_instructor" ).autocomplete({
source: "/cgi-bin/koha/circ/ysearch.pl",
minLength: 3,
select: function( event, ui ) {
AddInstructor( ui.item.surname + ", " + ui.item.firstname, ui.item.cardnumber );
return false;
}
})
.data( "ui-autocomplete" )._renderItem = function( ul, item ) {
return $( "<li></li>" )
.data( "ui-autocomplete-item", item )
.append( "<a>" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") <small>" + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "</small></a>" )
.appendTo( ul );
};
if ( ! $('#instructors').html() ) {
$('#course_instructors').hide();
}
$("body").on("click",".removeInstructor",function(e){
e.preventDefault();
var divid = $(this).parent().attr("id");
var cardnumber = divid.replace("borrower_","");
RemoveInstructor(cardnumber);
});
});
function AddInstructor( name, cardnumber ) {
div = "<div id='borrower_" + cardnumber + "'>" + name + " ( <a href='#' class='removeInstructor'> " + _("Remove")+ " </a> ) <input type='hidden' name='instructors' value='" + cardnumber + "' /></div>";
$('#instructors').append( div );
$('#find_instructor').val('').focus();
$('#course_instructors').show();
}
function RemoveInstructor( cardnumber ) {
$( '#borrower_' + cardnumber ).remove();
if ( ! $('#instructors').html() ) {
$('#course_instructors').hide( 800 );
}
}
</script>
[% END %]
[% END %]
[% INCLUDE 'intranet-bottom.inc' %]
View git blame Copy permalink