dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
178 lines
8 KiB
Text
178 lines
8 KiB
Text
[% USE raw %]
|
|
[% USE Asset %]
|
|
[% USE Koha %]
|
|
[% USE Branches %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Tools › Overdue notice/status triggers</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="tools_overduerules" class="tools">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> › Overdue notice/status triggers</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
<h1>Defining [% IF ( branch ) %]overdue actions for [% Branches.GetName( branch ) | html %][% ELSE %]default overdue actions[% END %]</h1>
|
|
<div class="help">
|
|
<p>Delay is the number of days after a checkout is due before an action is triggered. </p>
|
|
<p>If you want Koha to trigger an action (send a letter or restrict a member), a delay value is required.</p>
|
|
<p>Columns must be filled left to right: if the first column is blank, other columns will be ignored. </p>
|
|
</div>
|
|
<form method="post" action="/cgi-bin/koha/tools/overduerules.pl" id="selectlibrary">
|
|
<label for="branch">Select a library:</label>
|
|
<select id="branch" name="branch">
|
|
<option value="">Default</option>
|
|
[% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %]
|
|
</select>
|
|
<input type="submit" value="Select" />
|
|
</form>
|
|
[% IF ( ERROR ) %]
|
|
<div class="dialog alert">
|
|
<h3>Data error</h3>
|
|
<p>The following errors were found. Please correct them and submit again:</p>
|
|
<ul>
|
|
[% IF ( ERRORDELAY ) %]
|
|
<li>Delay [% ERRORDELAY | html %] for [% BORERR | html %] patron category has some unexpected characters. There should be only numerical characters. </li>
|
|
[% END %]
|
|
[% IF ( ERRORUSELESSDELAY ) %]
|
|
<li>No letter or restriction action specified for delay [% ERRORUSELESSDELAY | html %] for [% BORERR | html %] patron category. If a delay is supplied, either a letter, restrict action, or both should be specified.</li>
|
|
[% END %]
|
|
[% IF ( ERRORORDER ) %]
|
|
<li>The first notice's delay should be less than the second, which should be less than the third for the <strong>[% BORERR | html %]</strong> patron category </li>
|
|
[% END %]
|
|
</ul>
|
|
</div>
|
|
[% END %]
|
|
[% IF ( table ) %]
|
|
<form method="post" action="/cgi-bin/koha/tools/overduerules.pl">
|
|
<input type="hidden" name="op" value="save" />
|
|
<input type="hidden" name="branch" value="[% branch | html %]" />
|
|
<h3>Rules for overdue actions: [% IF ( branch ) %][% Branches.GetName( branch ) | html %][% ELSE %] default library [% END %]</h3>
|
|
[% IF ( datasaved ) %]<div class="dialog message">Changes saved.</div> [% END %]
|
|
|
|
<div id="rulestabs" class="toptabs">
|
|
<ul class="ui-tabs-nav">
|
|
[% FOR tab IN tabs %]
|
|
<li><a href="#[% tab.id | html %]" class="tab [% tab.id | html %]" data-number="[% tab.number | html %]"></a></li>
|
|
[% END %]
|
|
</ul>
|
|
[% FOR tab IN tabs %]
|
|
<div id="[% tab.id | html %]">
|
|
<table>
|
|
<thead>
|
|
<tr>
|
|
<th> </th>
|
|
<th scope="col">Delay</th>
|
|
<th scope="col">Letter</th>
|
|
<th scope="col">Restrict</th>
|
|
[% FOREACH mtt IN message_transport_types %]
|
|
<th scpre="col">
|
|
[% SWITCH mtt %]
|
|
[% CASE 'email' %]
|
|
Email
|
|
[% CASE 'print' %]
|
|
Print
|
|
[% CASE 'sms' %]
|
|
SMS
|
|
[% CASE 'feed' %]
|
|
Feed
|
|
[% CASE 'phone' %]
|
|
Phone
|
|
[% CASE %]
|
|
[% mtt | html %]
|
|
[% END %]
|
|
</th>
|
|
[% END %]
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
[% FOREACH value IN tab.values %]
|
|
<tr>
|
|
<th scope="row">[% value.line | html %]</th>
|
|
<td>
|
|
<input type="number" min="1" name="delay[% tab.number | html %]-[% value.overduename | html %]" value="[% value.delay | html %]" />
|
|
</td>
|
|
<td>
|
|
<select name="letter[% tab.number | html %]-[% value.overduename | html %]">
|
|
<option value="">No notice</option>
|
|
[% FOREACH letter IN letters %]
|
|
[% IF letter.code == value.selected_lettercode %]
|
|
<option value="[% letter.code | html %]" selected="selected">[% letter.name | html %]</option>
|
|
[% ELSE %]
|
|
<option value="[% letter.code | html %]">[% letter.name | html %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</td>
|
|
<td>
|
|
[% IF ( value.debarred ) %]
|
|
<input type="checkbox" name="debarred[% tab.number | html %]-[% value.overduename | html %]" checked="checked" value="1" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="debarred[% tab.number | html %]-[% value.overduename | html %]" value="1" />
|
|
[% END %]
|
|
</td>
|
|
[% FOREACH mtt IN value.message_transport_types %]
|
|
<td>
|
|
[% IF mtt.selected %]
|
|
<input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" checked="checked" />
|
|
[% ELSE %]
|
|
[% IF mtt.value == "sms" and not Koha.Preference("SMSSendDriver") %]
|
|
<input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" />
|
|
[% ELSIF mtt.value == "phone" and not Koha.Preference("TalkingTechItivaPhoneNotification") %]
|
|
<input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" />
|
|
[% END %]
|
|
[% END %]
|
|
</td>
|
|
[% END %]
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
[% END %]
|
|
|
|
|
|
</div>
|
|
|
|
<fieldset class="action"><input type="submit" value="Save changes" /></fieldset>
|
|
</form>
|
|
[% ELSE %]
|
|
<div class="warning">You don't have patron categories defined, or the patron categories are not set to receive overdue notices.</div>
|
|
<div class="warning">If this is not what you were expecting, go to <a href="../admin/categories.pl">patron categories</p></div>
|
|
[% END %]
|
|
</div>
|
|
</div>
|
|
<div class="yui-b noprint">
|
|
[% INCLUDE 'tools-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/tools-menu.js") | $raw %]
|
|
<script type="text/javascript">
|
|
var tab_map = { "1" : _("First"), "2" : _("Second"), "3" : _("Third")};
|
|
$(document).ready(function() {
|
|
$('#selectlibrary').find("input:submit").hide();
|
|
$('#branch').change(function() {
|
|
$('#selectlibrary').submit();
|
|
});
|
|
$("li>a.tab").each( function(){
|
|
var id = $(this).attr("data-number");
|
|
$(this).html(tab_map[id]);
|
|
});
|
|
$('#rulestabs').tabs();
|
|
});
|
|
</script>
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|