fea62637df
This patch removes 2 types of warnings when creating Labels a) Using '0' as filling char is not to the like of prStrWidth On C4/Creators/Layout.pm b) A RM followup from Galen on Bug 8375 to C4/Creators/PDF.pm makes impossible to find properly a font :( (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f7ef93e758850e991091e7268b8d1b1453082df4) on C4/Labels/Label.pm To test: Pre patch 1) Go to Tools > Labels 2) Create a new layout, name ABC, type 'Barcode/Biblio' 3) Create a new batch, add 2 items 4) Export as PDF using the new layout 5) Look at logs, you will find something like a) label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /home/bgkriegel/kohaclone/C4/Creators/Layout.pm line 233., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (Only one of this kind) b) Two related lines similar to this examples label-create-pdf.pl: Use of uninitialized value in -e at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 226., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl label-create-pdf.pl: ERROR in koha-conf.xml -- missing <font type="Ft1">/path/to/font.ttf</font> at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 229., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (many many lines x number of items on batch) 6) Apply the patch 7) Export the same PDF, no more warnings 8) Bonus 1: change main font to Courier and Helvetica and check results 9) Bonus 2: check using arabic records Many hours to find :( Easy to fix Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
327 lines
6.4 KiB
Perl
327 lines
6.4 KiB
Perl
package C4::Creators::PDF;
|
|
|
|
# Copyright 2009 Foundations Bible College.
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
use PDF::Reuse;
|
|
use PDF::Reuse::Barcode;
|
|
use File::Temp;
|
|
use List::Util qw/first/;
|
|
|
|
BEGIN {
|
|
use version; our $VERSION = qv('3.07.00.049');
|
|
}
|
|
|
|
sub _InitVars {
|
|
my $self = shift;
|
|
my $param = shift;
|
|
prInitVars($param);
|
|
}
|
|
|
|
sub new {
|
|
my $invocant = shift;
|
|
my $type = ref($invocant) || $invocant;
|
|
my %opts = @_;
|
|
my $self = {};
|
|
_InitVars() if ($opts{InitVars} == 0);
|
|
_InitVars($opts{InitVars}) if ($opts{InitVars} > 0);
|
|
delete($opts{InitVars});
|
|
prDocDir($opts{'DocDir'}) if $opts{'DocDir'};
|
|
delete($opts{'DocDir'});
|
|
|
|
my $fh = File::Temp->new( UNLINK => 0, SUFFIX => '.pdf' );
|
|
$opts{Name} = $self->{filename} = "$fh"; # filename
|
|
close $fh; # we need just filename
|
|
|
|
prFile(\%opts);
|
|
bless ($self, $type);
|
|
return $self;
|
|
}
|
|
|
|
sub End {
|
|
my $self = shift;
|
|
|
|
prEnd();
|
|
|
|
# slurp temporary filename and print it out for plack to pick up
|
|
local $/ = undef;
|
|
open(my $fh, '<', $self->{filename}) || die "$self->{filename}: $!";
|
|
print <$fh>;
|
|
close $fh;
|
|
unlink $self->{filename};
|
|
}
|
|
|
|
sub Add {
|
|
my $self = shift;
|
|
my $string = shift;
|
|
prAdd($string);
|
|
}
|
|
|
|
sub Bookmark {
|
|
my $self = shift;
|
|
my $reference = shift;
|
|
prBookmark($reference);
|
|
}
|
|
|
|
sub Compress {
|
|
my $self = shift;
|
|
my $directive = shift;
|
|
prCompress($directive);
|
|
}
|
|
|
|
sub Doc {
|
|
my $self = shift;
|
|
my %params = @_;
|
|
prDoc(%params);
|
|
}
|
|
|
|
sub DocForm {
|
|
my $self = shift;
|
|
my %params = @_;
|
|
return prDocForm(%params);
|
|
}
|
|
|
|
sub Extract {
|
|
my $self = shift;
|
|
my ($pdfFile, $pageNo, $oldInternalName) = @_;
|
|
return prExtract($pdfFile, $pageNo, $oldInternalName);
|
|
}
|
|
|
|
sub Field {
|
|
my $self = shift;
|
|
my ($fieldName, $value) = @_;
|
|
prField($fieldName, $value);
|
|
}
|
|
|
|
sub Font {
|
|
my $self = shift;
|
|
my $fontName = shift;
|
|
|
|
my $ttf = C4::Context->config('ttf');
|
|
|
|
if ( $ttf ) {
|
|
my $ttf_path = first { $_->{type} eq $fontName } @{ $ttf->{font} };
|
|
if ( -e $ttf_path->{content} ) {
|
|
return prTTFont($ttf_path->{content});
|
|
} else {
|
|
warn "ERROR in koha-conf.xml -- missing <font type=\"$fontName\">/path/to/font.ttf</font>";
|
|
}
|
|
}
|
|
return prFont($fontName);
|
|
}
|
|
|
|
sub FontSize {
|
|
my $self = shift;
|
|
my $size = shift;
|
|
return prFontSize($size);
|
|
}
|
|
|
|
sub Form {
|
|
my $self = shift;
|
|
my %params = @_;
|
|
return prForm(%params);
|
|
}
|
|
|
|
sub GetLogBuffer {
|
|
my $self = shift;
|
|
return prGetLogBuffer();
|
|
}
|
|
|
|
sub GraphState {
|
|
my $self = shift;
|
|
my $string = shift;
|
|
prGraphState($string);
|
|
}
|
|
|
|
sub Image {
|
|
my $self = shift;
|
|
my %params = @_;
|
|
return prImage(%params);
|
|
}
|
|
|
|
sub Init {
|
|
my $self = shift;
|
|
my ($string, $duplicateCode) = @_;
|
|
prInit($string, $duplicateCode);
|
|
}
|
|
|
|
sub AltJpeg {
|
|
my $self = shift;
|
|
my ($imageData, $width, $height, $imageFormat, $altImageData, $altImageWidth, $altImageHeight, $altImageFormat) = @_;
|
|
return prAltJpeg($imageData, $width, $height, $imageFormat, $altImageData, $altImageWidth, $altImageHeight, $altImageFormat);
|
|
}
|
|
|
|
sub Jpeg {
|
|
my $self = shift;
|
|
my ($imageData, $width, $height, $imageFormat) = @_;
|
|
return prJpeg($imageData, $width, $height, $imageFormat);
|
|
}
|
|
|
|
sub Js {
|
|
my $self = shift;
|
|
my $string_or_fileName = shift;
|
|
prJs($string_or_fileName);
|
|
}
|
|
|
|
sub Link {
|
|
my $self = shift;
|
|
my %params = @_;
|
|
prLink(%params);
|
|
}
|
|
|
|
sub Log {
|
|
my $self = shift;
|
|
my $string = shift;
|
|
prLog($string);
|
|
}
|
|
|
|
sub LogDir {
|
|
my $self = shift;
|
|
my $directory = shift;
|
|
prLogDir($directory);
|
|
}
|
|
|
|
sub Mbox {
|
|
my $self = shift;
|
|
my ($lowerLeftX, $lowerLeftY, $upperRightX, $upperRightY) = @_;
|
|
prMbox($lowerLeftX, $lowerLeftY, $upperRightX, $upperRightY);
|
|
}
|
|
|
|
sub Page {
|
|
my $self = shift;
|
|
my $noLog = shift;
|
|
prPage($noLog);
|
|
}
|
|
|
|
sub SinglePage {
|
|
my $self = shift;
|
|
my ($file, $pageNumber) = @_;
|
|
return prSinglePage($file, $pageNumber);
|
|
}
|
|
|
|
sub StrWidth {
|
|
my $self = shift;
|
|
my ($string, $font, $fontSize) = @_;
|
|
|
|
# replace font code with correct internal font
|
|
$font = C4::Creators::PDF->Font($font);
|
|
|
|
return prStrWidth($string, $font, $fontSize);
|
|
}
|
|
|
|
sub Text {
|
|
my $self = shift;
|
|
my ($x, $y, $string, $align, $rotation) = @_;
|
|
return prText($x, $y, $string, $align, $rotation);
|
|
}
|
|
|
|
sub TTFont {
|
|
my $self = shift;
|
|
my $path = shift;
|
|
return prTTFont($path);
|
|
}
|
|
|
|
sub Code128 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::Code128(%opts);
|
|
}
|
|
|
|
sub Code39 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::Code39(%opts);
|
|
}
|
|
|
|
sub COOP2of5 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::COOP2of5(%opts);
|
|
}
|
|
|
|
sub EAN13 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::EAN13(%opts);
|
|
}
|
|
|
|
sub EAN8 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::EAN8(%opts);
|
|
}
|
|
|
|
sub IATA2of5 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::IATA2of5(%opts);
|
|
}
|
|
|
|
sub Industrial2of5 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::Industrial2of5(%opts);
|
|
}
|
|
|
|
sub ITF {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::ITF(%opts);
|
|
}
|
|
|
|
sub Matrix2of5 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::Matrix2of5(%opts);
|
|
}
|
|
|
|
sub NW7 {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::NW7(%opts);
|
|
}
|
|
|
|
sub UPCA {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::UPCA(%opts);
|
|
}
|
|
|
|
sub UPCE {
|
|
my $self = shift;
|
|
my %opts = @_;
|
|
PDF::Reuse::Barcode::UPCE(%opts);
|
|
}
|
|
|
|
1;
|
|
__END__
|
|
|
|
|
|
=head1 NAME
|
|
|
|
C4::Creators::PDF - A class wrapper for PDF::Reuse and PDF::Reuse::Barcode to allow usage as a pseudo-object. For usage see
|
|
PDF::Reuse documentation and C4::Creators::PDF code.
|
|
|
|
=cut
|
|
|
|
=head1 AUTHOR
|
|
|
|
Chris Nighswonger <cnighswonger AT foundations DOT edu>
|
|
|
|
=cut
|