fea7b9b4d4
The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Well, works and does not explode any more No errors To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl on your staff page, an intriguing 'Planning for by Asort1' appears :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
||
---|---|---|
.. | ||
preferences | ||
admin-home.tt | ||
aqbudgetperiods.tt | ||
aqbudgets.tt | ||
aqcontract.tt | ||
aqplan.tt | ||
audio_alerts.tt | ||
auth_subfields_structure.tt | ||
auth_tag_structure.tt | ||
authorised_values.tt | ||
authtypes.tt | ||
biblio_framework.tt | ||
branch_transfer_limits.tt | ||
branches.tt | ||
categorie.tt | ||
checkmarc.tt | ||
cities.tt | ||
classsources.tt | ||
clone-rules.tt | ||
columns_settings.tt | ||
currency.tt | ||
didyoumean.tt | ||
fieldmapping.tt | ||
item_circulation_alerts.tt | ||
items_search_field.tt | ||
items_search_fields.tt | ||
itemtypes.tt | ||
koha2marclinks.tt | ||
localization.tt | ||
marc_subfields_structure.tt | ||
marctagstructure.tt | ||
matching-rules.tt | ||
oai_set_mappings.tt | ||
oai_sets.tt | ||
patron-attr-types.tt | ||
preferences.tt | ||
printers.tt | ||
smart-rules.tt | ||
sru_modmapping.tt | ||
stopwords.tt | ||
systempreferences.tt | ||
transport-cost-matrix.tt | ||
z3950servers.tt |