Koha/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves
Kyle M Hall b8da5462b0 Bug 13817 - Edit links on course items may point to the wrong course!
If items are assigned to multiple courses, the "edit" links for a course
item may pass the wrong course id. This is really a cosmetic issue.

It appears that in Template Toolkit, if you reuse an existing variable
name in a foreach loop, it will not create a new temporary variable but
will instead re-use the existing variable leaving assigned at the end to
the last assignment, just as it would in Perl code.

This is not a problem when all items are assigned to one and only one
course, but can cause issues when we loop through the other courses an
item may be on.

This is solved easily by renaming the variable used in the foreach loop
to another unused name.

Test Plan:
1) Apply this patch
2) Try the edit and delete links for an item on reserve for a course
3) No changes in behavior should be noted

Signed-off-by: Tom Misilo <misilot@fit.edu>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2015-04-22 14:35:30 -03:00
..
add_items-step1.tt Bug 10418 - Correct template markup problems on course reserves add item page 2013-06-14 11:21:45 -07:00
add_items-step2.tt Bug 13818 - Editing and saving a course reserve displays the add item form 2015-03-25 11:25:26 -03:00
course-details.tt Bug 13817 - Edit links on course items may point to the wrong course! 2015-04-22 14:35:30 -03:00
course-reserves.tt Bug 11605: fallback to default DataTables settings where possible 2014-03-10 19:05:51 +00:00
course.tt Bug 11570 - Upgrade jQueryUI to latest version in the staff client 2014-04-07 15:37:27 +00:00
invalid-course.tt