Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Nick Clemens ff08e99965 Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron 
Bug 19014 altered CanBookBeRenewed to return (auto_)too_soon over on_reserve

For cron purposes this is the correct behaviour.

For display purposes we wish to see on_reserve over too_soon

This patchset adds a switch to 'CanBookBeRenewed' to alter the priority of these statuses

To test:
 1 - set NoRenewalBeforePrecision to date only
 2 - set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days
 3 - check item out
 4 - confirm item shows Scheduled For Automatic Renewal in issues table
 5 - place a hold on the item for another patron
 6 - reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold"
 7 - change No Renewal Before value to 7
 8 - reload issues table for patron 1, confirm checkout now shows "on hold"
 9 - Apply patch
10 - restart_all
11 - Reload the issues table - confirm 'on_hold' still shows
12 - Change No Renewal Before to 0
13 - Refresh issues table, still shows 'On hold'
14 - perl misc/cronjobs/automatic_renewals.pl -v
15 - Result shows 'auto_too_soon'
16 - prove -v t/db_dependent/Circulation.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-09-28 11:08:03 +02:00
..
Acquisition Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
api/v1 Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Auth Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Authority Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Biblio Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Circulation Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
CourseReserves Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Creators Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
cronjobs Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
data
Exporter Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Holds Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Illrequest Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Items Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha Bug 25265: (QA follow-up) Add shebang to Indexer.t 2020-09-28 10:10:08 +02:00
Labels Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LDAP Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
Letters Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Members Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
OAI Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Patron Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Record Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Reports Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Reserves Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Search Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
selenium Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Serials Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
SIP Bug 25541: (QA follow-up) Rename no_holds_checkin to holds_block_checkin 2020-09-03 14:18:23 +02:00
Template/Plugin Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Utils Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
www Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
00-strict.t
01-test_dbic.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Accounts.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Acquisition.t Bug 26250: Fix tests when SearchEngine=Elastic 2020-08-31 16:10:26 +02:00
Amazon.t
ArticleRequests.t Bug 26250: Fix tests when SearchEngine=Elastic 2020-08-31 16:10:26 +02:00
AudioAlerts.t
Auth.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Auth_with_cas.t
Auth_with_ldap.t
AuthorisedValues.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
AuthoritiesMarc.t
AuthUtils.t Bug 26384: (QA follow-up) Fix two exceptions 2020-09-11 09:56:56 +02:00
BackgroundJob.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Barcodes.t Bug 26250: Fix tests when SearchEngine=Elastic 2020-08-31 16:10:26 +02:00
Barcodes_ValueBuilder.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Biblio.t Bug 25189: Unit tests 2020-06-24 14:31:37 +02:00
Breeding.t
Budgets.t Bug 26250: Fix tests when SearchEngine=Elastic 2020-08-31 16:10:26 +02:00
Cache.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Calendar.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Charset.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
check_kohastructure.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
check_sysprefs.t
Circulation.t Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron 2020-09-28 11:08:03 +02:00
Clubs.t
Context.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Contract.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
CourseReserves.t
db_structure.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
DecreaseLoanHighHolds.t Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-16 15:32:18 +01:00
Filter_MARC_ViewPolicy.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Fines.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
FrameworkPlugin.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Heading.t
Heading_MARC21.t
Hold.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Holds.t Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold 2020-08-31 16:10:25 +02:00
HoldsQueue.t Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types 2020-09-18 11:49:29 +02:00
Holidays.t Bug 25723: Remove tests for removed method 2020-07-20 17:45:31 +02:00
Illcomments.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Illrequestattributes.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Illrequests.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
ILSDI_Services.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
ImportBatch.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
ImportExportFramework.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Installer.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Items.t Bug 26250: Fix tests when SearchEngine=Elastic 2020-08-31 16:10:26 +02:00
Koha.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha_Authority.t
Koha_Database.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha_Elasticsearch.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha_ExternalContent_OverDrive.t Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Koha_ExternalContent_RecordedBooks.t
Koha_Misc_Files.t
Languages.t
Letters.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
LibraryGroups.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Linker_Default.t
Linker_FirstMatch.t
Log.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
MarcModificationTemplates.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Members.t
MungeMarcPrice.t
NewsChannels.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Overdues.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Passwordrecovery.t
Patroncards.t
PatronLists.t
Patrons.t Bug 25683: Patron with no accountlines should have 0 outstanding (not NULL) 2020-08-06 11:37:06 +02:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
Reports.t
Reserves.t Bug 18958: Make hold_fill_targets specific to reserves 2020-09-18 11:49:29 +02:00
rollingloans.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
RotatingCollections.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Search.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Serials.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Serials_2.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Service.t
ShelfBrowser.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Sitemapper.t
Stats.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
StockRotationItems.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
StockRotationRotas.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
StockRotationStages.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
SuggestionEngine_ExplodedTerms.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Suggestions.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
sysprefs.t
TablesSettings.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Tags.t
Templates.t
TestBuilder.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Upload.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
UsageStats.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Virtualshelves.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
XISBN.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
XSLT.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
zebra_config.pl