Jonathan Druart
d533a92aa8
The C4::Suggestions::SearchSuggestion subroutine is badly written and
can be replaced by calls to Koha::Suggestions->search.
The hard part in this patch is suggestion.pl, the other occurrences have
been replaced easily.
Test plan:
The idea is to test the whole suggestion workflow.
1. Create a suggestion on OPAC
2. Create a suggestion on the staff interface
3. Edit suggestions
4. Filter suggestions (use the different filters and "organize by"
values)
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 23991: Remove SearchSuggestion tests
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 23991: (QA follow-up) Save some DB queries
This patch makes the suggestion-related pages rely on array size instead
of querying the DB each time they need to. In the case of
suggestion/suggestion.pl it goes from 4 COUNT(*) to 1.
To test, with KTD:
1. Run on the host machine:
$ docker exec -ti koha_db_1 bash
$ mysql -ppassword
> SET GLOBAL general_log_file='/var/log/mysql/mycustom.log';
> SET GLOBAL log_output = 'FILE';
> SET GLOBAL general_log = 'ON';
> \q
$ tail -f /var/log/mysql/mycustom.log | grep suggestions
2. Visit the different pages changed on this bug
=> SUCCESS: Some queries
3. Apply this patch
4. Repeat 2
=> SUCCESS: Less queries!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 23991: Fix branchcode and budgetid filtering
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 23991: Fix conflict with bug 28941
Well, this patchset fixed the security bug...
Redoing on top of bug 28941
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 23991: (follow-up) Missing semicolon
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 23991: Fix 'all' libraries
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 23991: (follow-up) Add value to filter_archived
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
|
||
|---|---|---|
| .. | ||
| acqui-home.pl | ||
| addorder.pl | ||
| addorderiso2709.pl | ||
| ajax-getauthvaluedropbox.pl | ||
| basket.pl | ||
| basketgroup.pl | ||
| basketheader.pl | ||
| booksellers.pl | ||
| cancelorder.pl | ||
| check_budget_total.pl | ||
| check_uniqueness.pl | ||
| duplicate_orders.pl | ||
| edi_ean.pl | ||
| edifactmsgs.pl | ||
| edimsg.pl | ||
| finishreceive.pl | ||
| histsearch.pl | ||
| invoice-files.pl | ||
| invoice.pl | ||
| invoices.pl | ||
| lateorders-export.pl | ||
| lateorders.pl | ||
| modordernotes.pl | ||
| neworderempty.pl | ||
| newordersubscription.pl | ||
| newordersuggestion.pl | ||
| ordered.pl | ||
| orderreceive.pl | ||
| parcel.pl | ||
| parcels.pl | ||
| showorder.pl | ||
| spent.pl | ||
| supplier.pl | ||
| transferorder.pl | ||
| uncertainprice.pl | ||
| updatesupplier.pl | ||
| z3950_search.pl | ||