Fridolin Somers fridolin.somers
  • Joined on Nov 29, 2020
Loading Heatmap…

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 3f7d334455 Bug 23406: Don't translate suppressed authorised values We have a test in C4/XSLT/transformMARCXML4HTML which is meant to exclude the 942n, however, it doesn't work because it checks the $subfield parameter against n $subfield is an arrayref with the code and value as members we need to check $subfield->[0] To test: 1 - Apply only unit tests 2 - prove -v t/db_dependent/XSLT.t 3 - It fails 4 - Confirm 952$n in default framework is tied ot authorised value 'YES_NO' or do so 5 - Set OpacSuppression to 'Hide' 6 - Edit a record in the default template, changing 942$n to 'Yes 7 - Confirm the record is suppressed in opac 8 - Note there is no suppression notice in the record in staff client 9 - Apply second patch 10 - Reload and confirm staff side shows suppression notice 11 - Confirm record still suppressed in OPAC 12 - Edit record, set 942$n to 'no' 13 - Confirm there is no suppression notice in staff client 14 - Confirm you can view the record in OPAC 15 - prove -v t/db_dependent/XSLT.t 16 - Tests pass! Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 91fb5d6a1548f7b270163d18b05467c6fd45a7f0) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • a6b2e6e941 Bug 23406: Unit test Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 1489950a593fb9caf5db52017580302bca7daf75) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 0c1af44112 Bug 27562: itiva notices break if record title contains quotes itiva has reported to us that quotes in the title of a record cause the call to not be made to the patron. The fix is to remove quotes from the title, as quotes are not spoken anyway ( That is, "Queens" and "Queen's" are pronounced the same ). Test Plan: 1) Set up itiva to send phone notes 2) Find a record with quotes in the title 3) Trigger an itiva notice ( checkout, checkin, place hold, etc ) using the itiva outbound cronjob 4) View the CSV, note the title has the quotes in it 5) Apply this patch 6) Repeat steps 2-3 7) View the CSV, note the title contains no quotes! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit e7aac53e9a33763724b7f0a0e9ac69518f0a926b) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 4d9f262a32 Bug 13613: Move similar JS code to a function Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit ac1fd207aec54b4a0da1f6aa00a3f4f4d0752f07) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • bc1e2ee956 Bug 13613: (follow-up) Add tooltip when disabled This patch adds a tooltip to the digest checkboxes when disabled. When enabled the tooltip is hidden Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 5d176758fe4139f2c2bb226cdd8e9ed7b305fc4f) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 21 commits »

1 day ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 550f3e2999 Bug 28276: Do not fetch config ($KOHA_CONF) from memcached memcached address and namespace are in $KOHA_CONF, so it is required to read it before being able to access the cache. And after that, configuration is kept in memory forever. Storing this in memcached is useless and even counter-productive, since Koha reads both the file and the cache This patch addresses this issue by removing the cache-related code from C4::Context->new. It means that C4::Context->new will always read the configuration file, so this patch also replaces inappropriate calls to C4::Context->new->config by appropriate calls to C4::Context->config It also fixes a bug where C4::Context->new would ignore the filepath given in parameters if there was something in cache. It also removes a problematic call to Koha::Caches->get_instance. Because this call was outside of any subroutine, it would have happened before the initialization of $C4::Context::context (which happen in C4::Context::import) Test plan: 1. Do not apply the patch yet 2. Add the following line at the beginning of Koha::Config::read_from_file warn "read_from_file($file)"; This will allow you to check how many times the file is read. 3. Flush memcached and restart starman 4. Check the logs, you should see "read_from_file" a bunch of times 5. Apply the patch 6. Re-add the line from step 2 7. Flush memcached and restart starman 8. Check the logs, you should see "read_from_file" only once 9. Make sure the memcached config from $KOHA_CONF (memcached_servers, memcached_namespace) is taken into account by checking the About page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 4b65d099d7ca1d280d355f3f06c963e6e1a010fb) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 95d5e2fa3a Bug 26471: Remove invalid Map URL There is a warning in the console: Error en el mapeo fuente: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data URL del recurso: http://kohadev-intra.mydnsname.org:8081/intranet-tmpl/lib/datatables/datatables.min_20.1200011.js URL del mapa fuente: pdfmake.min.js.map https://developer.mozilla.org/en-US/docs/Tools/Debugger/Source_map_errors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit b66fbf093505b61089e715d52c168c50172434f8) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 25da495b2d Bug 24564: Use the same tab as the other subfields within a field For each subfield added, we check if other subfields exists in the same field. If that's the case we use the same tab as the first subfield found. Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that doesn't exist in your default biblio MARC framework (or delete one). The field should exist and have other subfields with a tab set. 2. Change the tab of all subfields within that field it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl 4. Verify that the subfield has been added and have the same tab as others subfields 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) Signed-off-by: Koha team <koha@univ-lyon.fr> Signed-off-by: sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit c74f6848ed119b2a2fff687f3bddf87d23e20fd7) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 1440eb532d Bug 24564: Do not modify the tab of existing subfield in ifla/update.pl Test plan: 1. Find a biblio subfield in misc/migration_tools/ifla/data/biblio/default.yml that you have in your default biblio MARC framework (or create one). 2. Change the tab of this subfield so that it's different from what's in the .yml file 3. Run misc/migration_tools/ifla/update.pl --force 4. Verify that the tab of this subfield has not been changed. 5. Do the same for authorities (files are in misc/migration_tools/ifla/data/auth/) Signed-off-by: sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 2f522d8ad4d0ce4a05250063bcc1dcba9fabd7ee) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • c5116ab2ff Bug 28298: fix DB update 19.12.00.076 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 1426cfce0e63409f7130fe9e7d510c90c11a356c) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 12 commits »

1 day ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • d384e46018 Bug 27577: Autolink biblio after biblionumber is generated If BiblioAddsAuthorities and AutoCreateAuthorities are enabled, a new record is auto linked when saving and authorities generated with a 670 field that indicates which record generated the new authority. The code to do this is called before the biblionumber is generated, so the variable that adds the biblionumber to the citation is empty This patch moves the linking code to after the biblionumber is generated To recreate: 1 - Enable BiblioAddsAuthorities and AutoCreateAuthorities 2 - Import or create a new record 3 - Ensure the record has controlled fields that do not have authorities before saving, i.e.: Add a 650 with "test_bug_27577_01" 4 - Search for the authority record 5 - Note the 670 field does not contain the biblionumber 6 - Apply patch, restart all the things 7 - Repeat 2-4 8 - Note the 670 now has the biblionumber Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit b3baca4137ae6d4ef88022d3407d90b9677fcacf) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 2209293fa1 Bug 27577: Unit test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 9fab281e54d232cf026c838855869e76a7543718) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • d2eae82201 Bug 28288: Prevent XSISBN.t to fail if service is returning 500 16:00:45 koha_1 | WARNING: URL Request Failed 500 read timeout 16:00:45 koha_1 | WARNING: URL Request Failed 500 read timeout 16:00:45 koha_1 | WARNING: URL Request Failed 500 Can't connect to www.librarything.com:443 16:00:45 koha_1 | # Looks like you planned 6 tests but ran 5. 16:00:45 koha_1 | [13:59:51] t/db_dependent/XISBN.t 16:00:45 koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) 16:00:45 koha_1 | Failed 1/6 subtests 16:00:45 koha_1 | (less 3 skipped subtests: 2 okay) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 640ba470cfe2ac82b4ae96dfe3b4f945252a212f) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • a12f343802 Bug 28270: (bug 24279 follow-up) Fix tooltip for the claim lost status It says "At least one item is available at this library" instead of "Return claims must be processed from the patron details page" (like on cataloguing/additem) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 47ecad6ad74262a6871a4dd4b17ae947b023ef08) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 216638e67e Bug 28170: Fix upload.tt search result buttons for page two onwards From https://datatables.net/faqs/index "When attaching events to cells in a table controlled by DataTables, you need to be careful how it is done. Because DataTables removes nodes from the DOM, events applied with a static event listener might not be able to bind themselves to all nodes in the table." Before this patch, there were three non-functional buttons on upload search result page, "+ Choose", "Download" and "Delete". This patch binds the handlers to a static element so that the three buttons in upload.tt on page two onwards are functional again. To test: 1. This test is for the "Download" and "Delete" buttons 1.1. Before applying patch, go to cgi-bin/koha/tools/upload.pl 1.2. Make sure you have at least 21 files uploaded 1.3. Perform a search via "Search term" form so that at least 21 results are returned (e.g. a dot (.) as the search term should return all files with filetype) 1.4. Press "Download" and "Delete" for the first result row, it should work as expected (no need to actually delete the file - as long as it pops up a confirmation, it works as expected) 1.5. Go to page 2 of results 1.6. Press "Download" and "Delete" for the first result in page 2 1.7. Observe nothing happening 1.8. Apply patch 1.9. Repeat steps 3-6 1.10. Observe buttons working as expected 2. This test is for the "+ Choose" button 2.1. Go to cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=856&frameworkcode=#subufield 2.2. Under "Other options (choose one), for "Plugin", select "upload.pl" 2.3. Find a biblio and click Edit Record 2.4. Go to 856$u and click "Upload" 2.5. Repeat steps 1.1. - 1.10., but this time for the "+ Choose" button Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 1b1dbee18fcd0d55065b0758690c0c58296e6029) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 15 commits »

2 days ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • fc9d7ce7da Revert "Bug 27842: Add tests" This reverts commit fd5090a415e217144ce334d4d611ddb556ddfb8a.
  • 82725f18b1 Revert "Bug 27842: Update serial.biblionumber when a subscription is linked with another record" This reverts commit 9f16f42953b106ed5fc249b2e41365d2bd5732f9.
  • 6ccc9d5849 Revert "Bug 27842: (follow-up) Correct existing serail/subscriptionhistory before deletion" This reverts commit 7fadc22cd0ae1327a33a2467aa9c9e972ef058d0.
  • 1fa3bb0e23 Bug 28249: Prevent Selenium->wait_for_element_visible to fall in an infinite loop Stop if max_retries is reached Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit e751ce8cf2be1648fe424d08d9eefeb75d639967) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 3f0b3340e5 Bug 27811: Hide the Accounting tab if needed Same as the previous patch for the "Accounting" tab of the circulation module. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit df9d0a849d204b2216827262532a8f2957d187e2) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 6 commits »

6 days ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • ebe12231a4 Bug 28202: Pickup libraries must be sorted by name when placing hold When placing hold, the pickup libraries are not sorted by name but by code. You can see in other places : pickup_locations() calls Koha::Libraries->search with { order_by => ['branchname'] } Test plan : 1) Go to staff interface 2) Create a new libary with code 'AAA' and name 'ZZZ'. 2) Select a record 3) Begin placing hold 4) Look at list in "Pickup at:" => Without patch library 'ZZZ' is first => With patch library 'ZZZ' is last Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 4a6dd5f82da1f45456b953421e699abc179a6fb9) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • f478695215 Bug 28202: Unit test Run prove t/db_dependent/Koha/Biblio.t Note that sort must be case insensitive. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 061c4c3f115cd15c669edbbdc6f4d54a9db850a0) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • ebe355759a Bug 28148: Remove 'print' class from 'Print transfer slip' when transfer exists The 'print' class triggers JS to create the transfer and update a form When a transfer exists we have no form and use 'openWin' to trigger the print Also, I remove a stray '1' in the template To test: 1 - Set AutomaticItemReturn to "Don't" 2 - Check in an item from another branch 3 - Confirm the transfer 4 - Check it in again 5 - Click 'Print slip' 6 - Note error in console: Uncaught TypeError: this.form is null 7 - apply patch 8 - Repeat 9 - No error! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 011ee862d375d1aceb694159cebe5b54d6e0f6b5) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • a4adb984b3 Bug 27819: Fix Object POD Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 680a3323fa2588b07fc034c4a9c534b1c6095065) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 92e69e25ee Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl The job reports errors when deleting items. The issue seems to be that Koha::Object->delete claims in the POD to return -1, 0, or 1 as a result, but it in fact returns the Object itself on a successful deletion The errors are reported as: ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78) To recreate: 1 - Find or create a record with some items 2 - Ensure those items can be deleted (not on loan, etc.) 3 - Edit the record leader and set position 5 to 'd' 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 5 - Deletion succeeds, but reports failure on items 6 - Apply patch 7 - Find or create a new record as above, but this time add an additional item and check it out to a patron 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v 9 - Test mode should report 1 item to be deleted, one with error 10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 11 - One item should be deleted, one item not, record not deleted 12 - check the item in 13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm 14 - Successful deletion with no error reported Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 02a404ef42683b3c19bb937cdd3bd7449c5fbd3a) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 13 commits »

1 week ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 9bed1f59bf Bug 28144: Add a regression test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 0140f1e626471c10b487c65e2db91766d31ac225) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • f76e840970 Bug 28144: Check if issue_id defined Historical OVERDUE fines may not have an issue_id - this causes flooding of the logs when calling update fine Trivial change, reading the code should be enough, but test plan below To test: 1 - Create some fines without an issue_id - Either checkout an old version of Koha and add manually or - Checkout some items (backdated) to a patron, run fines.pl then UPDATE accountlines SET issue_id = NULL; 2 - Checkout a backdated item with fines in the circ rule to the same patron 3 - Run fines.pl 4 - Note the errors 5 - Apply patch 6 - Repeat and note no errors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit bf13a36c8a80d2b7b38c897b4ae3bdf2c91fb934) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 5a6afac654 Bug 28221: Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it The message queue processor has a try/catch block, but does not have a 'use Try::Tiny' line. Because of this the following error ocurrs if an instance has any plugins installed that use the before_send_messages hook: Can't locate object method "catch" via package "1" (perhaps you forgot to load "1"?) at /usr/share/koha/bin/cronjobs/process_message_queue.pl line 86. Test Plan: 1) Install a plugin that uses the before_send_messages hook 2) Run the message queue processor 3) Note the error message 4) Apply this patch 5) Run the message queue processor again 6) No error! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 808d9a9f81a65921b70af92dba83d407e8e71caf) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 106e9e10e9 Bug 28178: Display the correct image in the image viewer When there are several images attached to a bibliographic record, one can click an image and see it in the image viewer. But the first image is always displayed. Test plan: 0. Turn on LocalCoverImages and AllowMultipleCovers 1. Attach at least two images to a bibliographic record 2. Go to the detail page, click the "Images" tab and click the second image. => With this patch applied you should see the image you selected Sponsored-by: Gerhard Sondermann Dialog e.K. (presseplus.de, presseshop.at, presseshop.ch) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 3dc9855b461a598487f2e7395a95f092f1f3e1c9) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • e78a027a14 Bug 21818: Replace AutoCommit flag with DBIx transaction in stage-marc-import.pl Like it was done in Bug 18806. Test plan : Use stage-marc-import.pl with and without patch, with a matcher to find duplicates Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit ff849fadbade8b72faec52284b58e6f5dd8a71c9) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 13 commits »

1 week ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • f82407e917 Bug 23195: (follow-up) One text invoice should be open Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 0cabe5e184fb1d02464eda4de859bb6ebf2109d9) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • abbdf03233 Bug 23195: Always count shipping costs as 'spent' As shipping costs are created when an invoice is created, and creation of an invoice implies that items have been received, the shipment costs are always assumed to be 'spent' This logic is true in GetBudgetSpent/GetBudgetOrdered, however, GetBudgetHierarchy treats open invoices shipping costs as 'ordered' and closed invoice shipping costs as 'spent' This leads to inconsistencies in acqui-home vs spent.pl and ordered.pl To test: 1 - Find a vendor 2 - Click 'Receive shipments' 3 - Create a new invoice with a shipping cost on budget A 4 - Repeate and create a new invoice with a shipping cost on budget B 5 - Close the second invoice 6 - View acquisitions ome 7 - Note budget A includes the shipping under ordered 8 - Note budget B includes the shipping under spent 9 - Click the 'ordered' column on budget A - no shipping is listed on ordered page 10 - Click the spent column on budget A - the shipping is listed here 11 - Apply patch 12 - Both budgets list the shipping as 'spent' 13 - Both 'spent' pages include the shipping 14 - Neither 'ordered' page includes shipping Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 83941d2ee18c4c94485b0feea510d5899c1ee050) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 1c4b8ca01c Bug 23195: Unit tests Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 2d505e5ba06ba12194676b5183bed4827d4b9eea) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • eb8636f089 Bug 27120: (follow-up) also send biblionumber Like in after_biblio_action hook Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit c3625010bbf4e1eff428d9d1d7c5db2cd24045aa) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • ab6e421152 Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. This will be very usefull to be able to fetch external datas (wikipedia, youtube, ...) depending on current biblio record. Test plan : 1) Enable Koha plugins 2) Install plugin attached to this bug 3) Go to staff interface on a biblio record details page 4) Check you see tab 1 containing 'Tab for record {title}' 5) Check you see tab 2 containing 'Tab for record {isbn}' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 3e4d37b03158aa24c5bd01a13a7acd53df8e2213) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 5 commits »

2 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • f05e6296bd Bug 27114: (QA follow-up) Add missing POD Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit b385e1f529a26e1c592355b9f7c2cec3259812df) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 20bbaf12a6 Bug 27114: Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' is for a template, it will be better it uses Template Toolkit plugin like intranet_js, ... It will allow using it in other places like MARC details page for example. Test plan uses a plugin from git.biblibre.com because this hook is not yet in KitchenSink. Test plan : 1) Enable Koha plugins 2) Download and install the latest version of this plugin https://git.biblibre.com/biblibre/koha-plugin-intranet-detail-hook 3) Browse to catalogue/detail.pl for a record 4) Note you see two new tabs with content Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit d0fecf3ff77da1344e915fe027a6fb11af475bb5) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 3d2658c12e Bug 28190: Fix columns_settings.yml itemtypes entry The parent_code column is missing on the columns_settings.yml file, so columns are shifted and thus 'Library limitations' is not toggable. To test: 1. Verify you are not offered the chance to hide the column 2. Apply this patch, restart all the things => SUCCESS: You can toggle the column 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 295d865b061e5502d07c1127ec7dcc79255e8361) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • ccfa471dab Bug 14300: Add %P to SIP LogPattern This patch adds `%P` to the SIP log4perl configuration so that PID is recorded against log lines. This allows transactions to be more easily tied together under one SIPServer, thus making it easier to pick out a whole transaction from start to finish. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit e07c9e9f0646352b25d36602e7b6dbb3e839c9c2) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 697d5e4a72 Bug 21883: Show authorized value description for withdrawn in check-in During check-in (circ/returns.pl) the withdrawn information may be displayed in a message : "Item is withdrawn". Like Bug 21877 we should display the withdrawn authorized value description during check-in. This patch adds this display. Text changed in order to look maximum like in checkout : https://git.koha-community.org/Koha-community/Koha/src/commit/a57278f39b8c5b7a82b21671f266dbf32e2d41a0/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt#L368 Uses class 'ci-withdrawn' to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Check-out an item 5) Edit this item with withdrawn=1 6) Check-in this item => You see 'Item has been withdrawn (dropped in trash)' 7) Edit this item with withdrawn=2 8) Check-in this item => You see 'Item has been withdrawn' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 596e59f2a91ac8f2756a7b83083f2bac606cd3bb) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 27 commits »

2 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • d35909e19e Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit e62687a1df5e99b013b760353877a2f2be689871) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 237c1b9eac Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit df71a27a667936ea5e2ef96f0a31b45179ce53c7) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 5f53c14425 Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page This patch adds a label to the sort function on the OPAC results page to provide context to screen readers and improve accessibility. The label is visually hidden and does not change how the page displays. To test: - Search for something on the OPAC - Change how the results are sorted and confirm sort still works - Confirm that there are no visual changes to the page - Inspect the sort function to confirm it now has a label - Ideally confirm the label works with a screenreader Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit d60439b96a708d28bd8612f99c279e69972811b5) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • c3c8274197 Bug 27827: (follow-up) add a hint for clarification When adding a new authority type, there is no indication of how big the authority type code can be (auth_types.authtypecode in the DB has a maximum length of 10 characters). This patch fixes that. To test, apply the patch and notice the hint appearing right above the "Authority type:" text box as you add a new authority type: it should display "10 characters maximum" in grey colour. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit c359c154364b0aa2aff0f368e21bd30e458173a9) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 772c53b31c Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit e20e0006914a118c8c6278be6165ae241a94f0c3) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 22 commits »

2 weeks ago

fridolin.somers pushed tag v20.11.05 to Koha-community/Koha

2 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 1ce9a74c92 Update release notes for 20.11.05 release Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 76cbb3a925 Fix translations for Koha 20.11.05 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 16ff91c5e4 Merge remote-tracking branch 'translate/20.11.05-translate-20210426' into 20.11.x
  • 48518ba9d4 Increment version for 20.11.05 release Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 48411e15ba Translation updates for Koha 20.11.05
  • Compare 5 commits »

2 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • bb3ff613a7 Bug 26679: Use index-term-genre for 655 To test: 1 - have a bib with a 655 that is not linked to an authority 2 - confirm link on OPAC and intranet details uses subject index 3 - apply patch, restart, reload pages 4 - confirm links now use index-term-genre and give correct results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 21ddbae73524d927116d37083a33febc0dfd7818) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 64a48c6332 Bug 18729: Adapt holds.js Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit e56d083461fb5381a21b44c50a06e32a57fee046) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • eaef2ce207 Bug 18729: (follow-up) Adjust API to new spec The previous patch introduces some behavioural changes to the API, as well as the data types that need to be passed; all happens in the tests. This patch adapts the route so it complies with those changes: - JSON object containing pickup_library_id attribute is now passed back and forth. - The controller should take care of checking the pickup location is valid, using the available tools. To test: 1. Apply the patches, up to the tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => ERROR: Tests fail because the controller doesn't implement the desired behavior 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 60a253c983df1cf50193ee60df730e762ce8f504) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • f6755b446b Bug 18729: Add more tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 9294ab967af113e39a575b116f6a1aa680931bfd) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 1786089ab8 Bug 18729: Add PUT /holds/{hold_id}/pickup_location This patch adds a route to overwrite the current pickup location. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit bf2c59a182837ec397c850ac6e22d52c0ec8d045) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 28 commits »

2 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 8ec6d2e433 Bug 25846: (20.11.x) fix cover-slides CSS Part of Bug 25846 (in 21.05.x) that fixes CSS error Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

3 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 74284f4ddb Bug 26312: (follow-up) Fix passing of exception messages 'error' has special meaning in exceptions so naming the fields: type, details Rather than only dealing with a single exception type, we generically get the ES exception info and pass it up. I could not recreate timeout still, however, I simply restarted the ES docker during commit stage to cause NoNodes exceptions Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit cc8787bf879630f1c5572008c3637598f56d7aff) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • d78690a0ab Bug 26312: Catch ES Client errors, log, and continue indexing when error encountered This catches a timeout response from the ES server, logs this, and continues the indexing To test: 1 - perl misc/search_tools/rebuild_elasticsearch.pl 2 - Make the ES server timeout (I don't have good instruction yet) 3 - Watch the job crash 4 - Apply patches 5 - perl misc/search_tools/rebuild_elasticsearch.pl 6 - Make the server timeout 7 - Note the job reports failed commit, and continues Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Bug 26312: (follow-up) Reset buffers even if commit fails Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Bug 26312: (follow-up) Fix whitespace and missing semicolon Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 72e6999db7cbfc077f200930dd28400d1f86831e) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 2c8e612f1e Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 9d7f55a8748c5e148d805195e314f189c886a492) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 4f618fb33a Bug 27746: prevent regexp undefined warning when checking subfield contents ($oclc) Some of the books have subfield "a" of field "035" absent and it's possible to have such (it doesn't says "Require" in the interface), which causes "Use of uninitialized value $oclc in pattern match (m//)" error. Solved by screening regex with check for empty variables before the match. To reproduce: 1) Edit existing book or create a new one with empty marc subfield "a" of field "035" 2) Use the search feature that will find it along with some other books. 3) Check /var/log/koha/kohadev/plack-intranet-error.log to find "Use of uninitialized value $oclc in pattern match (m//)" error. 4) Apply the patch. 5) Repeat the search and check the logs again to ensure that error didn't appear again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit a34e1f9f0d32e4cf0f282016e52166d309b25ef7) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • b69b0ac61d Bug 28132: (follow-up) Update basket group page This patch makes the same change to the basket group page: Reopen this basket -> Reopen basket Export this basket -> Export basket Print this basket -> Print basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit c30c8c7a5367cb68bd1a2db16972f8668a630282) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 13 commits »

3 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • b0a677be7f Bug 28094: Deal with encoding for overriden sysprefs The string we retrieved is UTF-8 encoded, to prevent encoding issue we must decode it first. Test plan: Easily testable with LibraryName: 1. edit /etc/apache2/sites-available/kohadev.conf 2. Add RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Library of ❤️" 3. restart_all 4. Hit the mainpage and look at the source (or title) and confirm that the string is displayed correcty Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit c32d46b854a73e636b1568eab758868ea9d74a13) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • ffd059075f Bug 28097: Mock finesModes to disable recalculation Since bug 8338 the recalcuated zero amount fine is subsequently removed in _FixOverduesOnReturn which causes this test to fail if finesMode is 'production' and 'CalculateFinesOnReturn' is enabled. Perhaps we should be 'VOID'ing fines rather than completely deleting them, but that's a question for another day. Test plan 1/ Enable finesMode in the staff client 2/ Run the test and watch it fail 3/ Apply the patch 4/ Run the test and watch it pass Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit f3e81738c83f6f2bae869f056ba934fc45315c1f) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • e7345defd8 Bug 26970: Add row highlight on drag in Elasticsearch mapping template In Elasticsearch mapping tables : In order to better see which row is currently in drag-an-drop, add an highlight color like in circulation and fine rules when editing a row. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) In each table : biblio, authorities, facets 3) Clik on a row to start a drag => See row turning orange 4) Release to drop => See row turning back to original color https://bugs.koha-community.org/show_bug.cgi?id=26970 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit f470bee2e5467b19dd9cea7ef09466fd578248a8) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 4a1be037f9 Bug 26459: (follow-up) Clarify language and remove duplicated code Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit cc587182632030c25eccbf771c765a8f301f2eb9) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • b4cac071e7 Bug 26459: Add hold-mode option to sip_cli_emulator To test: 1 - Apply patch 2 - Restart all 3 - Place an item level hold for a patron via the staff client 4 - Cancel the hold using the sip_cli_emulator with hold-mode: - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --patron {cardnumber} --item {BARCODE} -m hold -l CPL --hold-mode - 5 - Run the sip_cli_emulator with no params 6 - Verify help text is understandable Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 9ff8bb69e1e91596dec7b21cb75aeaaa04c6b097) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 8 commits »

3 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • b7de6e267a Bug 27748: Encoding problem in link to OverDrive results If you have OverDrive enabled and do a search for e.g. "Göteborg", you will get a link above the regular Koha search results that says e.g. "Found 1 results in the library's OverDrive collection". If you follow this link, a search will be made in OverDrive, but only for "G", because the search term is cut off at the first non-ASCII char. To test: - Make sure OverDrive is enabled - Do a search that contains a non-ASCII char, like "Göteborg" - Click on the link "Found x results in the library's OverDrive collection" - Verify the query string is cut off at the first non-ASCII char, and that the number of hits is different from the number given in the link on the previous page - Apply the patch, restart all the things - Repeat the search, and verify that the numbers match and that the query string is intact after clicking on the OverDrive link Lookin at the code, the same problem seems to be shared between OverDrive and RecordedBooks. I have applied the same fix to both, but I do not have access to RecordedBooks, so I have not been able to verify that the problem exists there and is fixed by my patch. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit b9a3ac31919794e3d892ba3735a7051c411fccb1) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 03e3f03c97 Bug 28077: Add a colon after the 'Reason' label on edit suggestion page This patch corrects the missing colon on the 'Edit purchase suggestion' page. To test : - go to Acquistions > Suggestions - edit a suggestion - on 'Suggestion management' bloc, see the colon missing after the 'Reason' label - apply patch - refresh the page - colon should now be displayed Happy sign off ! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit dad0a18c7a8a95c3bca7bf97d010953c5a41a0f1) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 42ebcdd3df Bug 28044: Increase specificity of calendar tables CSS This patch adds increased specificity to the CSS which should add colors to the tables of holidays. The default DataTable CSS was overriding the custom color-coding. This patch also moves the calendar CSS into a separate file. To test, apply the patch and go to Tools -> Calendar. If necessary, add at least one of the following: - Unique holiday - Holiday repeating weekly - Holiday repeating monthly - Holiday exception In the table listing each kind of holiday, the color of the table header should match the colors in the "Key" section under Hints. The color should be correct regardless of how the table is sorted. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 4df8e3ef02b4490dc813b76b853e3fb706d4a301) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 10bf4cb038 Bug 24000: Some modules do not return 1 This patch adds "1;" to the end of the following perl files: Koha/Filter/MARC/EmbedItemsAvailability.pm Koha/Filter/MARC/EmbedSeeFromHeadings.pm Koha/Filter/MARC/Null.pm Koha/Item/Search/Field.pm Koha/SearchEngine.pm misc/translator/VerboseWarnings.pm t/lib/Koha/Plugin/Test.pm This indicates the succesful execution of the initialization code. Test plan: Ensure that there are no other perl files that need "1;", but dont have it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 2b607d84140e5870a641c845d8bd3f79448bf714) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • b8f6074313 Bug 24000: Koha::Item::Search::Field does not return 1 Test plan: Run t/db_dependent/Koha/Item/Search/Field.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 6016791fc0bc589dfe70db7e2c25cab8410c88ec) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 26 commits »

4 weeks ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 66a698fc72 Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting The HOLD MODIFY log at the end of ModReserveAffect is not using an up-to-date $hold object. $hold is modified at 1201 $hold->set_waiting($desk_id); But not refreshed before logged (and so the timestamp is not logged correctly). Test plan: Turn on HoldsLog Place an item on hold Check it in to mark it waiting Confirm that the timestamp logged is the one from the check in, not when you created the hold Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit cb03909af62585aa7a280cd49b2008b0e7b2cbb8) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 432d7332c4 Bug 28017: (follow-up) Fix Letters.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 789a7a863426c7887055095ca58e09fd46f67972) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 487c7dbf61 Bug 28017: Test IPs are supported Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 6840e8d6fb05dd8c4915f30b925f5a229ded13c3) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • c05b3c6ea2 Bug 28017: Allow non-FQDN (@localhost) addresses This patch makes Koha::Email support using @localhost addresses. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: Koha::Email doesn't support non-fqdn addresses 3. Apply this patch 4. Repeat 2 => SUCCESS: All tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 4413557b0074bc7b7fc6b2614889f23521ecb0ee) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 7e20fc90c6 Bug 28017: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit d949c4fc20882397b24cbb28fd6f20c7ecb102be) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 14 commits »

1 month ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 6eb861dc61 Bug 26942: Allow style and link tags in NewsEditor TinyMCE To Test: -Make sure the sys pref 'NewsToolEditor' is set to TinyMCE -Go to any news item and add this line: <link href="https://fonts.googleapis.com/css?family=Open+Sans" rel="stylesheet"> -Save the news item -Re-open the same news item again in TinyMCE. -The editor has removed that line. Annoying! -Apply patch -Try again, the <link> should stay now Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 27fce8b0c2575021400023d9a7460adef20dadd6) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 8244792f26 Bug 27963: (bug 23463 follow-up) Fix touch_all_items.pl This script is used to fix inconsistencies in the items table. Prior to bug 23463, ModItem dealt with that. We need to make some attributes as dirty to make sure the Koha::Item->store method will fix them. Test plan: Be familiar with how touch_all_items is supposed to work and confirm that the different inconsistencies are fixed. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 8f071b01f5c851a6b066e7084643bd6430e6e8d5) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 296f1e2f64 Bug 28023: Fix Reply-To typo This patch fixes a typo making the header useless. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: The Reply-To header is not being set! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! the header is set! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 9f79cdf9925c86856775a28bede9fec0dabfcd99) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 043f1b532f Bug 28023: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit ad55a2b4d820d914ad398224a62633f6df1e1d8a) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 5c658145d7 Bug 26705: (QA follow-up) Do not rely on latest Email::MIME This patch makes the implementation use lower-level methods to deal with headers. So the Email::MIME library in Debian 9 works. Params are sorted for testing purposes. To test: 1. Apply this patch 2. Run the tests => SUCCESS: Things pass in D9+ 3. Sign off :-D Thanks Kyle! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 539c9e5c9b04ac6e6151de839dd5e08bd603c371) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • Compare 15 commits »

1 month ago

fridolin.somers pushed tag v20.11.04 to Koha-community/Koha

1 month ago

fridolin.somers pushed to 20.11.x at Koha-community/Koha

  • 182564069c Update release notes for 20.11.04 release Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • f881e3048c Fix translations for Koha 20.11.04 Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • 0fc7c940d9 Merge remote-tracking branch 'translate/20.11.04-translate-20210324' into 20.11.x
  • 04fea3e373 Increment version for 20.11.04 release Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
  • fd241b1052 Translation updates for Koha 20.11.04
  • Compare 5 commits »

1 month ago