]> git.koha-community.org Git - koha.git/commit
Bug 14418 : More XSS vulnerabilities in opac-shelves.pl
authorChris Cormack <chrisc@catalyst.net.nz>
Thu, 18 Jun 2015 23:41:45 +0000 (11:41 +1200)
committerLiz Rea <wizzyrea@gmail.com>
Sat, 20 Jun 2015 00:52:17 +0000 (12:52 +1200)
commit5b03b9716b762a1930aa5d298a163fef7fb76992
tree4714812d8e97823cb44f96958ba4120778eb74a4
parent358e8e889d8a02d55210d353cd01bbf35d1ddc15
Bug 14418 : More XSS vulnerabilities in opac-shelves.pl

To test:
1/ Hit a url like
/cgi-bin/koha/opac-shelves.pl?viewshelf=7&op=modif&display="><script>alert('oh
noes')</script>  Where the id is a valid shelf id
2/ Notice the js is executed
3/ Apply patch
4/ Reload page
5/ Notice input is now escaped on display

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Tested in Debian, couldn't reproduce the alert in Iceweasel, but in
Chromium. Patch fixes it.
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt