From 889a2f7a6c96e8b4d597b60464b6110098da7518 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 28 Jan 2016 20:33:58 +0000 Subject: [PATCH] Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro Works as described. Comma removed from title of the window and breadcrumb section Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e19db8ca32dd776263b73474ece4e17d88ab17b4) Signed-off-by: Julian Maurice --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 3b5c404aaa..f3611a861f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -24,7 +24,7 @@ [% SET protocol = "http://" %] [% END %] [% INCLUDE 'doc-head-open.inc' %] -[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Details for: [% title |html %][% FOREACH subtitl IN subtitle %], [% subtitl.subfield |html %][% END %] +[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Details for: [% title |html %][% FOREACH subtitl IN subtitle %][% UNLESS Koha.Preference('marcflavour')=='MARC21' %],[% END %] [% subtitl.subfield |html %][% END %] [% INCLUDE 'doc-head-close.inc' %] [% IF ( bidi ) %] [% BLOCK cssinclude %][% END %] @@ -40,7 +40,7 @@
-- 2.39.5