From 369e5ab93a10cd587be557fcb43de628e49f5dfa Mon Sep 17 00:00:00 2001 From: David Cook Date: Tue, 22 Oct 2024 23:57:57 +0000 Subject: [PATCH] Bug 38233: respect OPAC visibility for ILS-DI GetRecords This change makes the ILS-DI GetRecords service use the OPAC version of the MARCXML and filters items based on their OPAC visibility Test plan: 1. Apply the patch 2. koha-plack --restart kohadev 3. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI and enable syspref 4. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacHiddenItems and add the following: withdrawn: [1] 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=hidelostitems Change syspref to "Don't show" 6. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 7. Add a withdrawn item and a lost item with barcodes of "test1" and "test2" respectively 8. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 9. Note the items with barcodes test1 and test2 do not appear in the "items" tree and they don't appear in the "marcxml" tree. Signed-off-by: David Nind Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer --- C4/ILSDI/Services.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm index 957bcd82fb..891d193c68 100644 --- a/C4/ILSDI/Services.pm +++ b/C4/ILSDI/Services.pm @@ -218,7 +218,7 @@ sub GetRecords { my $biblioitem = $biblio->biblioitem->unblessed; - my $record = $biblio->metadata->record({ embed_items => 1 }); + my $record = $biblio->metadata->record({ embed_items => 1, opac => 1, }); if ($record) { $biblioitem->{marcxml} = $record->as_xml_record( C4::Context->preference('marcflavour') ); } @@ -236,7 +236,7 @@ sub GetRecords { foreach my $checkout (@$checkouts) { delete $checkout->{'borrowernumber'}; } - my @items = $biblio->items->as_list; + my @items = $biblio->items->filter_by_visible_in_opac->as_list; $biblioitem->{items}->{item} = []; -- 2.39.5