From 5af4fceeae85c6f55f9aca2c2f44ac927e435527 Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Tue, 23 Apr 2024 12:47:11 +0000
Subject: [PATCH] Bug 35979: (follow-up) Add check in ->enqueue

Foundation for removing same check elsewhere (later on).

Test plan:
Run t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

PA amended: Fix bug # in commit message

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit c317bb34c0bb59fd0f52b4e7c5c0d3326b0030ee)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit f09739fcec4dbefd487c12d169db6c76ccb903ce)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.pm        | 2 ++
 .../Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t     | 9 ++++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.pm b/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.pm
index 6419435d41..4c64a61d1a 100644
--- a/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.pm
+++ b/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.pm
@@ -129,6 +129,8 @@ Enqueue the new job
 sub enqueue {
     my ( $self, $args ) = @_;
 
+    return if !C4::Context->preference('RealTimeHoldsQueue');    #TODO Remove check from callers
+
     Koha::Exceptions::MissingParameter->throw(
         "Missing biblio_ids parameter is mandatory")
       unless exists $args->{biblio_ids};
diff --git a/t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t b/t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t
index 17e948ae9b..f4f3f20440 100755
--- a/t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t
+++ b/t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.t
@@ -32,12 +32,19 @@ my $builder = t::lib::TestBuilder->new;
 
 subtest 'enqueue() tests' => sub {
 
-    plan tests => 5;
+    plan tests => 6;
 
     $schema->storage->txn_begin;
 
     my $biblio_ids = [ 1, 2 ];
 
+    t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
+    is(
+        Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue( { biblio_ids => $biblio_ids } ),
+        undef, 'No result when pref is off'
+    );
+    t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 );
+
     throws_ok
         { Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue() }
         'Koha::Exceptions::MissingParameter',
-- 
2.39.5