From 5eb927b26d3b286d1a239e3bc3cbd591da42b146 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 19 Aug 2021 12:34:58 +0200
Subject: [PATCH] Bug 28881: (bug 23376 follow-up) Fix suggestion display on
 order receive page

On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2
occurrences have not been corrected.

It causes a bug on the order receive page when the bib is linked with a
suggestion.

Test plan:
Create an order from bib A, create a suggestion for purchase on bib A
(OPAC)
Receive the order.
Without the patch: Notice the "Suggested by: (suggestion #)"
With the patch you see the info of the suggester

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 14a690078a90641abb377d2a2fbda8039f23f5c7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 acqui/orderreceive.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl
index d3902de3bd..5747cbd86b 100755
--- a/acqui/orderreceive.pl
+++ b/acqui/orderreceive.pl
@@ -167,7 +167,7 @@ $template->param(
     gst_values            => \@gst_values,
 );
 
-my $suggestion = GetSuggestionInfoFromBiblionumber($order->{biblionumber});
+my $suggestion = GetSuggestionInfoFromBiblionumber($order->biblionumber);
 if ( $suggestion ) {
     $template->param( suggestion => $suggestion );
 }
@@ -191,7 +191,7 @@ foreach my $period (@$periods) {
           {
             b_id  => $r->{budget_id},
             b_txt => $r->{budget_name},
-            b_sel => ( $r->{budget_id} == $order->{budget_id} ) ? 1 : 0,
+            b_sel => ( $r->{budget_id} == $order->budget_id ) ? 1 : 0,
           };
     }
 
-- 
2.39.5