From a9acc621cae256e081b872488a1e14d97bb81e28 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Thu, 25 Apr 2024 19:27:24 +0000
Subject: [PATCH] Bug 36694: Remove HC sticky from
 preferences.tt/authorities.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/modules/admin/preferences.tt              | 11 +----------
 .../prog/en/modules/authorities/authorities.tt        | 10 +---------
 2 files changed, 2 insertions(+), 19 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
index c45dce5cd7..f682965e82 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
@@ -60,7 +60,7 @@
     <h2>[% TAB.tab_title | html %] preferences</h2>
     <form action="/cgi-bin/koha/admin/preferences.pl" method="post">
         [% INCLUDE 'csrf-token.inc' %]
-        [% UNLESS ( searchfield ) %]<div id="toolbar"><button class="save-all btn btn-primary" type="submit">Save all [% TAB.tab_title | html %] preferences</button></div>[% END %]
+        [% UNLESS ( searchfield ) %]<div id="toolbar" class="sticky"><button class="save-all btn btn-primary" type="submit">Save all [% TAB.tab_title | html %] preferences</button></div>[% END %]
         <input type="hidden" name="op" value="cud-save" />
         <input type="hidden" name="tab" value="[% TAB.tab_id | html %]" />
 
@@ -277,7 +277,6 @@
 
 [% MACRO jsinclude BLOCK %]
     [% INCLUDE 'datatables.inc' %]
-    [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %]
     [% Asset.js("lib/jquery/plugins/multiple-select/multiple-select.min.js") | $raw %]
     [% Asset.js( "lib/codemirror/codemirror.min.js" ) | $raw %]
     [% Asset.js( "lib/codemirror/css.min.js" ) | $raw %]
@@ -296,16 +295,8 @@
     [% Asset.js( "lib/sortable/Sortable.min.js" ) | $raw %]
 
     <script>
-        var Sticky;
         var themelang = "[% themelang | html %]";
         $(document).ready(function(){
-            [% UNLESS ( searchfield ) %]
-                Sticky = $("#toolbar");
-                Sticky.hcSticky({
-                    stickTo: "main",
-                    stickyClass: "floating"
-                });
-            [% END %]
             $("select[multiple='multiple']").multipleSelect( {
                 placeholder: _("Please select ..."),
                 selectAllText: _("Select all"),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
index ea7034eed0..85cf272b90 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
@@ -13,7 +13,6 @@
     [% t("Koha") | html %]
 [% END %]</title>
 [% INCLUDE 'doc-head-close.inc' %]
-[% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %]
 [% INCLUDE 'select2.inc' %]
 <script>
     [% IF Koha.Preference('CreateAVFromCataloguing') && CAN_user_parameters_manage_auth_values %]
@@ -30,7 +29,6 @@
     $(window).load(function(){
         $("#loading").hide();
     });
-    var Sticky;
     $(document).ready(function() {
 
         $("a[data-bs-toggle='tab']").on("shown.bs.tab", function (e) {
@@ -51,12 +49,6 @@
         initializeSortable("#authoritytabs ul.sortable_field");
         initializeSortable("#authoritytabs ul.sortable_subfield");
 
-        Sticky = $("#toolbar");
-        Sticky.hcSticky({
-            stickTo: "#f",
-            stickyClass: "floating"
-        });
-
         $("#addauth").click(function(){
             if(Check()){
                 $("#f").submit();
@@ -485,7 +477,7 @@
                     <input type="hidden" value="0" id="confirm_not_duplicate" name="confirm_not_duplicate" />
                     <input type="hidden" name="changed_authtype" value="" />
 
-                    <div id="toolbar" class="btn-toolbar">
+                    <div id="toolbar" class="btn-toolbar sticky">
                         <div class="btn-group"><a href="#" id="addauth" class="btn btn-primary" accesskey="w"><i class="fa fa-save"></i> Save</a></div>
                         <div class="btn-group">
                             [% IF ( authid ) %]
-- 
2.39.5