From 3dbbeee6107f0f61c57cd3443dd61b0a6e5eb9f7 Mon Sep 17 00:00:00 2001
From: Julian Maurice <julian.maurice@biblibre.com>
Date: Fri, 3 Feb 2023 11:58:51 +0100
Subject: [PATCH] Bug 32820: Fix cataloguing/value_builder/stocknumberAV.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9a672aed3d45b3741169565b17432e42c962c7d3)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
(cherry picked from commit f121caf3a3300e6f9e4ee5dc47c5129133e8a6a4)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit ec7535a14f23b50b69914b6c14e95f5cbdb77dd8)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
---
 cataloguing/value_builder/stocknumberAV.pl | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/cataloguing/value_builder/stocknumberAV.pl b/cataloguing/value_builder/stocknumberAV.pl
index 793cf1066a..c158ec7688 100755
--- a/cataloguing/value_builder/stocknumberAV.pl
+++ b/cataloguing/value_builder/stocknumberAV.pl
@@ -47,8 +47,9 @@ my $builder = sub {
     my ( $params ) = @_;
     my $res = qq{
     <script>
-        function Click$params->{id}() {
-                var code = document.getElementById('$params->{id}');
+        function Click$params->{id}(ev) {
+                ev.preventDefault();
+                var code = document.getElementById(ev.data.id);
                 \$.ajax({
                     url: '/cgi-bin/koha/cataloguing/plugin_launcher.pl',
                     type: 'POST',
@@ -57,7 +58,7 @@ my $builder = sub {
                         'code'    : code.value,
                     },
                     success: function(data){
-                        var field = document.getElementById('$params->{id}');
+                        var field = document.getElementById(ev.data.id);
                         field.value = data;
                         return 1;
                     }
-- 
2.39.5