From a41a3f5ecbf47c34a3d2b956fed3f618f895854d Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 16 Nov 2023 14:12:17 +0000
Subject: [PATCH] Bug 35351: Adjust basket details template to avoid showing
 empty page-section

This patch makes a minor change to the markup of the basket details page
so that we don't display an empty div.page-section when there are no
orders.

Note: This patch includes whitespace changes, so please ignore
whitespace when viewing the diff.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and add a basket if necessary.
- View the details of an empty basket.
- Under the "General information" or "Settings" sections there should be
  no empty white box.
- View the details of a basket which has orders (using the "Add to
  basket" process if necessary).
  - Orders should be displayed correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit dde374e2ad1fa69deaebf21c2a569ecdb4c12594)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 1b11a323f5df01ef78a03fa8918ca0c8a4455732)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
index cb547aa526..227590042b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
@@ -450,8 +450,8 @@
                                     </div>
                                 [% END %]
 
-                                <div id="acqui_basket_content" class="page-section">
-                                    [% IF ( books_loop ) %]
+                                [% IF ( books_loop ) %]
+                                    <div id="acqui_basket_content" class="page-section">
                                         <h2>Orders</h2>
                                         <table id="orders">
                                             <thead>
@@ -694,9 +694,9 @@
                                                 [% END %]
                                             </tbody>
                                         </table> <!-- /#orders -->
-                                    [% END # / IF ( books_loop ) %]
-                                    [% IF ( listincgst ) %]<small class="highlight">** Vendor's listings already include tax.</small>[% END %]
-                                </div> <!-- /#acqui_basket_content -->
+                                        [% IF ( listincgst ) %]<small class="highlight">** Vendor's listings already include tax.</small>[% END %]
+                                    </div> <!-- /#acqui_basket_content -->
+                                [% END # / IF ( books_loop ) %]
 
                                 [% IF (cancelledorders_loop) %]
                                     <div id="cancelledorders" class="page-section">
-- 
2.39.5