From 54765867b27d2d15f49033ecf1e0c5b36a0176ef Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Fri, 22 Apr 2022 07:33:28 +0000
Subject: [PATCH] Bug 28998: (follow-up) Add warning on about for missing key

Test plan:
Make sure that you have no encryption_key in koha-conf.
Check about page, system information tab.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 about.pl                                         | 4 ++++
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/about.pl b/about.pl
index 55ffc379fb..ba3434184f 100755
--- a/about.pl
+++ b/about.pl
@@ -277,6 +277,10 @@ if ( ! C4::Context->config('tmp_path') ) {
     }
 }
 
+if( ! C4::Context->config('encryption_key') ) {
+    push @xml_config_warnings, { error => 'encryption_key_missing' };
+}
+
 # Test Zebra facets configuration
 if ( !defined C4::Context->config('use_zebra_facets') ) {
     push @xml_config_warnings, { error => 'use_zebra_facets_entry_missing' };
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
index 30776fc5f9..b05ef269f8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
@@ -484,6 +484,13 @@
                         The effective temporary directory is '[% config_entry.effective_tmp_dir | html %]'.
                     </td>
                 </tr>
+                [% ELSIF config_entry.error == 'encryption_key_missing' %]
+                <tr>
+                    <th scope="row"><strong>Warning</strong></th>
+                    <td>You are missing the &lt;encryption_key&gt; entry in your koha-conf.xml file.
+                        Please generate a key. We recommend one of at least 32 bytes. (You might use 'pwgen 32' to do so.)
+                    </td>
+                </tr>
                 [% END %]
             [% END %]
             </table>
-- 
2.39.5