From b735313017f574cd0bec35f38d8f824c709ec7f5 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 15 Oct 2021 18:27:16 +0000 Subject: [PATCH] Bug 29255: Built-in offline circulation broken with SQL error MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch makes a minor correction to one of the queries used when synchronizing transactions in the built-in offline circulation system. This fixes the error: DBD::mysql::st execute failed: Column 'branchcode' in field list is ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84 To test you must be using a browser which still supports applicationCache (Firefox before version 81, Chrome before version 94). - Apply the patch and restart services. - Enable the AllowOfflineCirculation system preference. - Go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click the "Download records" button. - After the page refreshes you should see updated dates where it lists "last synced" information. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 6501ff67ac1b7942f424bed458314efb0132bd68) Signed-off-by: Fridolin Somers (cherry picked from commit 7f21bd6a5e796bc5358c98448181d3e779f7a8c5) Signed-off-by: Victor Grousset/tuxayo --- offline_circ/download.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/offline_circ/download.pl b/offline_circ/download.pl index 386faebf41..22d9f37dc5 100755 --- a/offline_circ/download.pl +++ b/offline_circ/download.pl @@ -36,7 +36,7 @@ my $req_data = $query->param('data') || ''; my $patrons_query = q{SELECT borrowers.borrowernumber, cardnumber, surname, firstname, title, othernames, initials, streetnumber, streettype, address, address2, city, - state, zipcode, country, email, phone, mobile, fax, dateofbirth, branchcode, + state, zipcode, country, email, phone, mobile, fax, dateofbirth, borrowers.branchcode, categorycode, dateenrolled, dateexpiry, COALESCE(gonenoaddress, 0) AS gonenoaddress, COALESCE(lost, 0) AS lost, debarred, debarredcomment, SUM(accountlines.amountoutstanding) AS fine -- 2.39.5