From 5e6698c7f177b8553792c83cbb4bd1717c6be48c Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Wed, 6 Jan 2021 11:47:59 +0100 Subject: [PATCH] Bug 27349: Fix Mana system preference wrong type Mana system preference type 'YesNo' is wrong since it has 3 values. Change to 'Choice' Test plan : 1) Run atomic update 2) Check in database 'Mana' system preference type is 'Choice' Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 557d2137d6dcfa1ce6f816c1d55c254418fe581c) Signed-off-by: Fridolin Somers (cherry picked from commit 3b464f56d31a84a5a6cca6ce4e1d1a7009aa83a1) Signed-off-by: Andrew Fuerste-Henry --- installer/data/mysql/atomicupdate/bug_27349.sql | 1 + installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_27349.sql diff --git a/installer/data/mysql/atomicupdate/bug_27349.sql b/installer/data/mysql/atomicupdate/bug_27349.sql new file mode 100644 index 0000000000..23324f7a00 --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_27349.sql @@ -0,0 +1 @@ +UPDATE systempreferences SET `type` = 'Choice' WHERE `variable` = 'Mana'; diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 3483f16d7e..2e4d6a62e0 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -301,7 +301,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('LocalHoldsPriorityItemControl', 'holdingbranch', 'holdingbranch|homebranch', 'decides if the feature operates using the item''s home or holding library.', 'Choice'), ('LocalHoldsPriorityPatronControl', 'PickupLibrary', 'HomeLibrary|PickupLibrary', 'decides if the feature operates using the library set as the patron''s home library, or the library set as the pickup library for the given hold.', 'Choice'), ('makePreviousSerialAvailable','0','','make previous serial automatically available when collecting a new serial. Please note that the item-level_itypes syspref must be set to specific item.','YesNo'), -('Mana','2',NULL,'request to Mana Webservice. Mana centralize common information between other Koha to facilitate the creation of new subscriptions, vendors, report queries etc... You can search, share, import and comment the content of Mana.','YesNo'), +('Mana','2',NULL,'request to Mana Webservice. Mana centralize common information between other Koha to facilitate the creation of new subscriptions, vendors, report queries etc... You can search, share, import and comment the content of Mana.','Choice'), ('ManInvInNoissuesCharge','1',NULL,'MANUAL_INV charges block checkouts (added to noissuescharge).','YesNo'), ('MARCAuthorityControlField008','|| aca||aabn | a|a d',NULL,'Define the contents of MARC21 authority control field 008 position 06-39','Textarea'), ('MarcFieldDocURL', NULL, NULL, 'URL used for MARC field documentation. Following substitutions are available: {MARC} = marc flavour, eg. "MARC21" or "UNIMARC". {FIELD} = field number, eg. "000" or "048". {LANG} = user language, eg. "en" or "fi-FI"', 'free'), diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index be301b6d40..0a022d5e36 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -17266,7 +17266,7 @@ if( CheckVersion( $DBversion ) ) { } $dbh->do(q{ INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES - ('Mana','2',NULL,'request to Mana Webservice. Mana centralize common information between other Koha to facilitate the creation of new subscriptions, vendors, report queries etc... You can search, share, import and comment the content of Mana.','YesNo'); + ('Mana','2',NULL,'request to Mana Webservice. Mana centralize common information between other Koha to facilitate the creation of new subscriptions, vendors, report queries etc... You can search, share, import and comment the content of Mana.','Choice'); }); $dbh->do(q{ INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES -- 2.39.5