]> git.koha-community.org Git - koha.git/commit
Bug 27569: Fix CSV export for biblio frameworks
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 1 Feb 2021 13:50:52 +0000 (14:50 +0100)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Tue, 16 Mar 2021 17:06:04 +0000 (18:06 +0100)
commitf6a5960f83d02d3b97f2f49aba65c8b418637856
treedaa9fff942c1eb36b905672ff71502e59016b3fb
parent451bff07f868172ba1d275db6ac499f593017802
Bug 27569: Fix CSV export for biblio frameworks

The CSV import of the biblio frameworks is broken.
A change in LibreOffice resulted in CSV not formatted how the
C4::ImportExportFramework code is expected.
This code is quite broken, it expects all the CSV cells to be quoted.

The "add tests" patch shows the different between what we expected
before this patch, and what is the new version generated by LibreOffice.

Test plan:
Export a biblio framework in CSV
Open it with LibreOffice and save it undef a different name
Create a new biblio framework and use the new file to construct it
Compare the 2 frameworks and make sure they are identical

Signed-off-by: Ron Houk <rhouk@ottumwapubliclibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ad5de74cbc43e500c34ae6fa50958c6848d1586f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 69ff54b1945142da58f73a80bb3d2890339013b6)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit b8410536dcdbb772fe593b2c3cf7a3985437c977)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/ImportExportFramework.pm