From 7f787efafa1916da648d459ed6f6f2765264322e Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Thu, 28 Jan 2016 21:58:37 +0000
Subject: [PATCH] Bug 15699 - Course reserves instructors should be in form
 "Surname, Firstname" for sorting purposes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

This patch changes the order of the name fields and adds a span class around
each in case of library wanting to customize further

To test:
1 - Enable course reserves
2 - Add some courses with instrcutors
3 - Note they are of form "Firstname Surname"
4 - Apply patch
5 - Note the change
6 - Note span tags
7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide();

Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting
the names would need some more actions but seems not to be intended by this patch.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 4dba088549d1add43cfd575ebdd3d21689c4a700)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit f232ce8bdc54f9b2e244da2290888ac2454cee8b)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
---
 .../opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
index 3aaa8b9ffc..7c63dcc6b6 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt
@@ -47,7 +47,7 @@
                                     <td>[% AuthorisedValues.GetByCode( 'TERM' c.term ) %]</td>
                                     <td>
                                       [% FOREACH i IN c.instructors %]
-                                          <div class="instructor">[% i.firstname %] [% i.surname %]</div>
+                                          <div class="instructor"><span class"inst_surname">[% i.surname %]</span><span class="instr_separator">, </span><span class="instr_firstname">[% i.firstname %]</span></div>
                                       [% END %]
                                     </td>
                                     <td>[% c.public_note %]</td>
-- 
2.39.5