]> git.koha-community.org Git - koha.git/commit
Bug 16325: Do not return all suggestions if search for STATUS=''
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 3 May 2016 15:13:44 +0000 (16:13 +0100)
committerJulian Maurice <julian.maurice@biblibre.com>
Mon, 16 May 2016 11:24:14 +0000 (13:24 +0200)
commit95a6403bf1f42e8a6453fd3f10b50b005145f8d6
treebf146919b220ef1415abfacffaf601ef4b034882
parentc95c2c671a63325c501488135e13d347b3d6ba29
Bug 16325: Do not return all suggestions if search for STATUS=''

This is a quick and dirty way to fix a bad bug in a messy area.
The "unknown status" tab in the suggestions table display all the
suggestions. It should only display suggestions with a STATUS=''

Test plan:
- Create some suggestions
- Go to Home > Acquisitions > Suggestions management
- Edit some suggestions and give them different status,
e.g. accepted, rejected, pending.
- Verify that they appear in the tabs as appropriate
- Edit one suggestion, set "Mark selected as" to --Choose a status--
=> Without this patch: New tab "Status unknown" containing all
suggestions
=> With this patch: tab contains only suggestions with "Unknown status"

Works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
(cherry picked from commit 44e0cb2895f5e9fbf541603f5497f67f58fd5baf)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
C4/Suggestions.pm