]> git.koha-community.org Git - koha.git/commit
Bug 16202: GetIssuingCharges should return a collectable amount
authorColin Campbell <colin.campbell@ptfs-europe.com>
Tue, 5 Apr 2016 11:56:24 +0000 (12:56 +0100)
committerMason James <mtj@kohaaloha.com>
Fri, 17 Mar 2017 13:08:39 +0000 (02:08 +1300)
commitea70d6dfdff378dfad5570d32b33ea2b163ee569
tree8880f558bd11c5927346501f5896a79550e238fc
parent1a565cf3c82c6ac410495d0da718bdbc6dd2f057
Bug 16202: GetIssuingCharges should return a collectable amount

Charges should not include elements less than a penny/cent
they are not displayed but can be saved to the database
causing "odd" behaviour down the line

Make the routine round the resultant charge to nearest cent,
so consistent values are returned.
Removed the one case where it was rounded post call.
Although the main danger is values generated by the discount
calculation apply the rounding to all returned charges in case
the item charge is defined using the 3rd or 4th decimal
places.

NOTE: prove -v t/db_dependent/Circulation.t triggers the change.
      Though, all the returned amounts are 0.00 only.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit d84ed89557e2c921f261b1c620434d432dcbd3f7)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
C4/Circulation.pm