]> git.koha-community.org Git - koha.git/commit
Bug 11795 - Use validation plugin when creating new Z39.50 server
authorOwen Leonard <oleonard@myacpl.org>
Wed, 19 Feb 2014 18:05:19 +0000 (13:05 -0500)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 21 May 2014 08:03:55 +0000 (10:03 +0200)
commitb303105dc90910fd0b5faddc1a9495bd8034d213
treeaf7acc2c583c27a56e51813145037f2154dd9ef8
parentcb9915e75e20a694fc78ba8bf4ac664b1c66934b
Bug 11795 - Use validation plugin when creating new Z39.50 server

The page for adding a new Z39.50 server includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.

To test, apply the patch and go to Administration -> Z39.50 client
targets -> New Z39.50 server. Try submitting the form with any of the
following error conditions:

- Missing Z39.50 server name
- Missing hostname
- Missing port
- Non-numeric port
- Missing database
- Non-numeric rank
- Non-numeric timeout

These errors should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing
an existing Z39.50 server should also work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: replace tabs with spaces

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 19bf1e9a40ab5a8f3c86fb07dd6429bfc44f703b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt