]> git.koha-community.org Git - koha.git/commit
Bug 19812: Fix confusing holds count values in "Already received" table
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 14 Dec 2017 12:03:39 +0000 (07:03 -0500)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 14 May 2018 14:47:28 +0000 (14:47 +0000)
commit094515fb74329c6ecee822070e5eb3e7789af6ff
treef09fd7a8f1340a1f11f341e4f992987448b70b80
parentc224db15d7298381d3a1ea07f6f8d20b50fe7d3f
Bug 19812: Fix confusing holds count values in "Already received" table

In acqui/parcel.pl both the "Pending orders" and "Already received" tables show how many holds there are for the given record. However, the count of holds in the "Pending orders" table confuses librarians because it only lists holds for the particular items in the orderline. Due to that, the holds column may show 0 holds even if there are a dozen record level holds for that bib! This is not what librarians seem to expect, instead it seems that the same total holds in the "Pending orders" table would be preferred.

Test Plan:
1) Find an invoice with an item in the "Already received" table
2) Add one or more record level holds to the record
3) Note the holds column does not count those holds
4) Apply this patch
5) Note the holds column now shows total holds and holds for just those ordered items

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Bug 19812: (QA follow-up) Swap sides for total and item holds

Bug 19812: (QA follow-up) If 0 holds show '0' not '0 / 0'

Bug 19812: (QA follow-up) Remove unnecessary line

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
acqui/parcel.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt