]> git.koha-community.org Git - koha.git/commit
Bug 35570: (QA follow-up): Follow QA script on Standard backend
authorPedro Amorim <pedro.amorim@ptfs-europe.com>
Fri, 15 Dec 2023 16:20:58 +0000 (16:20 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Thu, 31 Oct 2024 07:05:22 +0000 (08:05 +0100)
commitd3835cc4da4539615b6de3eb927aa091e5ad2854
treea8946334762c41544f8948235311d8e75bd2c0b7
parent83e8f0e0c3cbfaa2114d9c0c7d0a1ae21c63b8fe
Bug 35570: (QA follow-up): Follow QA script on Standard backend

Make QA script green, fix:
- Variables declared in condition
- Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840)
- missing_filter
- forbidden pattern: Do not use line breaks inside template tags (bug 18675)
- Attribute type should not be used for script tags (bug 20053)
- File must have the exec flag
- forbidden pattern: trailing space char
- valid_template: /shared-includes/custom_fields.inc: not found

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
16 files changed:
Koha/ILL/Backend/Standard.pm
Koha/ILL/Backend/intra-includes/cancel.inc
Koha/ILL/Backend/intra-includes/confirm.inc
Koha/ILL/Backend/intra-includes/create.inc
Koha/ILL/Backend/intra-includes/edititem.inc
Koha/ILL/Backend/intra-includes/migrate.inc
Koha/ILL/Backend/opac-includes/create.inc
Koha/ILL/Backend/shared-includes/custom_fields.inc
Koha/ILL/Backend/shared-includes/forms/article.inc
Koha/ILL/Backend/shared-includes/forms/book.inc
Koha/ILL/Backend/shared-includes/forms/chapter.inc
Koha/ILL/Backend/shared-includes/forms/conference.inc
Koha/ILL/Backend/shared-includes/forms/journal.inc
Koha/ILL/Backend/shared-includes/forms/resource.inc
Koha/ILL/Backend/shared-includes/forms/thesis.inc
installer/data/mysql/atomicupdate/bug_35570.pl [changed mode: 0644->0755]