]> git.koha-community.org Git - koha.git/commit
Bug 21874: Fix encoding of cart and list email subjects
authorKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 23 Nov 2018 10:30:49 +0000 (11:30 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 19 Dec 2018 12:45:31 +0000 (13:45 +0100)
commited654e9a89a59488049728b34eee1cc7a2c3c31c
treee8a8168b602fafe20422a9ca608a586dda1171fd
parentaaa26d83a91fb4a77fbf8f6bc04c02509252ab0e
Bug 21874: Fix encoding of cart and list email subjects

The subject of the cart and list emails is not correctly
encoded and displays incorrectly in some email clients.

To test:

Lists:
- Create a list, name it using umlauts or other diacritics
  Example:  Jugendbücher (books for youths in German)
- Add some items to your list
- Email yourself the list
- Verify that the email subject is broken

Cart:
- Install another language with non-latin characters like Greek
- Fill the cart with some titles
- Send yourself the cart
- Verify that the email subject is broken

Note: Some email clients display correctly, others not.
      It's known to be incorrect in Outlook and web.de,
      displaying nicely in Thunderbird.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested all four scripts by manipulating the cart text too in templates.
Follow-up handles intranet sendshelf.

Note: I asked Katrin to remove the encode UTF-8 statements, since we
convert to MIME and the subject line should never be UTF-8.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit e40bb00ab8da87c8c5d6e660de928d24b887df17)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
(cherry picked from commit c58f6e5a12a711fe81e7c4f393f1c04db2eae5bb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
basket/sendbasket.pl
opac/opac-sendbasket.pl
opac/opac-sendshelf.pl
virtualshelves/sendshelf.pl