]> git.koha-community.org Git - koha.git/commit
Bug 30493: Pending archived suggestions appear on intranet home page
authorBaptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Thu, 13 Jun 2024 13:36:18 +0000 (15:36 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 18 Jul 2024 19:31:50 +0000 (19:31 +0000)
commit5db98bbd65bc0498bbb916c148076b258e5135ad
tree61350009c3cd319c69bec8742ef9b271300c666f
parent8f90db741304cfe0de83ed05d789d0ee5eba6f0a
Bug 30493: Pending archived suggestions appear on intranet home page

If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed.

WITHOUT PATCH:
1. Go to Acquisitions > Suggestions
2. Click on New purchase suggestion
3. Fill in the form (title only is fine)
4. Click on Submit your suggestion
5. Go to the home page (click the Koha logo)
   --> Notice it says that there is 1 pending suggestion
6. Go to Acquisitions
   --> Notice it says that there is 1 pending suggestion
7. Go to Suggestions
8. Click on the up arrow to the right of the Edit button and choose Archive
   --> There are no more pending suggestions
9. Go to the home page (click the Koha logo)
   --> Notice it says that there is 1 pending suggestion
10. Go to Acquisitions
   --> Notice it says that there is 1 pending suggestion

The search function was fetching suggestions without considering the
"archived" field. I now pick only suggestion that are pending AND not
archived.

WITH PATCH:
9. Go to the home page (click the Koha logo)
   --> Notice it says that there is no pending suggestion
10. Go to Acquisitions
   --> Notice it says that there is no pending suggestion

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit e87f4cd550e60d7955551abf44f4dd9c1fd332d5)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
acqui/acqui-home.pl
mainpage.pl