]> git.koha-community.org Git - koha.git/commit
Bug 10243: prevent holds queue from making transfer requests that contradict library...
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 14 May 2013 19:59:07 +0000 (14:59 -0500)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 5 Dec 2013 18:02:05 +0000 (15:02 -0300)
commita35dd76ed0465990a949cb9b89d394b4918949e6
tree025c18e4ec09b0bab94d9e4121951f56485e962e
parent7bec315b3ea51af3e376c372c262e2c8284fa52d
Bug 10243: prevent holds queue from making transfer requests that contradict library holds policy

For some reason MapItemsToHoldRequests will, as a last ditch effort,
grab what seems to be an arbitrary available item to fill a hold request,
even if it will violate the circulation rules for holds.

In other words, even if an item matches a "Holds policy by item type"
that says "From home library", a request to transfer that item to
another library will be added to the holds queue!

Test Plan:
1) Create a record with a an item at BranchA of item type BOOK
2) Set the holds policy such that itemtype BOOK for BranchA is set
   to "From home library"
3) Place a bib-level hold request for a patron with a pickup at BranchB
4) Run build_holds_queue.pl
5) You should now see a request for that item to be transfered to
   BranchB, even though the rules should not allow this.
6) Apply this patch
7) Run build_holds_queue.pl again
8) View the holds queue again, that request should no longer exist

Signed-off-by: Heather Braum <hbraum@nekls.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 78d27ad5393308ce097db9aa0dfe5c28aa40a516)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/HoldsQueue.pm