From b9b7d58bdda9cac766f405aec989be997879a871 Mon Sep 17 00:00:00 2001 From: Baptiste Wojtkowski Date: Thu, 13 Jun 2024 15:36:18 +0200 Subject: [PATCH] Bug 30493: Pending archived suggestions appear on intranet home page If suggestions are archived before their status is changed to something other than "Pending", they still appear on the intranet home page and the acquisitions home page as suggestions to be managed. WITHOUT PATCH: 1. Go to Acquisitions > Suggestions 2. Click on New purchase suggestion 3. Fill in the form (title only is fine) 4. Click on Submit your suggestion 5. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 6. Go to Acquisitions --> Notice it says that there is 1 pending suggestion 7. Go to Suggestions 8. Click on the up arrow to the right of the Edit button and choose Archive --> There are no more pending suggestions 9. Go to the home page (click the Koha logo) --> Notice it says that there is 1 pending suggestion 10. Go to Acquisitions --> Notice it says that there is 1 pending suggestion The search function was fetching suggestions without considering the "archived" field. I now pick only suggestion that are pending AND not archived. WITH PATCH: 9. Go to the home page (click the Koha logo) --> Notice it says that there is no pending suggestion 10. Go to Acquisitions --> Notice it says that there is no pending suggestion Signed-off-by: Lucas Gass Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer (cherry picked from commit e87f4cd550e60d7955551abf44f4dd9c1fd332d5) Signed-off-by: Lucas Gass (cherry picked from commit 5db98bbd65bc0498bbb916c148076b258e5135ad) Signed-off-by: Fridolin Somers --- acqui/acqui-home.pl | 2 +- mainpage.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/acqui/acqui-home.pl b/acqui/acqui-home.pl index 8e679727ad..f6ed46c454 100755 --- a/acqui/acqui-home.pl +++ b/acqui/acqui-home.pl @@ -53,7 +53,7 @@ if( C4::Context->only_my_library ){ my $local_pendingsuggestions_count = Koha::Suggestions->search({ status => "ASKED", branchcode => C4::Context->userenv()->{'branch'} })->count(); $template->param( suggestions_count => $local_pendingsuggestions_count ); } else { - my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED" }); + my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED", archived => 0 }); my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count(); my $pendingsuggestions_count = $pendingsuggestions->count(); $template->param( diff --git a/mainpage.pl b/mainpage.pl index e1c033f18a..d51703283d 100755 --- a/mainpage.pl +++ b/mainpage.pl @@ -91,7 +91,7 @@ if( C4::Context->only_my_library ){ my $local_pendingsuggestions_count = Koha::Suggestions->search({ status => "ASKED", branchcode => C4::Context->userenv()->{'branch'} })->count(); $template->param( pendingsuggestions => $local_pendingsuggestions_count ); } else { - my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED" }); + my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED", archived => 0 }); my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count(); my $pendingsuggestions_count = $pendingsuggestions->count(); $template->param( -- 2.39.5