]> git.koha-community.org Git - koha.git/commit
Bug 24813: Prevent api/v1/holds.t to fail randomly
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 5 Mar 2020 15:27:15 +0000 (16:27 +0100)
committerHayley Mapley <hayleymapley@catalyst.net.nz>
Tue, 14 Apr 2020 22:12:35 +0000 (10:12 +1200)
commitdb9102617e8db020fa5a598632538a7997612e95
tree28741f2687c8596d51c4a4827f0e9160ca23511c
parentef79c94ebd87813e5786c77b64793e8ff6fe40ff
Bug 24813: Prevent api/v1/holds.t to fail randomly

Hold cannot be suspended if found=W:
Koha::Hold->suspend_hold
 90     if ( $self->is_found ) {    # We can't suspend found holds

So when TestBuilder generate a hold with found=W the test fail.

A question however:
Why did not we have the correct exception displayed somewhere? That
would be much more helpful to find the problem!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit c405b03dd367adb7c1c274477865a7444f59c9e9)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 1993e98edf0c272d6d93e18292a5c8b79da4b458)

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
t/db_dependent/api/v1/holds.t