From 714ab3636fc6e48b85d1ee3b269b6bfc5918b632 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Wed, 12 Apr 2023 19:58:03 +0000 Subject: [PATCH] Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 2ce97da0e77812300bbfaa7fe579732da80364dd) Signed-off-by: Matt Blenkinsop (cherry picked from commit a6d93137b0878b858a36746de6f6678cfce00a74) Signed-off-by: Lucas Gass (cherry picked from commit 435c79b8a47b8ee47fd493ca4ac17a6413e9ba00) Signed-off-by: Arthur Suzuki --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt index 528f3eaa66..ded5645c93 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt @@ -641,7 +641,7 @@ [% ELSE # /IF ( SEARCH_RESULT.items_count ) %] - [% IF ( SEARCH_RESULT.ALTERNATEHOLDINGS ) %] + [% IF ( SEARCH_RESULT.ALTERNATEHOLDINGS.size ) %] Other holdings:
    [% FOREACH ALTERNATEHOLDING IN SEARCH_RESULT.ALTERNATEHOLDINGS %] -- 2.39.5