From fee8fc3193fba871f4c24f48ba6c8738543c3eea Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 24 Feb 2014 11:35:52 -0500 Subject: [PATCH] Bug 11832: fix JavaScript error on staff client place hold screen if record has no items If a hold operation is blocked because the title has no items attached the patron search autocomplete JavaScript triggers an error. This patch modifies the template so that the JS is loaded only when items are present. To test, find a title which has no items attached. View the holds page for that title. There should be no JavaScript error. Patron search autocomplete should still work correctly for titles which have items attached. Deleted all items from a biblio record. Clicked the holds tab and confirmed using firebug Javascript error occurs. Applied patch, confirmed that the Javascript error described in comment 1 no longer happens. Went to another biblio with items, and confirmed patron auto-complete still functions. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Galen Charlton (cherry picked from commit 0b5b8cef348b61761305dd0bbc574699404c7c69) Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall (cherry picked from commit 07dc616de5a7483f4fe061c046c55ae7d880c7cb) --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 75eea4d680..7b846a912f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -131,7 +131,7 @@ function checkMultiHold() { $('#hold-request-form').preventDoubleFormSubmit(); -[% UNLESS ( borrowernumber || borrower_list ) %] +[% UNLESS ( borrowernumber || borrower_list || noitems ) %] [% IF ( CircAutocompl ) %] $( "#patron" ).autocomplete({ source: "/cgi-bin/koha/circ/ysearch.pl", -- 2.39.5