]> git.koha-community.org Git - koha.git/commit
Bug 10519: Suggestions: 'Organize by' and correct display of tab descriptions broken
authorJacek Ablewicz <abl@biblos.pk.edu.pl>
Wed, 11 Jun 2014 06:51:34 +0000 (08:51 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 23 Jan 2015 12:50:25 +0000 (13:50 +0100)
commit3824e95ba1ee275419a657fbd6c42be913fb16ce
treef457b46a4a7e700c937061dc48d24d5171ececc4
parent8c78314d69b2d340530ab5570c35fd66c4720e9f
Bug 10519: Suggestions: 'Organize by' and correct display of tab descriptions broken

The tabbed display in suggestions offers different options to organize
the tabs. The descriptions on the tabs and some of the search options were
not working correctly, displaying as "Unknown".

To test:
- Add several suggestions to your installation, make sure you have:
  - suggestions from different users
  - suggestions managed by different users
  - suggestions with different statuses
  - suggestions with different selected item types

Test all the 'organize by' options (except "Organize by: Library"
- see note below), make sure that the tabs and search options
have correct descriptions and do no longer display as "Unknown".

- Add 1 or 2 custom status to SUGGEST_STATUS authorized value.
  - Verify display is still correct and your new status are displayed.

Note: "Organize by: Library" option is currently severely broken
(and not easily fixable, especially for 'IndependentBranches'
enabled). But this turns out to be a separate issue, with a different
underlaying causes, and it's outside the scope of this patch.
This should be dealt with later, in it's own bug report.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 17c0c5f9a507d0b34d98e66540f40ebc9de42845)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
suggestion/suggestion.pl