]> git.koha-community.org Git - koha.git/commit
Bug 14329: Useless copy/pasta from Template::Plugin::HtmlToText
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 4 Jun 2015 10:03:42 +0000 (12:03 +0200)
committerLiz Rea <wizzyrea@gmail.com>
Mon, 15 Jun 2015 22:13:56 +0000 (10:13 +1200)
commitb2a8948b989ddbdb1a4f80122eee3d499abfa6ad
treeae4ab56828a981404ab50df126378039cd393b00
parent6be5837e06bf8157b236e9bc48889bfd7ae90293
Bug 14329: Useless copy/pasta from Template::Plugin::HtmlToText

The synopsis of this TT plugin contains two example lines:
[% myhtml FILTER html2text(leftmargin => 0, rightmargin => 0) %]
[% myhtmltext | html2text %]

These lines have been copied (without too much thought :) to a few templates. Since we do no use the variables myhtml or myhtmltext in these templates, these lines are useless.

Test plan:
[1] Put some items in your cart. And send it.
[2] Send a shelf.
[3] Git grep on myhtml. Should not have results.

NOTE: Sent carts and lists in Intranet and OPAC successfully.
      Though, this does bring into question why the letters
      have HTML formatting if it is getting removed. That,
      however, is beyond the scope of this bug.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 4fd923e12eea70b7e871f0068471ff5ef91dda01)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt